Re: [PR] [CELEBORN-1829] Replace waitThreadPoll's thread pool with ScheduledExecutorService in Controller [celeborn]

2025-01-17 Thread via GitHub
RexXiong commented on code in PR #3059: URL: https://github.com/apache/celeborn/pull/3059#discussion_r1920957814 ## worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala: ## @@ -730,6 +742,58 @@ private[deploy] class Controller( } } + def ch

[PR] Bump TsFile version to 2.0.0-250118-SNAPSHOT [iotdb]

2025-01-17 Thread via GitHub
jt2594838 opened a new pull request, #14723: URL: https://github.com/apache/iotdb/pull/14723 To revert a change in TsFile that will make the memory calculation of Binary too expensive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-50874][ML][PYTHON][CONNECT] Support `LinearRegression` on connect [spark]

2025-01-17 Thread via GitHub
zhengruifeng commented on PR #49553: URL: https://github.com/apache/spark/pull/49553#issuecomment-2599528794 The python linter passed in the last run merged to master/4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920957468 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/AsyncContinuousEventTimeTrigger.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to t

Re: [PR] [SPARK-50874][ML][PYTHON][CONNECT] Support `LinearRegression` on connect [spark]

2025-01-17 Thread via GitHub
zhengruifeng closed pull request #49553: [SPARK-50874][ML][PYTHON][CONNECT] Support `LinearRegression` on connect URL: https://github.com/apache/spark/pull/49553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920956871 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +66,13 @@ public abstract Collection assignWindows(

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920956433 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java: ## @@ -88,6 +93,12 @@ public static void ma

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920955938 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/triggers/AsyncTrigger.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apa

Re: [PR] [CELEBORN-1836][CIP-14] Add Message to cppClient [celeborn]

2025-01-17 Thread via GitHub
RexXiong closed pull request #3066: [CELEBORN-1836][CIP-14] Add Message to cppClient URL: https://github.com/apache/celeborn/pull/3066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] GH-45263: [MATLAB] Add ability to construct `RecordBatchStreamReader` from `uint8` array [arrow]

2025-01-17 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45274: URL: https://github.com/apache/arrow/pull/45274#issuecomment-2599527551 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1fe27fead07a299325e363bb889559a49c09d6ab. There were no

Re: [PR] [CELEBORN-1836][CIP-14] Add Message to cppClient [celeborn]

2025-01-17 Thread via GitHub
RexXiong commented on PR #3066: URL: https://github.com/apache/celeborn/pull/3066#issuecomment-2599527086 Thanks merge to main(v0.6.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Support preserving history of HELIX_ENABLED legacy fields when combo of instance operation and old helix version are used [helix]

2025-01-17 Thread via GitHub
xyuanlu merged PR #2987: URL: https://github.com/apache/helix/pull/2987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache

Re: [I] Spaceship operator (<=>) not supported [datafusion]

2025-01-17 Thread via GitHub
Spaarsh commented on issue #14098: URL: https://github.com/apache/datafusion/issues/14098#issuecomment-2599524998 Apologies for the delay! @ion-elgreco is this the output you are expecting? If so, I shall make a PR including some tests as well! ![Image](https://github.com/user-attachment

Re: [PR] HBASE-29085 [hbase-thirdparty] Add spotless plugin [hbase-thirdparty]

2025-01-17 Thread via GitHub
Apache-HBase commented on PR #129: URL: https://github.com/apache/hbase-thirdparty/pull/129#issuecomment-2599524657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s

[PR] [MINOR][DOCS] Fix miss semicolon on list file sql example [spark]

2025-01-17 Thread via GitHub
camilesing opened a new pull request, #49561: URL: https://github.com/apache/spark/pull/49561 ### What changes were proposed in this pull request? fix miss semicolon on list file SQL example ### Why are the changes needed? list file SQL example miss semicolon

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on PR #18602: URL: https://github.com/apache/kafka/pull/18602#issuecomment-2599523365 @chia7712 I think this commit should fix the initialization issue. Since SPI is being used, it loads the extension for all tests. We need some additional filtering to not apply the Cluster

Re: [PR] KAFKA-18565: Cleanup SaslSetup [kafka]

2025-01-17 Thread via GitHub
frankvicky commented on PR #18586: URL: https://github.com/apache/kafka/pull/18586#issuecomment-2599523452 Failed tests are not related to this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920952684 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/AsyncContinuousEventTimeTrigger.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to t

Re: [PR] KAFKA-18515 Remove DelegationTokenManagerZk [kafka]

2025-01-17 Thread via GitHub
m1a2st commented on PR #18595: URL: https://github.com/apache/kafka/pull/18595#issuecomment-2599522925 Hi @clolov, do you think this PR should be backported to the 4.0 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920952622 ## test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/README.md: ## @@ -79,7 +79,7 @@ a JUnit extension called `ClusterTestExtensions` which know

Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]

2025-01-17 Thread via GitHub
mjsax commented on code in PR #18570: URL: https://github.com/apache/kafka/pull/18570#discussion_r1920952304 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskManagerTest.java: ## @@ -137,6 +137,8 @@ public void shouldBlockOnAwait() throws I

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920951003 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +66,13 @@ public abstract Collection assignWindows(

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920951057 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -19,13 +19,15 @@ package kafka.server import kafka.api.{KafkaSasl, SaslSetup} import k

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920950898 ## build.gradle: ## @@ -1364,6 +1365,9 @@ project(':metadata') { testImplementation project(':raft').sourceSets.test.output testImplementation project(':server

Re: [PR] fix: include commit_seqno for merge order [hudi-rs]

2025-01-17 Thread via GitHub
xushiyan merged PR #250: URL: https://github.com/apache/hudi-rs/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920950253 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java: ## @@ -88,6 +93,12 @@ public static void ma

Re: [PR] [HUDI-8881] trigger failure earlier in Flink Hudi sink [hudi]

2025-01-17 Thread via GitHub
hudi-bot commented on PR #12666: URL: https://github.com/apache/hudi/pull/12666#issuecomment-2599519754 ## CI report: * d04b0f1adb718574c2b2ba5687264c9620d7fed5 UNKNOWN * 268fdd3c756f37d0d3a6debf7f6a138222649ebb UNKNOWN * 2d91da44a581e5ab7063dfecc9d1fe3f424c356d Azure: [SUCC

Re: [PR] SOLR-17519: CloudSolrClient with HTTP ClusterState can forget live nodes and then fail [solr]

2025-01-17 Thread via GitHub
dsmiley commented on code in PR #2935: URL: https://github.com/apache/solr/pull/2935#discussion_r1920949678 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -226,17 +232,15 @@ public Set getLiveNodes() { } if (TimeUnit.S

Re: [PR] fix: include commit_seqno for merge order [hudi-rs]

2025-01-17 Thread via GitHub
codecov[bot] commented on PR #250: URL: https://github.com/apache/hudi-rs/pull/250#issuecomment-2599519355 ## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/250?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term

Re: [PR] HDFS-17651.[ARR] Async handler executor isolation [hadoop]

2025-01-17 Thread via GitHub
hadoop-yetus commented on PR #7244: URL: https://github.com/apache/hadoop/pull/7244#issuecomment-2599519186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] [CELEBORN-1792] MemoryManager resume should use pinnedDirectMemory instead of usedDirectMemory [celeborn]

2025-01-17 Thread via GitHub
RexXiong commented on code in PR #3018: URL: https://github.com/apache/celeborn/pull/3018#discussion_r1920949498 ## worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java: ## @@ -557,6 +580,47 @@ public static void reset() { _INSTANCE = nul

[PR] fix: include commit_seqno for merge order [hudi-rs]

2025-01-17 Thread via GitHub
xushiyan opened a new pull request, #250: URL: https://github.com/apache/hudi-rs/pull/250 ## Description - Add `MetaField` enum for Hudi meta fields. - Consider `_hoodie_commit_seqno` for merging when precombine values are equal ## How are the changes

[PR] [doc] Fix json_fun_* en_doc [doris-website]

2025-01-17 Thread via GitHub
mklzl opened a new pull request, #1862: URL: https://github.com/apache/doris-website/pull/1862 "json_array json_object json_quote json_unquote json_extract json_insert json_replace json_set json_exists_path jsonb_extract json_parse " ## Versions

[PR] [FLINK-37045] Remove useless StateDescriptor of state v2 [flink]

2025-01-17 Thread via GitHub
Zakelly opened a new pull request, #26009: URL: https://github.com/apache/flink/pull/26009 ## What is the purpose of the change This is a follow-up PR of #25925. We have moved those `StateDescriptor`s to `org.apache.flink.api.common.state.v2`, but left placeholders under the original

Re: [PR] chore(fe): migrate 6 Enzyme-based unit tests to RTL [superset]

2025-01-17 Thread via GitHub
hainenber commented on code in PR #31819: URL: https://github.com/apache/superset/pull/31819#discussion_r1920949159 ## superset-frontend/src/components/ListViewCard/ImageLoader.test.tsx: ## @@ -37,36 +38,48 @@ describe('ImageLoader', () => { const defaultProps = { src: '

Re: [PR] [HUDI-8881] trigger failure earlier in Flink Hudi sink [hudi]

2025-01-17 Thread via GitHub
hudi-bot commented on PR #12666: URL: https://github.com/apache/hudi/pull/12666#issuecomment-2599517074 ## CI report: * d04b0f1adb718574c2b2ba5687264c9620d7fed5 UNKNOWN * 268fdd3c756f37d0d3a6debf7f6a138222649ebb UNKNOWN * 2d91da44a581e5ab7063dfecc9d1fe3f424c356d Azure: [SUCC

Re: [PR] KAFKA-18529: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer [kafka]

2025-01-17 Thread via GitHub
TaiJuWu commented on PR #18554: URL: https://github.com/apache/kafka/pull/18554#issuecomment-2599515271 Thanks @kirktrue for good point and suggestion , I will revisit all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [KVM] Exclude watchdogs for ARM64 VM deployments [cloudstack]

2025-01-17 Thread via GitHub
blueorangutan commented on PR #10203: URL: https://github.com/apache/cloudstack/pull/10203#issuecomment-2599514462 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-17402: DefaultStateUpdated should transite task atomically [kafka]

2025-01-17 Thread via GitHub
mjsax opened a new pull request, #18607: URL: https://github.com/apache/kafka/pull/18607 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
NobiGo commented on code in PR #4151: URL: https://github.com/apache/calcite/pull/4151#discussion_r1920944243 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7960,6 +7960,32 @@ private void checkLiteral2(String expression, String expected

[PR] KAFKA-18430 Remove ZkNodeChangeNotificationListener [kafka]

2025-01-17 Thread via GitHub
m1a2st opened a new pull request, #18606: URL: https://github.com/apache/kafka/pull/18606 Jira: https://issues.apache.org/jira/browse/KAFKA-18430 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build sta

Re: [PR] [FLINK-37164][Runtime] Speed up state v2 synchronous methods execution [flink]

2025-01-17 Thread via GitHub
Zakelly merged PR #26005: URL: https://github.com/apache/flink/pull/26005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

2025-01-17 Thread via GitHub
Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920944894 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/triggers/AsyncTrigger.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apa

Re: [PR] chore(fe): dev deps cleanup [superset]

2025-01-17 Thread via GitHub
hainenber commented on PR #31908: URL: https://github.com/apache/superset/pull/31908#issuecomment-2599511037 Yes, there isn't a clear distinction so this is more of a definition correction for them Babel and Webpack plugin. There might be some vulnerability scanners employing heuristics of

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
NobiGo commented on code in PR #4151: URL: https://github.com/apache/calcite/pull/4151#discussion_r1920944243 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7960,6 +7960,32 @@ private void checkLiteral2(String expression, String expected

Re: [PR] Configure final reduce phase threads for heavy aggreagtion functions [pinot]

2025-01-17 Thread via GitHub
xiangfu0 commented on code in PR #14662: URL: https://github.com/apache/pinot/pull/14662#discussion_r1920944131 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java: ## @@ -157,16 +184,86 @@ public void finish(boolean sort, boolean storeFinalResult) {

Re: [PR] [SPARK-50770][SS] Removing package scope for transformWithState operator APIs [spark]

2025-01-17 Thread via GitHub
anishshri-db commented on PR #49417: URL: https://github.com/apache/spark/pull/49417#issuecomment-2599510084 @HeartSaVioR - PTAL when u get a chance, thx ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] chore: update scalafmt to 3.8.5 [pekko]

2025-01-17 Thread via GitHub
He-Pin opened a new pull request, #1731: URL: https://github.com/apache/pekko/pull/1731 Motivation: update scalafmt to 3.8.5 refs: https://github.com/apache/pekko/pull/1716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Update sbt-scalafmt to 2.5.3 [pekko]

2025-01-17 Thread via GitHub
He-Pin closed pull request #1716: Update sbt-scalafmt to 2.5.3 URL: https://github.com/apache/pekko/pull/1716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [I] [SUPPORT]Unable to read new data in streaming mode with specific timestamp [hudi]

2025-01-17 Thread via GitHub
xiearthur commented on issue #12661: URL: https://github.com/apache/hudi/issues/12661#issuecomment-2599509180 Yes, we did execute the job in streaming mode by setting: ```java options.put(FlinkOptions.READ_AS_STREAMING.key(), "true"); options.put(FlinkOptions.READ_START_COMMIT.ke

Re: [PR] SOLR-17562: Unify JAX-RS "raw response" endpoints [solr]

2025-01-17 Thread via GitHub
dsmiley commented on code in PR #3032: URL: https://github.com/apache/solr/pull/3032#discussion_r1920943164 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/InputStreamResponseParser.java: ## @@ -21,9 +21,16 @@ import org.apache.solr.client.solrj.ResponseParser; import

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
sonarqubecloud[bot] commented on PR #4151: URL: https://github.com/apache/calcite/pull/4151#issuecomment-2599508514 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sona

Re: [PR] KAFKA-18423: Remove ZkData [kafka]

2025-01-17 Thread via GitHub
m1a2st commented on PR #18605: URL: https://github.com/apache/kafka/pull/18605#issuecomment-2599508112 I think there are some Jira focus on removing other class https://issues.apache.org/jira/browse/KAFKA-18430 and https://issues.apache.org/jira/browse/KAFKA-18427 , Could you focus on remov

Re: [PR] Add fixed(L) type to variant spec [parquet-format]

2025-01-17 Thread via GitHub
aihuaxu commented on PR #481: URL: https://github.com/apache/parquet-format/pull/481#issuecomment-2599507994 > @aihuaxu I am not sure why we need this type in the Variant binary encoding. Doesn't this just duplicate the `binary` type? We don't need two different ways to store binary data.

Re: [PR] branch-3.0: [regression-test](fix) opensky_p2 case #47122 [doris]

2025-01-17 Thread via GitHub
shuke987 commented on PR #47124: URL: https://github.com/apache/doris/pull/47124#issuecomment-2599508074 skip buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [DO NOT MERGE][SPARK-50770][SS] Removing package scope for transformWithState operator APIs [spark]

2025-01-17 Thread via GitHub
anishshri-db commented on PR #49417: URL: https://github.com/apache/spark/pull/49417#issuecomment-2599507319 > this depends on Spark Connect integration work. Before that, do not merge. We discussed this offline and we are not going to treat connect work as a blocker for 4.0. We have

Re: [PR] [DO NOT MERGE][SPARK-50770][SS] Removing package scope for transformWithState operator APIs [spark]

2025-01-17 Thread via GitHub
anishshri-db commented on code in PR #49417: URL: https://github.com/apache/spark/pull/49417#discussion_r1920942256 ## sql/api/src/main/scala/org/apache/spark/sql/streaming/ExpiredTimerInfo.scala: ## @@ -26,7 +26,7 @@ import org.apache.spark.annotation.{Evolving, Experimental}

Re: [PR] sched/timer: remove critical section [nuttx]

2025-01-17 Thread via GitHub
hujun260 commented on code in PR #15561: URL: https://github.com/apache/nuttx/pull/15561#discussion_r1920942426 ## sched/timer/timer_initialize.c: ## @@ -132,23 +132,33 @@ void timer_initialize(void) void timer_deleteall(pid_t pid) { + timer_t deleted_timer[TIMER_MAX]; F

Re: [PR] KAFKA-18383: Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id [kafka]

2025-01-17 Thread via GitHub
chia7712 commented on code in PR #18478: URL: https://github.com/apache/kafka/pull/18478#discussion_r1920942202 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -376,7 +376,7 @@ RemoteStorageManager createRemoteStorageManager() { private void configureR

Re: [PR] [DO NOT MERGE][SPARK-50770][SS] Removing package scope for transformWithState operator APIs [spark]

2025-01-17 Thread via GitHub
anishshri-db commented on code in PR #49417: URL: https://github.com/apache/spark/pull/49417#discussion_r1920942256 ## sql/api/src/main/scala/org/apache/spark/sql/streaming/ExpiredTimerInfo.scala: ## @@ -26,7 +26,7 @@ import org.apache.spark.annotation.{Evolving, Experimental}

Re: [PR] [#6076] improve(CLI): Support model pre event to Gravitino server [gravitino]

2025-01-17 Thread via GitHub
Abyss-lord commented on PR #6250: URL: https://github.com/apache/gravitino/pull/6250#issuecomment-2599505979 @FANNG1 @xunliu @orenccl could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To re

Re: [PR] AVRO-4112: [C++][CMake] Do not find Boost when test is not built [avro]

2025-01-17 Thread via GitHub
thiru-mg merged PR #3293: URL: https://github.com/apache/avro/pull/3293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
ILuffZhe commented on code in PR #4151: URL: https://github.com/apache/calcite/pull/4151#discussion_r1920942011 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7960,6 +7960,32 @@ private void checkLiteral2(String expression, String expect

[I] The PostCommit Java Examples Dataflow V2 job is flaky [beam]

2025-01-17 Thread via GitHub
github-actions[bot] opened a new issue, #33653: URL: https://github.com/apache/beam/issues/33653 The PostCommit Java Examples Dataflow V2 is failing over 50% of the time. Please visit https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_Examples_Dataflow_V2.yml?query=is%3

[I] [Bug] go pull consumer consume fail when storeType=defaultRocksDB [rocketmq]

2025-01-17 Thread via GitHub
yuz10 opened a new issue, #9146: URL: https://github.com/apache/rocketmq/issues/9146 ### Before Creating the Bug Report - [x] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [x] I have

Re: [PR] [INLONG-7948][Manager] Add user authentication when operate inlong consume [inlong]

2025-01-17 Thread via GitHub
menghaining commented on code in PR #7949: URL: https://github.com/apache/inlong/pull/7949#discussion_r1920941387 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/InlongConsumeServiceImpl.java: ## @@ -194,8 +199,8 @@ public Integer update

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
ILuffZhe commented on code in PR #4151: URL: https://github.com/apache/calcite/pull/4151#discussion_r1920941374 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7971,15 +7971,17 @@ private void checkLiteral2(String expression, String expec

[PR] [doc] fix some agg functions doc [doris-website]

2025-01-17 Thread via GitHub
hechao-ustc opened a new pull request, #1861: URL: https://github.com/apache/doris-website/pull/1861 ## Versions - [ ] dev - [ ] 3.0 - [ ] 2.1 - [ ] 2.0 ## Languages - [ ] Chinese - [ ] English ## Docs Checklist - [ ] Checked by AI - [ ] Test

Re: [PR] [GoSDK + Prism] Support Process env execution. [beam]

2025-01-17 Thread via GitHub
lostluck merged PR #33651: URL: https://github.com/apache/beam/pull/33651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] POC: chore: use Hub [pekko]

2025-01-17 Thread via GitHub
He-Pin closed pull request #1705: POC: chore: use Hub URL: https://github.com/apache/pekko/pull/1705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
NobiGo commented on code in PR #4151: URL: https://github.com/apache/calcite/pull/4151#discussion_r1920939215 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7960,6 +7960,30 @@ private void checkLiteral2(String expression, String expected

Re: [PR] [INLONG-7774][Manager] Add permission verification for streamSource [inlong]

2025-01-17 Thread via GitHub
menghaining commented on code in PR #7775: URL: https://github.com/apache/inlong/pull/7775#discussion_r1920939025 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/StreamSourceServiceImpl.java: ## @@ -101,7 +101,8 @@ public Integer save(Sou

Re: [PR] KAFKA-18474: Remove zkBroker tag [kafka]

2025-01-17 Thread via GitHub
chia7712 commented on PR #18477: URL: https://github.com/apache/kafka/pull/18477#issuecomment-2599496150 @m1a2st could you please fix the conflicts? [KAFKA-18399](https://issues.apache.org/jira/browse/KAFKA-18399) is resolved already -- This is an automated message from the Apache Git S

Re: [PR] [INLONG-7774][Manager] Add permission verification for streamSource [inlong]

2025-01-17 Thread via GitHub
menghaining commented on code in PR #7775: URL: https://github.com/apache/inlong/pull/7775#discussion_r1920939025 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/StreamSourceServiceImpl.java: ## @@ -101,7 +101,8 @@ public Integer save(Sou

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
chia7712 commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920938027 ## build.gradle: ## @@ -1364,6 +1365,9 @@ project(':metadata') { testImplementation project(':raft').sourceSets.test.output testImplementation project(':serv

Re: [I] [Bug] [Module Name]oracle source connector连接oracle 11g时失败 [seatunnel]

2025-01-17 Thread via GitHub
RichardXu186 commented on issue #8537: URL: https://github.com/apache/seatunnel/issues/8537#issuecomment-2599495353 我重新验证了下,不是连不上oracle,而是我的源表中有个字段数据有"/"这样的特色符号,例如“/html/cm/pe/custinfo/distribute/queryDistributeInfoHis.html",因为这个原因造成了上述错误 -- This is an automated message from the Apache Gi

Re: [I] EventMesh 与 K8S 集成部署时遇到exec /bin/bash: exec format error (eventmesh)

2025-01-17 Thread via GitHub
qqeasonchen commented on issue #5166: URL: https://github.com/apache/eventmesh/issues/5166#issuecomment-2599494746 @TheR1sing3un currently uploaded image is based on arm and requires re-uploading the x 86 version of the -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]

2025-01-17 Thread via GitHub
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1920936787 ## newsfragments/template.significant.rst: ## @@ -3,20 +3,29 @@ .. Provide additional contextual information .. Check the type of change that applies to this change

Re: [PR] KAFKA-18275: Restarting broker in testing should use the same port [kafka]

2025-01-17 Thread via GitHub
chia7712 commented on code in PR #18381: URL: https://github.com/apache/kafka/pull/18381#discussion_r1920937538 ## test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestExtensionsTest.java: ## @@ -347,6 +350,30 @@ public void testControllerListene

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
ILuffZhe commented on code in PR #4151: URL: https://github.com/apache/calcite/pull/4151#discussion_r1920937599 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7960,6 +7960,30 @@ private void checkLiteral2(String expression, String expect

Re: [I] Release DataFusion `45.0.0` [datafusion]

2025-01-17 Thread via GitHub
shehabgamin commented on issue #14008: URL: https://github.com/apache/datafusion/issues/14008#issuecomment-2599492511 As promised, Sail is working on porting relevant tests into DataFusion. A good starting point is a regression our tests caught in DataFusion 43, which still seems to p

Re: [PR] fix: partially fix consistency issue of hash functions with decimal input [datafusion-comet]

2025-01-17 Thread via GitHub
wForget commented on code in PR #1295: URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937037 ## native/spark-expr/src/hash_funcs/utils.rs: ## @@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float { }; } +#[macro_export] +macro_rules! has

Re: [PR] [KAFKA-18442] Remove broken upgrade-downgrade-upgrade path. [kafka]

2025-01-17 Thread via GitHub
github-actions[bot] commented on PR #18424: URL: https://github.com/apache/kafka/pull/18424#issuecomment-2599492191 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP]KAFKA-18477 remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread [kafka]

2025-01-17 Thread via GitHub
github-actions[bot] commented on PR #18489: URL: https://github.com/apache/kafka/pull/18489#issuecomment-2599492176 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] fix: partially fix consistency issue of hash functions with decimal input [datafusion-comet]

2025-01-17 Thread via GitHub
wForget commented on code in PR #1295: URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937402 ## native/spark-expr/src/hash_funcs/utils.rs: ## @@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float { }; } +#[macro_export] +macro_rules! has

Re: [PR] Rename About.md to About-the-Community.md [iotdb-docs]

2025-01-17 Thread via GitHub
CritasWang merged PR #530: URL: https://github.com/apache/iotdb-docs/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.

Re: [I] META-INF/LICENSE and META-INF/NOTICE are not consistently added to jars [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on issue #1470: URL: https://github.com/apache/pekko/issues/1470#issuecomment-2599491257 Maybe be the SBT assembly problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] fix: partially fix consistency issue of hash functions with decimal input [datafusion-comet]

2025-01-17 Thread via GitHub
wForget commented on code in PR #1295: URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937037 ## native/spark-expr/src/hash_funcs/utils.rs: ## @@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float { }; } +#[macro_export] +macro_rules! has

Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1468: URL: https://github.com/apache/pekko/pull/1468#discussion_r1920936961 ## stream-testkit/src/main/scala/org/apache/pekko/stream/testkit/scaladsl/StreamTestKit.scala: ## @@ -53,10 +71,15 @@ object StreamTestKit { } /** INTERNAL API */

Re: [PR] [CALCITE-6756] Preserving CAST of STRING operand in binary comparison… [calcite]

2025-01-17 Thread via GitHub
sonarqubecloud[bot] commented on PR #4151: URL: https://github.com/apache/calcite/pull/4151#issuecomment-2599490739 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sona

Re: [I] EventMesh 与 K8S 集成部署时遇到exec /bin/bash: exec format error (eventmesh)

2025-01-17 Thread via GitHub
github-actions[bot] commented on issue #5166: URL: https://github.com/apache/eventmesh/issues/5166#issuecomment-2599477829 Welcome to the Apache EventMesh community!! We are glad that you are contributing by opening this issue. :D Please make sure to include all the relevant context

Re: [PR] v4-write-process [tsfile]

2025-01-17 Thread via GitHub
761417898 commented on code in PR #345: URL: https://github.com/apache/tsfile/pull/345#discussion_r1920936742 ## cpp/src/common/tablet.h: ## @@ -85,17 +88,49 @@ class Tablet { return MeasurementSchema(name, type); }); } +

Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]

2025-01-17 Thread via GitHub
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1920936557 ## newsfragments/template.significant.rst: ## @@ -3,20 +3,29 @@ .. Provide additional contextual information .. Check the type of change that applies to this change

Re: [PR] [KVM] Exclude watchdogs for ARM64 VM deployments [cloudstack]

2025-01-17 Thread via GitHub
codecov[bot] commented on PR #10203: URL: https://github.com/apache/cloudstack/pull/10203#issuecomment-2599487789 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10203?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] KAFKA-18480: Fix fail e2e `test_offset_truncate` [kafka]

2025-01-17 Thread via GitHub
chia7712 merged PR #18492: URL: https://github.com/apache/kafka/pull/18492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]

2025-01-17 Thread via GitHub
mjsax commented on PR #18570: URL: https://github.com/apache/kafka/pull/18570#issuecomment-2599487481 Java 17 ``` Found 1 test failures: FAILED ❌ MetricsDuringTopicCreationDeletionTest > "testMetricsDuringTopicCreateDelete(String).quorum=kraft" Found 2 flaky test failures: FLA

Re: [I] [Feature] Add Full Iterator Pattern to BanyanDB's Query Pipeline [skywalking]

2025-01-17 Thread via GitHub
hanahmily closed issue #12913: [Feature] Add Full Iterator Pattern to BanyanDB's Query Pipeline URL: https://github.com/apache/skywalking/issues/12913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Introduce the batch scan to improve the performance of the query and limit the memory usage [skywalking-banyandb]

2025-01-17 Thread via GitHub
hanahmily merged PR #597: URL: https://github.com/apache/skywalking-banyandb/pull/597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

Re: [PR] MINOR: Removed unused local variable in method DefaultStateUpdater.drainRestoredActiveTasks [kafka]

2025-01-17 Thread via GitHub
mjsax commented on PR #18385: URL: https://github.com/apache/kafka/pull/18385#issuecomment-2599487181 @kumarlokesh -- build failed with a spotbug error. Can you take a look and fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [KVM] Exclude watchdogs for ARM64 VM deployments [cloudstack]

2025-01-17 Thread via GitHub
blueorangutan commented on PR #10203: URL: https://github.com/apache/cloudstack/pull/10203#issuecomment-2599486614 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

  1   2   3   4   5   6   7   8   9   10   >