wForget commented on code in PR #1295:
URL: https://github.com/apache/datafusion-comet/pull/1295#discussion_r1920937037
##########
native/spark-expr/src/hash_funcs/utils.rs:
##########
@@ -104,6 +104,26 @@ macro_rules! hash_array_primitive_float {
};
}
+#[macro_export]
+macro_rules! hash_array_small_decimal {
+ ($array_type:ident, $column: ident, $hashes: ident, $hash_method: ident)
=> {
+ let array = $column.as_any().downcast_ref::<$array_type>().unwrap();
+
+ if array.null_count() == 0 {
+ for (i, hash) in $hashes.iter_mut().enumerate() {
+ *hash =
$hash_method(i64::try_from(array.value(i)).unwrap().to_le_bytes(), *hash);
+ }
+ } else {
+ for (i, hash) in $hashes.iter_mut().enumerate() {
+ if !array.is_null(i) {
+ *hash =
+
$hash_method(i64::try_from(array.value(i)).unwrap().to_le_bytes(), *hash);
+ }
Review Comment:
It seems not, `$hashes` is filled with seed value by default, and the hash
function will return seed when input is empty. The test case has also covered
null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
