761417898 commented on code in PR #345:
URL: https://github.com/apache/tsfile/pull/345#discussion_r1920936742
##########
cpp/src/common/tablet.h:
##########
@@ -85,17 +88,49 @@ class Tablet {
return MeasurementSchema(name, type);
});
}
+
+ Tablet(const std::string &insert_target_name,
+ const std::vector<std::string> &column_names,
+ const std::vector<common::TSDataType> &data_types,
+ const std::vector<ColumnCategory> &column_categories,
+ int max_rows = DEFAULT_MAX_ROWS, bool has_column_categories = true)
+ : max_row_num_(max_rows),
+ cur_row_size_(0),
+ insert_target_name_(insert_target_name),
+ timestamps_(nullptr),
+ value_matrix_(nullptr),
+ bitmaps_(nullptr),
+ owned_schemas_(false) {
+ schema_vec_ = std::make_shared<std::vector<MeasurementSchema>>();
+ for (size_t i = 0; i < column_names.size(); i++) {
+ schema_vec_->emplace_back(
+ MeasurementSchema(column_names[i], data_types[i],
common::PLAIN,
+ common::UNCOMPRESSED));
Review Comment:
fixed
##########
cpp/src/common/tablet.h:
##########
@@ -109,12 +144,16 @@ class Tablet {
private:
int max_row_num_;
- std::string device_id_;
+ int cur_row_size_;
+ std::string insert_target_name_;
std::shared_ptr<std::vector<MeasurementSchema>> schema_vec_;
std::map<std::string, int> schema_map_;
int64_t *timestamps_;
void **value_matrix_;
common::BitMap *bitmaps_;
+ std::vector<ColumnCategory> column_categories_;
+ std::vector<int> id_column_indexes_;
+ bool owned_schemas_;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
