mjsax commented on code in PR #18570:
URL: https://github.com/apache/kafka/pull/18570#discussion_r1920952304
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskManagerTest.java:
##########
@@ -137,6 +137,8 @@ public void shouldBlockOnAwait() throws
InterruptedException {
assertFalse(awaitingRunnable.awaitDone.await(100,
TimeUnit.MILLISECONDS));
awaitingRunnable.shutdown();
+ awaitingThread.join();
+ assertFalse(awaitingThread.isAlive());
Review Comment:
Not sure if we need to add this check, as `join()` would block forever
anyway (so it seems we either timeout, or know it will return `true` and the
check is redundant).
Or as an alternative, keep this check, but add a max wait time to `join()`.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
