chia7712 commented on code in PR #18478:
URL: https://github.com/apache/kafka/pull/18478#discussion_r1920942202
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -376,7 +376,7 @@ RemoteStorageManager createRemoteStorageManager() {
private void configureRSM() {
final Map<String, Object> rsmProps = new
HashMap<>(rlmConfig.remoteStorageManagerProps());
- rsmProps.put(ServerConfigs.BROKER_ID_CONFIG, brokerId);
+ rsmProps.put(KRaftConfigs.NODE_ID_CONFIG, brokerId);
Review Comment:
remote storage is using `broker.id` rather than `node.id`. see
https://github.com/apache/kafka/blob/78e35457ee966695bd392aa4e4c16cbfe919ad4f/storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java#L238
maybe we should align the naming for this internal config. @showuon FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
