chia7712 commented on code in PR #18381:
URL: https://github.com/apache/kafka/pull/18381#discussion_r1920937538
##########
test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestExtensionsTest.java:
##########
@@ -347,6 +350,30 @@ public void testControllerListenerName(ClusterInstance
cluster) throws Execution
}
}
+ @ClusterTest(types = {Type.KRAFT}, brokers = 1)
Review Comment:
Should we test `CO_KRAFT` as well?
##########
test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestExtensionsTest.java:
##########
@@ -347,6 +350,30 @@ public void testControllerListenerName(ClusterInstance
cluster) throws Execution
}
}
+ @ClusterTest(types = {Type.KRAFT}, brokers = 1)
+ public void testBrokerRestart(ClusterInstance cluster) throws
ExecutionException, InterruptedException {
+ final String topicName = "topic";
+ Properties producerProps = new Properties();
+ producerProps.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ producerProps.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+
+ try (Admin admin = cluster.admin();
+ Producer<String, String> producer =
cluster.producer(Utils.propsToMap(producerProps))) {
Review Comment:
Could you please use `Map.of` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
