chia7712 commented on code in PR #18602:
URL: https://github.com/apache/kafka/pull/18602#discussion_r1920938027
##########
build.gradle:
##########
@@ -1364,6 +1365,9 @@ project(':metadata') {
testImplementation project(':raft').sourceSets.test.output
testImplementation project(':server-common').sourceSets.test.output
+ testImplementation project(':test-common:test-common-api')
+ testRuntimeOnly project(':test-common:test-common-runtime')
Review Comment:
why only `metadata` module declares `test-common:test-common-runtime` as
`testRuntimeOnly`?
##########
core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala:
##########
@@ -19,13 +19,15 @@ package kafka.server
import kafka.api.{KafkaSasl, SaslSetup}
import kafka.security.JaasTestUtils
import kafka.server.SaslApiVersionsRequestTest.{kafkaClientSaslMechanism,
kafkaServerSaslMechanisms}
-import org.apache.kafka.common.test.api.{ClusterTemplate, Type,
ClusterTestExtensions, ClusterConfig, ClusterInstance}
+import org.apache.kafka.common.test.api.{ClusterConfig, ClusterTemplate, Type}
import org.apache.kafka.common.config.SaslConfigs
import org.apache.kafka.common.config.internals.BrokerSecurityConfigs
import org.apache.kafka.common.message.SaslHandshakeRequestData
import org.apache.kafka.common.protocol.{ApiKeys, Errors}
import org.apache.kafka.common.requests.{ApiVersionsRequest,
ApiVersionsResponse, SaslHandshakeRequest, SaslHandshakeResponse}
import org.apache.kafka.common.security.auth.SecurityProtocol
+import org.apache.kafka.common.test.ClusterInstance
+import org.apache.kafka.common.test.junit.ClusterTestExtensions
Review Comment:
Should we remove `@ExtendWith(value =
Array(classOf[ClusterTestExtensions]))` from this class?
##########
test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/README.md:
##########
@@ -79,7 +79,7 @@ a JUnit extension called `ClusterTestExtensions` which knows
how to process thes
invocations. Test classes that wish to make use of these annotations need to
explicitly register this extension:
```scala
-import org.apache.kafka.common.test.api.ClusterTestExtensions
+import org.apache.kafka.common.test.junit.ClusterTestExtensions
@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
Review Comment:
we don't need it, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
