Re: svn commit: r195181 - in head/sys: nfsclient nfsserver
On 30 Jun 2009, at 06:17, bz0...@zabbadoz.net wrote: On Tue, 30 Jun 2009, John Baldwin wrote: Author: jhb Date: Tue Jun 30 03:18:51 2009 New Revision: 195181 URL: http://svn.freebsd.org/changeset/base/195181 Log: Fix build with NFS_LEGACYRPC enabled after the socket upcall locking changes. is this really a good idea, considering that NFS_LEGACYRPC is on the "removal list" for 8.0? Will it go or will it stay? I thought it was already (partly) gone? Its up to re@ - I just sent them the patch. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195184 - stable/7/tools/tools/nanobsd
Author: n_hibma Date: Tue Jun 30 09:20:43 2009 New Revision: 195184 URL: http://svn.freebsd.org/changeset/base/195184 Log: MFC all changes up to 194958: 194288: Fix NanoBSD when the data partition size is defined as a negative number. 194431: Allow building world into a separate dir (for reuse in multiple images). 194437: Reverse some stuff I accidentally committed in the previous commit. 194440: Cleanups. 194958: Make pprint print through fd 3 so pprint can be used in customise functions. Prefix each log line with the running time. Modified: stable/7/tools/tools/nanobsd/nanobsd.sh (contents, props changed) Modified: stable/7/tools/tools/nanobsd/nanobsd.sh == --- stable/7/tools/tools/nanobsd/nanobsd.sh Tue Jun 30 09:14:09 2009 (r195183) +++ stable/7/tools/tools/nanobsd/nanobsd.sh Tue Jun 30 09:20:43 2009 (r195184) @@ -51,7 +51,6 @@ NANO_PACKAGE_LIST="*" # Object tree directory # default is subdir of /usr/obj -# XXX: MAKEOBJDIRPREFIX handling... ? #NANO_OBJ="" # The directory to put the final images @@ -147,21 +146,19 @@ NANO_ARCH=i386 clean_build ( ) ( pprint 2 "Clean and create object directory (${MAKEOBJDIRPREFIX})" - if rm -rf ${MAKEOBJDIRPREFIX} > /dev/null 2>&1 ; then - true - else + if ! rm -rf ${MAKEOBJDIRPREFIX} > /dev/null 2>&1 ; then chflags -R noschg ${MAKEOBJDIRPREFIX} - rm -rf ${MAKEOBJDIRPREFIX} + rm -r ${MAKEOBJDIRPREFIX} fi mkdir -p ${MAKEOBJDIRPREFIX} printenv > ${MAKEOBJDIRPREFIX}/_.env ) make_conf_build ( ) ( - pprint 2 "Construct build make.conf ($NANO_MAKE_CONF)" + pprint 2 "Construct build make.conf ($NANO_MAKE_CONF_BUILD)" - echo "${CONF_WORLD}" > ${NANO_MAKE_CONF} - echo "${CONF_BUILD}" >> ${NANO_MAKE_CONF} + echo "${CONF_WORLD}" > ${NANO_MAKE_CONF_BUILD} + echo "${CONF_BUILD}" >> ${NANO_MAKE_CONF_BUILD} ) build_world ( ) ( @@ -170,7 +167,7 @@ build_world ( ) ( cd ${NANO_SRC} env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} \ - __MAKE_CONF=${NANO_MAKE_CONF} buildworld \ + __MAKE_CONF=${NANO_MAKE_CONF_BUILD} buildworld \ > ${MAKEOBJDIRPREFIX}/_.bw 2>&1 ) @@ -188,62 +185,70 @@ build_kernel ( ) ( unset TARGET_CPUTYPE unset TARGET_BIG_ENDIAN env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \ - __MAKE_CONF=${NANO_MAKE_CONF} KERNCONF=`basename ${NANO_KERNEL}` \ + __MAKE_CONF=${NANO_MAKE_CONF_BUILD} KERNCONF=`basename ${NANO_KERNEL}` \ > ${MAKEOBJDIRPREFIX}/_.bk 2>&1 ) ) clean_world ( ) ( - pprint 2 "Clean and create world directory (${NANO_WORLDDIR})" - if rm -rf ${NANO_WORLDDIR}/ > /dev/null 2>&1 ; then - true + if [ "${NANO_OBJ}" != "${MAKEOBJDIRPREFIX}" ]; then + pprint 2 "Clean and create object directory (${NANO_OBJ})" + if ! rm -rf ${NANO_OBJ} > /dev/null 2>&1 ; then + chflags -R noschg ${NANO_OBJ} + rm -r ${NANO_OBJ} + fi + mkdir -p ${NANO_OBJ} ${NANO_WORLDDIR} + printenv > ${NANO_OBJ}/_.env else - chflags -R noschg ${NANO_WORLDDIR}/ - rm -rf ${NANO_WORLDDIR}/ + pprint 2 "Clean and create world directory (${NANO_WORLDDIR})" + if ! rm -rf ${NANO_WORLDDIR}/ > /dev/null 2>&1 ; then + chflags -R noschg ${NANO_WORLDDIR} + rm -rf ${NANO_WORLDDIR} + fi + mkdir -p ${NANO_WORLDDIR} fi - mkdir -p ${NANO_WORLDDIR}/ ) make_conf_install ( ) ( - pprint 2 "Construct install make.conf ($NANO_MAKE_CONF)" + pprint 2 "Construct install make.conf ($NANO_MAKE_CONF_INSTALL)" - echo "${CONF_WORLD}" > ${NANO_MAKE_CONF} - echo "${CONF_INSTALL}" >> ${NANO_MAKE_CONF} + echo "${CONF_WORLD}" > ${NANO_MAKE_CONF_INSTALL} + echo "${CONF_INSTALL}" >> ${NANO_MAKE_CONF_INSTALL} ) install_world ( ) ( pprint 2 "installworld" - pprint 3 "log: ${MAKEOBJDIRPREFIX}/_.iw" + pprint 3 "log: ${NANO_OBJ}/_.iw" cd ${NANO_SRC} env TARGET_ARCH=${NANO_ARCH} \ - ${NANO_PMAKE} __MAKE_CONF=${NANO_MAKE_CONF} installworld \ + ${NANO_PMAKE} __MAKE_CONF=${NANO_MAKE_CONF_INSTALL} installworld \ DESTDIR=${NANO_WORLDDIR} \ - > ${MAKEOBJDIRPREFIX}/_.iw 2>&1 + > ${NANO_OBJ}/_.iw 2>&1 chflags -R noschg ${NANO_WORLDDIR} ) install_etc ( ) ( pprint 2 "install /etc" - pprint 3 "log: ${MAKEOBJDIRPREFIX}/_.etc" + pprint 3 "log: ${NANO_OBJ}/_.etc" cd ${NANO_SRC} env TARGET_ARCH=${NANO_ARCH} \ - ${NANO_PMAKE} __MA
svn commit: r195185 - in head: share/man/man4 sys/dev/acpi_support
Author: rpaulo Date: Tue Jun 30 09:51:41 2009 New Revision: 195185 URL: http://svn.freebsd.org/changeset/base/195185 Log: acpi_wmi_if: - Document different semantics for ACPI_WMI_PROVIDES_GUID_STRING_METHOD acpi_wmi.c: - Modify acpi_wmi_provides_guid_string_method to return absolut number of instances known for the given GUID. acpi_hp.c: - sysctl dev.acpi_hp.0.verbose to toggle debug output - A modification so this can deal with different array lengths when reading the CMI BIOS - now it works ok on HP Compaq nx7300 as well. - Change behaviour to query only max_instance-1 CMI BIOS instances, because all HPs seen so far are broken in that respect (or there is a fundamental misunderstanding on my side, possible as well). This way a disturbing ACPI Error Field exceeds Buffer message is avoided. - New bit to set on dev.acpi_hp.0.cmi_detail (0x8) to also query the highest guid instance of CMI bios acpi_hp.4: - Document dev.acpi_hp.0.verbose sysctl in man page - Document new bit for dev.acpi_hp.0.cmi_detail - Add a section to manpage about hardware that has been reported to work ok Submitted by: Michael Gmelin, freebsdusb at bindone.de Approved by: re (kib) MFC after:2 weeks Modified: head/share/man/man4/acpi_hp.4 head/sys/dev/acpi_support/acpi_hp.c head/sys/dev/acpi_support/acpi_wmi.c head/sys/dev/acpi_support/acpi_wmi_if.m Modified: head/share/man/man4/acpi_hp.4 == --- head/share/man/man4/acpi_hp.4 Tue Jun 30 09:20:43 2009 (r195184) +++ head/share/man/man4/acpi_hp.4 Tue Jun 30 09:51:41 2009 (r195185) @@ -165,6 +165,9 @@ Show path component of BIOS setting Show a list of valid options for the BIOS setting .It Li 0x04 Show additional flags of BIOS setting (ReadOnly etc.) +.It Li 0x08 +Query highest BIOS entry instance. This is broken on many HP models and +therefore disabled by default. .El .El .Pp Modified: head/sys/dev/acpi_support/acpi_hp.c == --- head/sys/dev/acpi_support/acpi_hp.c Tue Jun 30 09:20:43 2009 (r195184) +++ head/sys/dev/acpi_support/acpi_hp.c Tue Jun 30 09:51:41 2009 (r195185) @@ -106,6 +106,7 @@ ACPI_MODULE_NAME("HP") #define ACPI_HP_CMI_DETAIL_PATHS 0x01 #define ACPI_HP_CMI_DETAIL_ENUMS 0x02 #define ACPI_HP_CMI_DETAIL_FLAGS 0x04 +#define ACPI_HP_CMI_DETAIL_SHOW_MAX_INSTANCE 0x08 struct acpi_hp_inst_seq_pair { UINT32 sequence; /* sequence number as suggested by cmi bios */ @@ -489,9 +490,10 @@ acpi_hp_attach(device_t dev) sc->has_notify = 1; } } - if (ACPI_WMI_PROVIDES_GUID_STRING(sc->wmi_dev, ACPI_HP_WMI_CMI_GUID)) { + if ((sc->has_cmi = + ACPI_WMI_PROVIDES_GUID_STRING(sc->wmi_dev, ACPI_HP_WMI_CMI_GUID) + )) { device_printf(dev, "HP CMI GUID detected\n"); - sc->has_cmi = 1; } if (sc->has_cmi) { @@ -752,6 +754,10 @@ acpi_hp_sysctl_set(struct acpi_hp_softc arg?1:0)); case ACPI_HP_METHOD_CMI_DETAIL: sc->cmi_detail = arg; + if ((arg & ACPI_HP_CMI_DETAIL_SHOW_MAX_INSTANCE) != + (oldarg & ACPI_HP_CMI_DETAIL_SHOW_MAX_INSTANCE)) { + sc->cmi_order_size = -1; + } break; } } @@ -1103,6 +1109,7 @@ acpi_hp_hpcmi_read(struct cdev *dev, str struct acpi_hp_softc *sc; int pos, i, l, ret; UINT8 instance; + UINT8 maxInstance; UINT32 sequence; int linesize = 1025; char line[linesize]; @@ -1119,14 +1126,20 @@ acpi_hp_hpcmi_read(struct cdev *dev, str else { if (!sbuf_done(&sc->hpcmi_sbuf)) { if (sc->cmi_order_size < 0) { + maxInstance = sc->has_cmi; + if (!(sc->cmi_detail & + ACPI_HP_CMI_DETAIL_SHOW_MAX_INSTANCE) && + maxInstance > 0) { + maxInstance--; + } sc->cmi_order_size = 0; - for (instance = 0; instance < 128; + for (instance = 0; instance < maxInstance; ++instance) { if (acpi_hp_get_cmi_block(sc->wmi_dev, ACPI_HP_WMI_CMI_GUID, instance, line, linesize, &sequence, sc->cmi_detail)) { -
svn commit: r195186 - head/sys/ufs/ffs
Author: kib Date: Tue Jun 30 10:07:00 2009 New Revision: 195186 URL: http://svn.freebsd.org/changeset/base/195186 Log: Softdep_fsync() may need to lock parent directory of the synced vnode. Use inlined (due to FFSV_FORCEINSMQ) version of vn_vget_ino() to prevent mountpoint from being unmounted and freed while no vnodes are locked. Tested by:pho Approved by: re (kensmith) MFC after:1 month Modified: head/sys/ufs/ffs/ffs_softdep.c Modified: head/sys/ufs/ffs/ffs_softdep.c == --- head/sys/ufs/ffs/ffs_softdep.c Tue Jun 30 09:51:41 2009 (r195185) +++ head/sys/ufs/ffs/ffs_softdep.c Tue Jun 30 10:07:00 2009 (r195186) @@ -5102,10 +5102,28 @@ softdep_fsync(vp) FREE_LOCK(&lk); if (ffs_vgetf(mp, parentino, LK_NOWAIT | LK_EXCLUSIVE, &pvp, FFSV_FORCEINSMQ)) { + error = vfs_busy(mp, MBF_NOWAIT); + if (error != 0) { + VOP_UNLOCK(vp, 0); + error = vfs_busy(mp, 0); + vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); + if (error != 0) + return (ENOENT); + if (vp->v_iflag & VI_DOOMED) { + vfs_unbusy(mp); + return (ENOENT); + } + } VOP_UNLOCK(vp, 0); error = ffs_vgetf(mp, parentino, LK_EXCLUSIVE, &pvp, FFSV_FORCEINSMQ); + vfs_unbusy(mp); vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); + if (vp->v_iflag & VI_DOOMED) { + if (error == 0) + vput(pvp); + error = ENOENT; + } if (error != 0) return (error); } ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195187 - head/sys/ufs/ffs
Author: kib Date: Tue Jun 30 10:07:33 2009 New Revision: 195187 URL: http://svn.freebsd.org/changeset/base/195187 Log: For SU mounts, softdep_fsync() might drop vnode lock, allowing other threads to put dirty buffers on the vnode bufobj list. For regular files and synchronous fsync requests, check for the condition and restart the fsync vop if a new dirty buffer arrived. Tested by:pho Approved by: re (kensmith) MFC after:1 month Modified: head/sys/ufs/ffs/ffs_vnops.c Modified: head/sys/ufs/ffs/ffs_vnops.c == --- head/sys/ufs/ffs/ffs_vnops.cTue Jun 30 10:07:00 2009 (r195186) +++ head/sys/ufs/ffs/ffs_vnops.cTue Jun 30 10:07:33 2009 (r195187) @@ -180,15 +180,36 @@ struct vop_vector ffs_fifoops2 = { static int ffs_fsync(struct vop_fsync_args *ap) { + struct vnode *vp; + struct bufobj *bo; int error; - error = ffs_syncvnode(ap->a_vp, ap->a_waitfor); + vp = ap->a_vp; + bo = &vp->v_bufobj; +retry: + error = ffs_syncvnode(vp, ap->a_waitfor); if (error) return (error); if (ap->a_waitfor == MNT_WAIT && - (ap->a_vp->v_mount->mnt_flag & MNT_SOFTDEP)) -error = softdep_fsync(ap->a_vp); - return (error); + (vp->v_mount->mnt_flag & MNT_SOFTDEP)) { + error = softdep_fsync(vp); + if (error) + return (error); + + /* +* The softdep_fsync() function may drop vp lock, +* allowing for dirty buffers to reappear on the +* bo_dirty list. Recheck and resync as needed. +*/ + BO_LOCK(bo); + if (vp->v_type == VREG && (bo->bo_numoutput > 0 || + bo->bo_dirty.bv_cnt > 0)) { + BO_UNLOCK(bo); + goto retry; + } + BO_UNLOCK(bo); + } + return (0); } int ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195188 - head/sys/amd64/amd64
Author: avg Date: Tue Jun 30 11:16:32 2009 New Revision: 195188 URL: http://svn.freebsd.org/changeset/base/195188 Log: remove unused/unneeded extern declarations This should result in no changes to compiled code. Reviewed by: alc Approved by: re (kib) MFC after:1 day Modified: head/sys/amd64/amd64/identcpu.c Modified: head/sys/amd64/amd64/identcpu.c == --- head/sys/amd64/amd64/identcpu.c Tue Jun 30 10:07:33 2009 (r195187) +++ head/sys/amd64/amd64/identcpu.c Tue Jun 30 11:16:32 2009 (r195188) @@ -107,9 +107,6 @@ static struct { }; -extern int pq_l2size; -extern int pq_l2nways; - void printcpuinfo(void) { ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195189 - in head: share/man/man4 sys/dev/cpuctl sys/sys usr.sbin/cpucontrol
Author: stas Date: Tue Jun 30 12:35:47 2009 New Revision: 195189 URL: http://svn.freebsd.org/changeset/base/195189 Log: - Add support to atomically set/clear individual bits of a MSR register via cpuctl(4) driver. Two new CPUCTL_MSRSBIT and CPUCTL_MSRCBIT ioctl(2) calls treat the data field of the argument struct passed as a mask and set/clear bits of the MSR register according to the mask value. - Allow user to perform atomic bitwise AND and OR operaions on MSR registers via cpucontrol(8) utility. Two new operations ("&=" and "|=") have been added. The first one applies bitwise AND operaion between the current contents of the MSR register and the mask, and the second performs bitwise OR. The argument can be optionally prefixed with "~" inversion operator. This allows one to mimic the "clear bit" behavior by using the command like this: cpucontrol -m 0x10&=~0x02 # clear the second bit of TSC MSR Inversion operator support in all modes (assignment, OR, AND). Approved by: re (kib) MFC after:1 month Modified: head/share/man/man4/cpuctl.4 head/sys/dev/cpuctl/cpuctl.c head/sys/sys/cpuctl.h head/usr.sbin/cpucontrol/cpucontrol.8 head/usr.sbin/cpucontrol/cpucontrol.c Modified: head/share/man/man4/cpuctl.4 == --- head/share/man/man4/cpuctl.4Tue Jun 30 11:16:32 2009 (r195188) +++ head/share/man/man4/cpuctl.4Tue Jun 30 12:35:47 2009 (r195189) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd May 31, 2008 +.Dd June 30, 2009 .Dt CPUCTL 4 .Os .Sh NAME @@ -81,6 +81,11 @@ typedef struct { uint64_tdata; } cpuctl_msr_args_t; .Ed +.It Dv CPUCTL_MSRSBIT Fa cpuctl_msr_args_t *args +.It Dv CPUCTL_MSRCBIT Fa cpuctl_msr_args_t *args +Set/clear MSR bits according to the mask given in the +.Va data +field. .It Dv CPUCTL_CPUID Fa cpuctl_cpuid_args_t *args Retrieve CPUID information. Arguments are supplied in Modified: head/sys/dev/cpuctl/cpuctl.c == --- head/sys/dev/cpuctl/cpuctl.cTue Jun 30 11:16:32 2009 (r195188) +++ head/sys/dev/cpuctl/cpuctl.cTue Jun 30 12:35:47 2009 (r195189) @@ -158,6 +158,8 @@ cpuctl_ioctl(struct cdev *dev, u_long cm case CPUCTL_RDMSR: ret = cpuctl_do_msr(cpu, (cpuctl_msr_args_t *)data, cmd, td); break; + case CPUCTL_MSRSBIT: + case CPUCTL_MSRCBIT: case CPUCTL_WRMSR: ret = priv_check(td, PRIV_CPUCTL_WRMSR); if (ret != 0) @@ -211,6 +213,7 @@ cpuctl_do_cpuid(int cpu, cpuctl_cpuid_ar static int cpuctl_do_msr(int cpu, cpuctl_msr_args_t *data, u_long cmd, struct thread *td) { + uint64_t reg; int is_bound = 0; int oldcpu; int ret; @@ -230,9 +233,22 @@ cpuctl_do_msr(int cpu, cpuctl_msr_args_t if (cmd == CPUCTL_RDMSR) { data->data = 0; ret = rdmsr_safe(data->msr, &data->data); - } else { + } else if (cmd == CPUCTL_WRMSR) { ret = wrmsr_safe(data->msr, data->data); - } + } else if (cmd == CPUCTL_MSRSBIT) { + critical_enter(); + ret = rdmsr_safe(data->msr, ®); + if (ret == 0) + ret = wrmsr_safe(data->msr, reg | data->data); + critical_exit(); + } else if (cmd == CPUCTL_MSRCBIT) { + critical_enter(); + ret = rdmsr_safe(data->msr, ®); + if (ret == 0) + ret = wrmsr_safe(data->msr, reg & ~data->data); + critical_exit(); + } else + panic("[cpuctl,%d]: unknown operation requested: %lu", __LINE__, cmd); restore_cpu(oldcpu, is_bound, td); return (ret); } Modified: head/sys/sys/cpuctl.h == --- head/sys/sys/cpuctl.h Tue Jun 30 11:16:32 2009(r195188) +++ head/sys/sys/cpuctl.h Tue Jun 30 12:35:47 2009(r195189) @@ -48,5 +48,7 @@ typedef struct { #defineCPUCTL_WRMSR_IOWR('c', 2, cpuctl_msr_args_t) #defineCPUCTL_CPUID_IOWR('c', 3, cpuctl_cpuid_args_t) #defineCPUCTL_UPDATE _IOWR('c', 4, cpuctl_update_args_t) +#defineCPUCTL_MSRSBIT _IOWR('c', 5, cpuctl_msr_args_t) +#defineCPUCTL_MSRCBIT _IOWR('c', 6, cpuctl_msr_args_t) #endif /* _CPUCTL_H_ */ Modified: head/usr.sbin/cpucontrol/cpucontrol.8 == --- head/usr.sbin/cpucontrol/cpucontrol.8 Tue Jun 30 11:16:32 2009 (r195188) +++ head/usr.sbin/cpucontrol/cpucontrol.8 Tue Jun 30 12:35:47 2009 (r195189) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd August 4, 2008 +.Dd June 30, 2009 .Dt CPUCONTROL 8 .O
svn commit: r195191 - in head/sys: kern sys
Author: emaste Date: Tue Jun 30 13:38:49 2009 New Revision: 195191 URL: http://svn.freebsd.org/changeset/base/195191 Log: Add FIONSPACE from NetBSD. FIONSPACE is provided so that programs may easily determine how much space is left in the send queue; they do not need to know the send queue size. NetBSD revisions: sys_socket.c r1.41, 1.42 filio.h r1.9 Obtained from:NetBSD Approved by: re (kensmith) Modified: head/sys/kern/sys_socket.c head/sys/sys/filio.h Modified: head/sys/kern/sys_socket.c == --- head/sys/kern/sys_socket.c Tue Jun 30 13:38:14 2009(r195190) +++ head/sys/kern/sys_socket.c Tue Jun 30 13:38:49 2009(r195191) @@ -174,6 +174,14 @@ soo_ioctl(struct file *fp, u_long cmd, v *(int *)data = so->so_snd.sb_cc; break; + case FIONSPACE: + if ((so->so_snd.sb_hiwat < so->so_snd.sb_cc) || + (so->so_snd.sb_mbmax < so->so_snd.sb_mbcnt)) + *(int *)data = 0; + else + *(int *)data = sbspace(&so->so_snd); + break; + case FIOSETOWN: error = fsetown(*(int *)data, &so->so_sigio); break; Modified: head/sys/sys/filio.h == --- head/sys/sys/filio.hTue Jun 30 13:38:14 2009(r195190) +++ head/sys/sys/filio.hTue Jun 30 13:38:49 2009(r195191) @@ -56,6 +56,7 @@ struct fiodgname_arg { }; #defineFIODGNAME _IOW('f', 120, struct fiodgname_arg) /* get dev. name */ #defineFIONWRITE _IOR('f', 119, int) /* get # bytes (yet) to write */ +#defineFIONSPACE _IOR('f', 118, int) /* get space in send queue */ /* Handle lseek SEEK_DATA and SEEK_HOLE for holey file knowledge. */ #defineFIOSEEKDATA _IOWR('f', 97, off_t) /* SEEK_DATA */ #defineFIOSEEKHOLE _IOWR('f', 98, off_t) /* SEEK_HOLE */ ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195193 - in stable/7/sys: . amd64/amd64 arm/arm contrib/pf i386/i386 ia64/ia64 sparc64/sparc64
Author: avg Date: Tue Jun 30 14:11:43 2009 New Revision: 195193 URL: http://svn.freebsd.org/changeset/base/195193 Log: MFC 179229 (alc), 195188: The VM system no longer uses setPQL2(). Remove it and its helpers. Drop unused extern declarations in amd64 that seem to have been related. Reviewed by: alc Modified: stable/7/sys/ (props changed) stable/7/sys/amd64/amd64/identcpu.c stable/7/sys/arm/arm/identcpu.c stable/7/sys/contrib/pf/ (props changed) stable/7/sys/i386/i386/identcpu.c stable/7/sys/ia64/ia64/machdep.c stable/7/sys/sparc64/sparc64/identcpu.c Modified: stable/7/sys/amd64/amd64/identcpu.c == --- stable/7/sys/amd64/amd64/identcpu.c Tue Jun 30 13:53:54 2009 (r195192) +++ stable/7/sys/amd64/amd64/identcpu.c Tue Jun 30 14:11:43 2009 (r195193) @@ -71,8 +71,6 @@ void panicifcpuunsupported(void); static void print_AMD_info(void); static void print_AMD_assoc(int i); -void setPQL2(int *const size, int *const ways); -static void setPQL2_AMD(int *const size, int *const ways); intcpu_class; char machine[] = "amd64"; @@ -97,9 +95,6 @@ static struct { { "Sledgehammer", CPUCLASS_K8 }, /* CPU_SLEDGEHAMMER */ }; -extern int pq_l2size; -extern int pq_l2nways; - void printcpuinfo(void) { @@ -564,30 +559,3 @@ print_AMD_info(void) print_AMD_l2_assoc((regs[2] >> 12) & 0x0f); } } - -static void -setPQL2_AMD(int *const size, int *const ways) -{ - if (cpu_exthigh >= 0x8006) { - u_int regs[4]; - - do_cpuid(0x8006, regs); - *size = regs[2] >> 16; - *ways = (regs[2] >> 12) & 0x0f; - switch (*ways) { - case 0: /* disabled/not present */ - case 15:/* fully associative */ - default: *ways = 1; break; /* reserved configuration */ - case 4: *ways = 4; break; - case 6: *ways = 8; break; - case 8: *ways = 16; break; - } - } -} - -void -setPQL2(int *const size, int *const ways) -{ - if (strcmp(cpu_vendor, "AuthenticAMD") == 0) - setPQL2_AMD(size, ways); -} Modified: stable/7/sys/arm/arm/identcpu.c == --- stable/7/sys/arm/arm/identcpu.c Tue Jun 30 13:53:54 2009 (r195192) +++ stable/7/sys/arm/arm/identcpu.c Tue Jun 30 14:11:43 2009 (r195193) @@ -356,14 +356,6 @@ static const char * const wtnames[] = { "**unknown 15**", }; -void setPQL2(int *const size, int *const ways); - -void -setPQL2(int *const size, int *const ways) -{ - return; -} - extern int ctrl; void Modified: stable/7/sys/i386/i386/identcpu.c == --- stable/7/sys/i386/i386/identcpu.c Tue Jun 30 13:53:54 2009 (r195192) +++ stable/7/sys/i386/i386/identcpu.c Tue Jun 30 14:11:43 2009 (r195193) @@ -77,10 +77,6 @@ void panicifcpuunsupported(void); static void identifycyrix(void); static void init_exthigh(void); -void setPQL2(int *const size, int *const ways); -static void setPQL2_AMD(int *const size, int *const ways); -static void setPQL2_INTEL(int *const size, int *const ways); -static void get_INTEL_TLB(u_int data, int *const size, int *const ways); static void print_AMD_info(void); static void print_INTEL_info(void); static void print_INTEL_TLB(u_int data); @@ -1477,300 +1473,6 @@ print_INTEL_TLB(u_int data) } } - -static void -setPQL2_AMD(int *const size, int *const ways) -{ - if (cpu_exthigh >= 0x8006) { - u_int regs[4]; - - do_cpuid(0x8006, regs); - *size = regs[2] >> 16; - *ways = (regs[2] >> 12) & 0x0f; - } -} - - -static void -setPQL2_INTEL(int *const size, int *const ways) -{ - u_int rounds, regnum; - u_int regs[4]; - u_int nwaycode; - - if (cpu_high >= 2) { - rounds = 0; - do { - do_cpuid(0x2, regs); - if (rounds == 0 && (rounds = (regs[0] & 0xff)) == 0) - break; /* we have a buggy CPU */ - - for (regnum = 0; regnum <= 3; ++regnum) { - if (regs[regnum] & (1<<31)) - continue; - if (regnum != 0) - get_INTEL_TLB(regs[regnum] & 0xff, - size, ways); - get_INTEL_TLB((regs[regnum] >> 8) & 0xff, - size, ways); - get_INTEL_TLB((regs[regnum] >> 16) & 0xff, - size,
svn commit: r195195 - in head/sys/geom: . journal
Author: trasz Date: Tue Jun 30 14:34:06 2009 New Revision: 195195 URL: http://svn.freebsd.org/changeset/base/195195 Log: Make gjournal work with kernel compiled with "options DIAGNOSTIC". Previously, it would panic immediately. Reviewed by: pjd Approved by: re (kib) Modified: head/sys/geom/geom.h head/sys/geom/geom_io.c head/sys/geom/journal/g_journal.c Modified: head/sys/geom/geom.h == --- head/sys/geom/geom.hTue Jun 30 14:21:37 2009(r195194) +++ head/sys/geom/geom.hTue Jun 30 14:34:06 2009(r195195) @@ -134,6 +134,7 @@ struct g_geom { void*softc; unsignedflags; #defineG_GEOM_WITHER 1 +#defineG_GEOM_VOLATILE_BIO 2 }; /* Modified: head/sys/geom/geom_io.c == --- head/sys/geom/geom_io.c Tue Jun 30 14:21:37 2009(r195194) +++ head/sys/geom/geom_io.c Tue Jun 30 14:34:06 2009(r195195) @@ -480,14 +480,6 @@ g_io_deliver(struct bio *bp, int error) KASSERT(bp != NULL, ("NULL bp in g_io_deliver")); pp = bp->bio_to; KASSERT(pp != NULL, ("NULL bio_to in g_io_deliver")); -#ifdef DIAGNOSTIC - KASSERT(bp->bio_caller1 == bp->_bio_caller1, - ("bio_caller1 used by the provider %s", pp->name)); - KASSERT(bp->bio_caller2 == bp->_bio_caller2, - ("bio_caller2 used by the provider %s", pp->name)); - KASSERT(bp->bio_cflags == bp->_bio_cflags, - ("bio_cflags used by the provider %s", pp->name)); -#endif cp = bp->bio_from; if (cp == NULL) { bp->bio_error = error; @@ -496,6 +488,21 @@ g_io_deliver(struct bio *bp, int error) } KASSERT(cp != NULL, ("NULL bio_from in g_io_deliver")); KASSERT(cp->geom != NULL, ("NULL bio_from->geom in g_io_deliver")); +#ifdef DIAGNOSTIC + /* +* Some classes - GJournal in particular - can modify bio's +* private fields while the bio is in transit; G_GEOM_VOLATILE_BIO +* flag means it's an expected behaviour for that particular geom. +*/ + if ((cp->geom->flags & G_GEOM_VOLATILE_BIO) == 0) { + KASSERT(bp->bio_caller1 == bp->_bio_caller1, + ("bio_caller1 used by the provider %s", pp->name)); + KASSERT(bp->bio_caller2 == bp->_bio_caller2, + ("bio_caller2 used by the provider %s", pp->name)); + KASSERT(bp->bio_cflags == bp->_bio_cflags, + ("bio_cflags used by the provider %s", pp->name)); + } +#endif KASSERT(bp->bio_completed >= 0, ("bio_completed can't be less than 0")); KASSERT(bp->bio_completed <= bp->bio_length, ("bio_completed can't be greater than bio_length")); Modified: head/sys/geom/journal/g_journal.c == --- head/sys/geom/journal/g_journal.c Tue Jun 30 14:21:37 2009 (r195194) +++ head/sys/geom/journal/g_journal.c Tue Jun 30 14:34:06 2009 (r195195) @@ -2292,6 +2292,7 @@ g_journal_create(struct g_class *mp, str gp->orphan = g_journal_orphan; gp->access = g_journal_access; gp->softc = sc; + gp->flags |= G_GEOM_VOLATILE_BIO; sc->sc_geom = gp; mtx_init(&sc->sc_mtx, "gjournal", NULL, MTX_DEF); ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194628 - head/lib/ncurses/ncurses
Ed Schouten writes: > I've noticed the xterm entry we have in FreeBSD is somewhat > inconsistent with the one from other operating systems. [...] Is > this a known issue? I don't know about that one, but our xterm entry is intentionally broken in at least one area: it does not contain the sequences necessary to restore the previous screen when you exit from less, top etc. Be prepared for a flame war if you try to fix it; apparently, some people believe that their personal preferences are more important than correctness, not to mention everybody else's preferences. Is there a good reason for not using the (presumably correct and up-to-date) termcap file that ships with ncurses? DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events
Maxim Konovalov writes: > fixed, thanks. It still says static void usage() I know this is allowed by C99, but it's not allowed by style(9). DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194538 - head/sys/sys
Bruce Evans writes: > Freestanding reserves fewer symbols for the implementation. IIRC, freestanding implementations are only required to provide and , and everything else is available to the application. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195181 - in head/sys: nfsclient nfsserver
On Tue, Jun 30, 2009 at 05:17:48AM +, bz0...@zabbadoz.net wrote: > On Tue, 30 Jun 2009, John Baldwin wrote: > > >Author: jhb > >Date: Tue Jun 30 03:18:51 2009 > >New Revision: 195181 > >URL: http://svn.freebsd.org/changeset/base/195181 > > > >Log: > > Fix build with NFS_LEGACYRPC enabled after the socket upcall locking > > changes. > > is this really a good idea, considering that NFS_LEGACYRPC is on the > "removal list" for 8.0? Yes. 1) This option definitely worked on April 18th. 2) The option was broken by a commit that was never tested! If anything this should remind committers to either get a code review or test their patch. > > Will it go or will it stay? I thought it was already (partly) gone? > Well, as of June 1, this option was technically gone due to a ill-formed patch. -- Steve ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195181 - in head/sys: nfsclient nfsserver
In message: <20090630051641.t22...@maildrop.int.zabbadoz.net> bz0...@zabbadoz.net writes: : On Tue, 30 Jun 2009, John Baldwin wrote: : : > Author: jhb : > Date: Tue Jun 30 03:18:51 2009 : > New Revision: 195181 : > URL: http://svn.freebsd.org/changeset/base/195181 : > : > Log: : > Fix build with NFS_LEGACYRPC enabled after the socket upcall locking : > changes. : : is this really a good idea, considering that NFS_LEGACYRPC is on the : "removal list" for 8.0? : : Will it go or will it stay? I thought it was already (partly) gone? I thought it was still needed for a few embedded platforms... Warner ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194628 - head/lib/ncurses/ncurses
In message: <86prcl23k8@ds4.des.no> Dag-Erling_Smørgrav writes: : Ed Schouten writes: : > I've noticed the xterm entry we have in FreeBSD is somewhat : > inconsistent with the one from other operating systems. [...] Is : > this a known issue? : : I don't know about that one, but our xterm entry is intentionally broken : in at least one area: it does not contain the sequences necessary to : restore the previous screen when you exit from less, top etc. Be : prepared for a flame war if you try to fix it; apparently, some people : believe that their personal preferences are more important than : correctness, not to mention everybody else's preferences. I personally find that behavior to be horrible... But that's what makes it a flame war. Last time this BBQ came up, I thought it was agreed that there would be a xterm-XXX that didn't do this behavior for those folks that think the current behavior is harmfully wrong... : Is there a good reason for not using the (presumably correct and : up-to-date) termcap file that ships with ncurses? About 4-5 years ago I discovered that we had many entries that were more up to date than that file, but there has been an ncurses import since then... Warner ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194789 - head/usr.bin/usbhidctl
Bruce Evans writes: > Actually, it is OK to use it in FreeBSD iff the system supports the > same program having different names, like reboot/halt/etc. I don't see the point - you would still need different usage messages for each version. Using your example: % reboot -h reboot: illegal option -- h usage: reboot [-dlnpq] [-k kernel] % halt -h halt: illegal option -- h usage: halt [-lnpq] [-k kernel] The code that implements this is needlessly complicated: static void usage() { (void)fprintf(stderr, "usage: %s [-%slnpq] [-k kernel]\n", getprogname(), dohalt ? "" : "d"); exit(1); } The following is far more readable: static void usage(void) { (void)fprintf(stderr, dohalt ? "usage: halt [-lnpq] [-k kernel]\n" : "usage: reboot [-dlnpq] [-k kernel]\n"); exit(1); } BTW, there are numerous style issues in sbin/reboot/reboot.c. > This was discussed in FreeBSD mailing lists years ago, and IIRC no one > disagreed with the existing practice of hard-coding the program name. ISTR it was one of my commits that triggered the discussion. It must have been ten years ago, or close to it. Blink of an eye ;) I just realized that we have at least one committer who wasn't born when the FreeBSD project was founded... DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195026 - head/etc/rc.d
Robert Watson writes: > This sounds right to me, FWIW -- being able to fully configure the > policy before network traffic starts is definitely right in the > abstract, it's just a question of getting there... One option would be to start pf with a pre-cooked rule set that allows only DHCP and nd6 / rtsol or similar, then load the user-provided rule set once all interfaces are up. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195196 - stable/6/sys/netinet
Author: attilio Date: Tue Jun 30 15:23:16 2009 New Revision: 195196 URL: http://svn.freebsd.org/changeset/base/195196 Log: If the table is empty we can end up with a NULL pointer. Handle that case trying to free and re-allocate a new object for the timerqueue, managing unallocations. This is not an issue on 7 and further branches. Submitted by: emaste Sponsored by: Sandvine Incorporated Reported by: Kyle Larose Modified: stable/6/sys/netinet/tcp_syncache.c Modified: stable/6/sys/netinet/tcp_syncache.c == --- stable/6/sys/netinet/tcp_syncache.c Tue Jun 30 14:34:06 2009 (r195195) +++ stable/6/sys/netinet/tcp_syncache.c Tue Jun 30 15:23:16 2009 (r195196) @@ -891,13 +891,15 @@ syncache_add(inc, to, th, sop, m) /* NB: guarded by INP_INFO_WLOCK(&tcbinfo) */ for (i = SYNCACHE_MAXREXMTS; i >= 0; i--) { sc = TAILQ_FIRST(&tcp_syncache.timerq[i]); - if (sc != NULL) + if (sc != NULL) { + sc->sc_tp->ts_recent = ticks; + syncache_drop(sc, NULL); + tcpstat.tcps_sc_zonefail++; + sc = uma_zalloc(tcp_syncache.zone, M_NOWAIT | + M_ZERO); break; + } } - sc->sc_tp->ts_recent = ticks; - syncache_drop(sc, NULL); - tcpstat.tcps_sc_zonefail++; - sc = uma_zalloc(tcp_syncache.zone, M_NOWAIT | M_ZERO); if (sc == NULL) { if (ipopts) (void) m_free(ipopts); ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195181 - in head/sys: nfsclient nfsserver
M. Warner Losh wrote: In message: <20090630051641.t22...@maildrop.int.zabbadoz.net> bz0...@zabbadoz.net writes: : On Tue, 30 Jun 2009, John Baldwin wrote: : : > Author: jhb : > Date: Tue Jun 30 03:18:51 2009 : > New Revision: 195181 : > URL: http://svn.freebsd.org/changeset/base/195181 : > : > Log: : > Fix build with NFS_LEGACYRPC enabled after the socket upcall locking : > changes. : : is this really a good idea, considering that NFS_LEGACYRPC is on the : "removal list" for 8.0? : : Will it go or will it stay? I thought it was already (partly) gone? I thought it was still needed for a few embedded platforms... Misaligned access problems that hit arm and mips appear to be fixed. Sam ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194628 - head/lib/ncurses/ncurses
On Tue, 30 Jun 2009, M. Warner Losh wrote: Last time this BBQ came up, I thought it was agreed that there would be a xterm-XXX that didn't do this behavior for those folks that think the current behavior is harmfully wrong... Whereas I think it's a bug in more(1)/less(1) that it tries to use those sequences... Robert N M Watson Computer Laboratory University of Cambridge ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194628 - head/lib/ncurses/ncurses
In message: Robert Watson writes: : On Tue, 30 Jun 2009, M. Warner Losh wrote: : : > Last time this BBQ came up, I thought it was agreed that there would be a : > xterm-XXX that didn't do this behavior for those folks that think the : > current behavior is harmfully wrong... : : Whereas I think it's a bug in more(1)/less(1) that it tries to use those : sequences... Agreed. vi too. I'll note that on Mac OS, in the xterm, you don't see this with either... But I don't know how to undo tic(1) formatting to get back to the raw xterm entries... Warner ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195026 - head/etc/rc.d
On 2009-06-30 17:07, Dag-Erling Smørgrav wrote: > One option would be to start pf with a pre-cooked rule set that allows > only DHCP and nd6 / rtsol or similar, then load the user-provided rule > set once all interfaces are up. Please see also the suggestion here: http://docs.freebsd.org/cgi/mid.cgi?4A44B7DE.2090503 ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195197 - in stable/7/sys: . amd64/amd64 amd64/include contrib/pf dev/coretemp dev/hwpmc i386/cpufreq i386/i386 i386/include
Author: avg Date: Tue Jun 30 17:10:08 2009 New Revision: 195197 URL: http://svn.freebsd.org/changeset/base/195197 Log: MFC 185295, 185341, 185343: cpu identification improvements Goal of this MFC is to minimize unnecessary code differences between head and the branch, and to improve/fix invariant TSC detection for a wide range of CPUs. 185295 by takawata: Honor AMDPM_TSC_INVARIANT for Intel CPUs (i386 only) 185341 by jkim: Introduce cpu_vendor_id... 185343 by jkim: Use newly introduced cpu_vendor_id... These revision are bundled together because all intermediate revisions have one or more of the following deficiencies: o AMDPM_TSC_INVARIANT bit (CPUID.0x8007.EDX[8]) is not honored for Intel CPUs; o AMD-specific CPU model/revision checks are performed on Intel CPUs. Nod from: jkim Modified: stable/7/sys/ (props changed) stable/7/sys/amd64/amd64/amd64_mem.c stable/7/sys/amd64/amd64/identcpu.c stable/7/sys/amd64/amd64/initcpu.c stable/7/sys/amd64/amd64/local_apic.c stable/7/sys/amd64/amd64/mp_machdep.c stable/7/sys/amd64/amd64/msi.c stable/7/sys/amd64/include/cputypes.h stable/7/sys/amd64/include/md_var.h stable/7/sys/amd64/include/specialreg.h stable/7/sys/contrib/pf/ (props changed) stable/7/sys/dev/coretemp/coretemp.c stable/7/sys/dev/hwpmc/hwpmc_intel.c stable/7/sys/dev/hwpmc/hwpmc_piv.c stable/7/sys/dev/hwpmc/hwpmc_ppro.c stable/7/sys/dev/hwpmc/hwpmc_x86.c stable/7/sys/i386/cpufreq/est.c stable/7/sys/i386/i386/i686_mem.c stable/7/sys/i386/i386/identcpu.c stable/7/sys/i386/i386/initcpu.c stable/7/sys/i386/i386/k6_mem.c stable/7/sys/i386/i386/local_apic.c stable/7/sys/i386/i386/longrun.c stable/7/sys/i386/i386/mp_machdep.c stable/7/sys/i386/i386/msi.c stable/7/sys/i386/include/cputypes.h stable/7/sys/i386/include/md_var.h stable/7/sys/i386/include/specialreg.h Modified: stable/7/sys/amd64/amd64/amd64_mem.c == --- stable/7/sys/amd64/amd64/amd64_mem.cTue Jun 30 15:23:16 2009 (r195196) +++ stable/7/sys/amd64/amd64/amd64_mem.cTue Jun 30 17:10:08 2009 (r195197) @@ -35,6 +35,7 @@ __FBSDID("$FreeBSD$"); #include #include +#include #include #include @@ -677,8 +678,8 @@ amd64_mem_drvinit(void *unused) return; if ((cpu_id & 0xf00) != 0x600 && (cpu_id & 0xf00) != 0xf00) return; - if ((strcmp(cpu_vendor, "GenuineIntel") != 0) && - (strcmp(cpu_vendor, "AuthenticAMD") != 0)) + if (cpu_vendor_id != CPU_VENDOR_INTEL && + cpu_vendor_id != CPU_VENDOR_AMD) return; mem_range_softc.mr_op = &amd64_mrops; } Modified: stable/7/sys/amd64/amd64/identcpu.c == --- stable/7/sys/amd64/amd64/identcpu.c Tue Jun 30 15:23:16 2009 (r195196) +++ stable/7/sys/amd64/amd64/identcpu.c Tue Jun 30 17:10:08 2009 (r195197) @@ -69,6 +69,7 @@ void identify_cpu(void); void earlysetcpuclass(void); void panicifcpuunsupported(void); +static u_int find_cpu_vendor_id(void); static void print_AMD_info(void); static void print_AMD_assoc(int i); @@ -95,6 +96,14 @@ static struct { { "Sledgehammer", CPUCLASS_K8 }, /* CPU_SLEDGEHAMMER */ }; +static struct { + char*vendor; + u_int vendor_id; +} cpu_vendors[] = { + { INTEL_VENDOR_ID, CPU_VENDOR_INTEL }, /* GenuineIntel */ + { AMD_VENDOR_ID,CPU_VENDOR_AMD }, /* AuthenticAMD */ +}; + void printcpuinfo(void) { @@ -115,10 +124,10 @@ printcpuinfo(void) } } - if (strcmp(cpu_vendor, "GenuineIntel") == 0) { + if (cpu_vendor_id == CPU_VENDOR_INTEL) { /* Please make up your mind folks! */ strcat(cpu_model, "EM64T"); - } else if (strcmp(cpu_vendor, "AuthenticAMD") == 0) { + } else if (cpu_vendor_id == CPU_VENDOR_AMD) { /* * Values taken from AMD Processor Recognition * http://www.amd.com/K6/k6docs/pdf/20734g.pdf @@ -158,13 +167,13 @@ printcpuinfo(void) printf("Unknown"); /* will panic below... */ } printf("-class CPU)\n"); - if(*cpu_vendor) - printf(" Origin = \"%s\"",cpu_vendor); - if(cpu_id) + if (*cpu_vendor) + printf(" Origin = \"%s\"", cpu_vendor); + if (cpu_id) printf(" Id = 0x%x", cpu_id); - if (strcmp(cpu_vendor, "GenuineIntel") == 0 || - strcmp(cpu_vendor, "AuthenticAMD") == 0) { + if (cpu_vendor_id == CPU_VENDOR_INTEL || + cpu_vendor_id == CPU_VENDOR_AMD) { printf(" Stepping = %u", cpu_id & 0xf); if (cpu_high > 0) { u_int cmp = 1, htt = 1; @@ -336,22 +345,28 @@ printcpuinfo(void)
svn commit: r195198 - in stable/7/sys: . amd64/amd64 contrib/pf
Author: avg Date: Tue Jun 30 17:19:11 2009 New Revision: 195198 URL: http://svn.freebsd.org/changeset/base/195198 Log: MFC 185460 (mav): improve invariant TSC detection for Intel CPUs Nod from: mav Modified: stable/7/sys/ (props changed) stable/7/sys/amd64/amd64/identcpu.c stable/7/sys/contrib/pf/ (props changed) Modified: stable/7/sys/amd64/amd64/identcpu.c == --- stable/7/sys/amd64/amd64/identcpu.c Tue Jun 30 17:10:08 2009 (r195197) +++ stable/7/sys/amd64/amd64/identcpu.c Tue Jun 30 17:19:11 2009 (r195198) @@ -361,7 +361,11 @@ printcpuinfo(void) tsc_is_invariant = 1; break; case CPU_VENDOR_INTEL: - if (amd_pminfo & AMDPM_TSC_INVARIANT) + if ((amd_pminfo & AMDPM_TSC_INVARIANT) || + (AMD64_CPU_FAMILY(cpu_id) == 0x6 && + AMD64_CPU_MODEL(cpu_id) >= 0xe) || + (AMD64_CPU_FAMILY(cpu_id) == 0xf && + AMD64_CPU_MODEL(cpu_id) >= 0x3)) tsc_is_invariant = 1; break; } ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195199 - in stable/7/sys: . amd64/amd64 contrib/pf
Author: avg Date: Tue Jun 30 17:27:53 2009 New Revision: 195199 URL: http://svn.freebsd.org/changeset/base/195199 Log: MFC 185561 (ganbold): Remove unused variable. Modified: stable/7/sys/ (props changed) stable/7/sys/amd64/amd64/intr_machdep.c stable/7/sys/contrib/pf/ (props changed) Modified: stable/7/sys/amd64/amd64/intr_machdep.c == --- stable/7/sys/amd64/amd64/intr_machdep.c Tue Jun 30 17:19:11 2009 (r195198) +++ stable/7/sys/amd64/amd64/intr_machdep.c Tue Jun 30 17:27:53 2009 (r195199) @@ -239,11 +239,8 @@ void intr_execute_handlers(struct intsrc *isrc, struct trapframe *frame) { struct intr_event *ie; - struct thread *td; int vector; - td = curthread; - /* * We count software interrupts when we process them. The * code here follows previous practice, but there's an ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195200 - in head/usr.sbin: . wake
Author: mbr Date: Tue Jun 30 18:51:22 2009 New Revision: 195200 URL: http://svn.freebsd.org/changeset/base/195200 Log: Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network Submitted by: Marc Balmer Reviewed by:rwatson Approved by: re Musr.sbin/Makefile Ausr.sbin/wake AM usr.sbin/wake/wake.c AM usr.sbin/wake/Makefile AM usr.sbin/wake/wake.8 Added: head/usr.sbin/wake/ head/usr.sbin/wake/Makefile (contents, props changed) head/usr.sbin/wake/wake.8 (contents, props changed) head/usr.sbin/wake/wake.c (contents, props changed) Modified: head/usr.sbin/Makefile Modified: head/usr.sbin/Makefile == --- head/usr.sbin/Makefile Tue Jun 30 17:27:53 2009(r195199) +++ head/usr.sbin/Makefile Tue Jun 30 18:51:22 2009(r195200) @@ -190,6 +190,7 @@ SUBDIR= ${_ac} \ ${_usbconfig} \ ${_vidcontrol} \ vipw \ + wake \ watch \ watchdogd \ ${_wlandebug} \ Added: head/usr.sbin/wake/Makefile == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009(r195200) @@ -0,0 +1,8 @@ +# $FreeBSD$ + +PROG= wake +MAN= wake.8 + +WARNS?= 2 + +.include Added: head/usr.sbin/wake/wake.8 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009(r195200) @@ -0,0 +1,61 @@ +.\" +.\" $FreeBSD$ +.\" +.\" Copyright (c) 2009 Marc Balmer +.\" +.\" Permission to use, copy, modify, and distribute this software for any +.\" purpose with or without fee is hereby granted, provided that the above +.\" copyright notice and this permission notice appear in all copies. +.\" +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +.\" ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +.\" +.Dd June 27 2009 +.Dt WAKE 8 +.Os +.Sh NAME +.Nm wake +.Nd send Wake on LAN frames to hosts on a local Ethernet network +.Sh SYNOPSIS +.Nm +.Ar interface +.Op Ar lladdr ... +.Sh DESCRIPTION +The +.Nm +program is used to send Wake on LAN (WoL) frames over a local +Ethernet network to one or more hosts using their link layer (hardware) +addresses. +WoL functionality is generally enabled in a machine's BIOS +and can be used to power on machines from a remote system without +having physical access to them. +.Pp +.Ar interface +is the network interface of the local machine. +.Ar lladdr +are the link layer addresses of the remote machines +and can be specified as the actual hardware address +(six hexadecimal numbers separated by colons) +or a hostname entry in +.Pa /etc/ethers . +Link layer addresses can be determined and set on +.Fx +machines using +.Xr ifconfig 8 . +.Sh FILES +.Bl -tag -width "/etc/ethers" -compact +.It /etc/ethers +Ethernet host name database. +.El +.Sh SEE ALSO +.Xr ethers 5 , +.Xr ifconfig 8 +.Sh AUTHORS +.Nm +was written by +.Ar Marc Balmer Aq m...@msys.ch . Added: head/usr.sbin/wake/wake.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.sbin/wake/wake.c Tue Jun 30 18:51:22 2009(r195200) @@ -0,0 +1,174 @@ +/* + * Copyright (C) 2006, 2007, 2008, 2009 Marc Balmer + * Copyright (C) 2000 Eugene M. Kim. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Author's name may not be used endorse or promote products derived + *from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, + * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY
svn commit: r195202 - in head/sys: conf i386/i386 modules/nfsclient modules/nfsserver nfs nfsclient nfsserver
Author: dfr Date: Tue Jun 30 19:03:27 2009 New Revision: 195202 URL: http://svn.freebsd.org/changeset/base/195202 Log: Remove the old kernel RPC implementation and the NFS_LEGACYRPC option. Approved by: re Deleted: head/sys/nfs/rpcv2.h head/sys/nfsclient/nfs_socket.c head/sys/nfsserver/nfs_srvcache.c head/sys/nfsserver/nfs_srvsock.c head/sys/nfsserver/nfs_syscalls.c Modified: head/sys/conf/files head/sys/conf/options head/sys/i386/i386/genassym.c head/sys/modules/nfsclient/Makefile head/sys/modules/nfsserver/Makefile head/sys/nfs/nfs_common.c head/sys/nfsclient/bootp_subr.c head/sys/nfsclient/krpc_subr.c head/sys/nfsclient/nfs.h head/sys/nfsclient/nfs_bio.c head/sys/nfsclient/nfs_diskless.c head/sys/nfsclient/nfs_krpc.c head/sys/nfsclient/nfs_lock.c head/sys/nfsclient/nfs_nfsiod.c head/sys/nfsclient/nfs_node.c head/sys/nfsclient/nfs_subs.c head/sys/nfsclient/nfs_vfsops.c head/sys/nfsclient/nfs_vnops.c head/sys/nfsclient/nfsm_subs.h head/sys/nfsclient/nfsmount.h head/sys/nfsserver/nfs.h head/sys/nfsserver/nfs_fha.c head/sys/nfsserver/nfs_serv.c head/sys/nfsserver/nfs_srvkrpc.c head/sys/nfsserver/nfs_srvsubs.c head/sys/nfsserver/nfsrvcache.h Modified: head/sys/conf/files == --- head/sys/conf/files Tue Jun 30 18:52:36 2009(r195201) +++ head/sys/conf/files Tue Jun 30 19:03:27 2009(r195202) @@ -2490,7 +2490,6 @@ nfsclient/krpc_subr.c optional bootp nf nfsclient/nfs_bio.coptional nfsclient nfsclient/nfs_diskless.c optional nfsclient nfs_root nfsclient/nfs_node.c optional nfsclient -nfsclient/nfs_socket.c optional nfsclient nfsclient/nfs_krpc.c optional nfsclient nfsclient/nfs_subs.c optional nfsclient nfsclient/nfs_nfsiod.c optional nfsclient @@ -2500,10 +2499,7 @@ nfsclient/nfs_lock.c optional nfsclient nfsserver/nfs_fha.coptional nfsserver nfsserver/nfs_serv.c optional nfsserver nfsserver/nfs_srvkrpc.coptional nfsserver -nfsserver/nfs_srvsock.coptional nfsserver -nfsserver/nfs_srvcache.c optional nfsserver nfsserver/nfs_srvsubs.coptional nfsserver -nfsserver/nfs_syscalls.c optional nfsserver nfs/nfs_nfssvc.c optional nfsserver | nfscl | nfsd nlm/nlm_advlock.c optional nfslockd nfsclient | nfsd nfsclient nlm/nlm_prot_clnt.coptional nfslockd | nfsd Modified: head/sys/conf/options == --- head/sys/conf/options Tue Jun 30 18:52:36 2009(r195201) +++ head/sys/conf/options Tue Jun 30 19:03:27 2009(r195202) @@ -228,11 +228,6 @@ KGSSAPI_DEBUG opt_kgssapi.h NFSCLIENT opt_nfs.h NFSSERVER opt_nfs.h -# Use this option to compile both NFS client and server using the -# legacy RPC implementation instead of the newer KRPC system (which -# supports modern features such as RPCSEC_GSS -NFS_LEGACYRPC opt_nfs.h - # Use these options to compile the experimental nfs client and/or # server that supports NFSv4 into a kernel. # NFSCL - client Modified: head/sys/i386/i386/genassym.c == --- head/sys/i386/i386/genassym.c Tue Jun 30 18:52:36 2009 (r195201) +++ head/sys/i386/i386/genassym.c Tue Jun 30 19:03:27 2009 (r195202) @@ -67,7 +67,6 @@ __FBSDID("$FreeBSD$"); #include #include #include -#include #include #include #ifdef DEV_APIC Modified: head/sys/modules/nfsclient/Makefile == --- head/sys/modules/nfsclient/Makefile Tue Jun 30 18:52:36 2009 (r195201) +++ head/sys/modules/nfsclient/Makefile Tue Jun 30 19:03:27 2009 (r195202) @@ -4,7 +4,7 @@ KMOD= nfsclient SRCS= vnode_if.h \ - nfs_bio.c nfs_lock.c nfs_node.c nfs_socket.c nfs_subs.c nfs_nfsiod.c \ + nfs_bio.c nfs_lock.c nfs_node.c nfs_subs.c nfs_nfsiod.c \ nfs_vfsops.c nfs_vnops.c nfs_common.c nfs_krpc.c \ opt_inet.h opt_nfs.h opt_bootp.h opt_nfsroot.h SRCS+= opt_inet6.h opt_kdtrace.h opt_kgssapi.h Modified: head/sys/modules/nfsserver/Makefile == --- head/sys/modules/nfsserver/Makefile Tue Jun 30 18:52:36 2009 (r195201) +++ head/sys/modules/nfsserver/Makefile Tue Jun 30 19:03:27 2009 (r195202) @@ -3,8 +3,8 @@ .PATH: ${.CURDIR}/../../nfsserver ${.CURDIR}/../../nfs KMOD= nfsserver SRCS= vnode_if.h \ - nfs_fha.c nfs_serv.c nfs_srvkrpc.c nfs_srvsock.c nfs_srvcache.c \ - nfs_srvsubs.c nfs_syscalls.c nfs_common.c \ + nfs_fha.c nfs_serv.c nfs_srvkrpc.c nfs_srvsubs.c nfs_common.c \ + opt_mac.h \ opt_kgssapi.h \ opt_
Re: svn commit: r195200 - in head/usr.sbin: . wake
Martin Blapp wrote: Author: mbr Date: Tue Jun 30 18:51:22 2009 New Revision: 195200 URL: http://svn.freebsd.org/changeset/base/195200 Log: Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network Submitted by: Marc Balmer Reviewed by:rwatson Approved by: re what's wrong with ports/net/wol? Sam ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195203 - head/sys/nfsclient
Author: dfr Date: Tue Jun 30 19:10:17 2009 New Revision: 195203 URL: http://svn.freebsd.org/changeset/base/195203 Log: Adjust the internal NFS KPI to avoid the last traces of NFS_LEGACYRPC. Approved by: re Modified: head/sys/nfsclient/nfs.h head/sys/nfsclient/nfs_bio.c head/sys/nfsclient/nfs_krpc.c head/sys/nfsclient/nfs_vfsops.c head/sys/nfsclient/nfs_vnops.c Modified: head/sys/nfsclient/nfs.h == --- head/sys/nfsclient/nfs.hTue Jun 30 19:03:27 2009(r195202) +++ head/sys/nfsclient/nfs.hTue Jun 30 19:10:17 2009(r195203) @@ -147,11 +147,6 @@ extern int nfsv3_procid[NFS_NPROCS]; (e) != ERESTART && (e) != EWOULDBLOCK && \ ((s) & PR_CONNREQUIRED) == 0) -/* - * This is only needed to keep things working while we support - * compiling for both RPC implementations. - */ -struct nfsreq; struct nfsmount; struct buf; @@ -262,7 +257,7 @@ int nfs_asyncio(struct nfsmount *, struc intnfs_doio(struct vnode *, struct buf *, struct ucred *, struct thread *); void nfs_doio_directwrite (struct buf *); intnfs_readlinkrpc(struct vnode *, struct uio *, struct ucred *); -intnfs_sigintr(struct nfsmount *, struct nfsreq *, struct thread *); +intnfs_sigintr(struct nfsmount *, struct thread *); intnfs_readdirplusrpc(struct vnode *, struct uio *, struct ucred *); intnfs_request(struct vnode *, struct mbuf *, int, struct thread *, struct ucred *, struct mbuf **, struct mbuf **, caddr_t *); @@ -274,7 +269,7 @@ voidnfs_nhuninit(void); intnfs_nmcancelreqs(struct nfsmount *); void nfs_timer(void*); -intnfs_connect(struct nfsmount *, struct nfsreq *); +intnfs_connect(struct nfsmount *); void nfs_disconnect(struct nfsmount *); void nfs_safedisconnect(struct nfsmount *); intnfs_getattrcache(struct vnode *, struct vattr *); Modified: head/sys/nfsclient/nfs_bio.c == --- head/sys/nfsclient/nfs_bio.cTue Jun 30 19:03:27 2009 (r195202) +++ head/sys/nfsclient/nfs_bio.cTue Jun 30 19:10:17 2009 (r195203) @@ -504,7 +504,7 @@ nfs_bioread(struct vnode *vp, struct uio if (incore(&vp->v_bufobj, rabn) == NULL) { rabp = nfs_getcacheblk(vp, rabn, biosize, td); if (!rabp) { - error = nfs_sigintr(nmp, NULL, td); + error = nfs_sigintr(nmp, td); return (error ? error : EINTR); } if ((rabp->b_flags & (B_CACHE|B_DELWRI)) == 0) { @@ -535,7 +535,7 @@ nfs_bioread(struct vnode *vp, struct uio bp = nfs_getcacheblk(vp, lbn, bcount, td); if (!bp) { - error = nfs_sigintr(nmp, NULL, td); + error = nfs_sigintr(nmp, td); return (error ? error : EINTR); } @@ -570,7 +570,7 @@ nfs_bioread(struct vnode *vp, struct uio nfsstats.biocache_readlinks++; bp = nfs_getcacheblk(vp, (daddr_t)0, NFS_MAXPATHLEN, td); if (!bp) { - error = nfs_sigintr(nmp, NULL, td); + error = nfs_sigintr(nmp, td); return (error ? error : EINTR); } if ((bp->b_flags & B_CACHE) == 0) { @@ -596,7 +596,7 @@ nfs_bioread(struct vnode *vp, struct uio on = uio->uio_offset & (NFS_DIRBLKSIZ - 1); bp = nfs_getcacheblk(vp, lbn, NFS_DIRBLKSIZ, td); if (!bp) { - error = nfs_sigintr(nmp, NULL, td); + error = nfs_sigintr(nmp, td); return (error ? error : EINTR); } if ((bp->b_flags & B_CACHE) == 0) { @@ -625,7 +625,7 @@ nfs_bioread(struct vnode *vp, struct uio return (0); bp = nfs_getcacheblk(vp, i, NFS_DIRBLKSIZ, td); if (!bp) { - error = nfs_sigintr(nmp, NULL, td); + error = nfs_sigintr(nmp, td); return (error ? error : EINTR); } if ((bp->b_flags & B_CACHE) == 0) { @@ -1080,7 +1080,7 @@ again: } if (!bp) { - error = nfs_sigintr(nmp, NULL, td); + error = nfs_sigintr(nmp, td); if (!error) error = EINTR; break; @@ -1257,7 +1257,7 @@ nfs_getcacheblk(struct vnode *vp, daddr_ bp = getblk(vp, bn, size, PCATCH, 0, 0); nfs_restore_sigmask(td, &oldset);
Re: svn commit: r195200 - in head/usr.sbin: . wake
wake really is too generic a name for this. Why didn't the wol port get committed anyway, it seems to be better than this... Warner In message: <200906301851.n5uipnjq089...@svn.freebsd.org> Martin Blapp writes: : Author: mbr : Date: Tue Jun 30 18:51:22 2009 : New Revision: 195200 : URL: http://svn.freebsd.org/changeset/base/195200 : : Log: : Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network : : Submitted by: Marc Balmer : Reviewed by:rwatson : Approved by:re : : Musr.sbin/Makefile : Ausr.sbin/wake : AM usr.sbin/wake/wake.c : AM usr.sbin/wake/Makefile : AM usr.sbin/wake/wake.8 : : Added: : head/usr.sbin/wake/ : head/usr.sbin/wake/Makefile (contents, props changed) : head/usr.sbin/wake/wake.8 (contents, props changed) : head/usr.sbin/wake/wake.c (contents, props changed) : Modified: : head/usr.sbin/Makefile : : Modified: head/usr.sbin/Makefile : == : --- head/usr.sbin/MakefileTue Jun 30 17:27:53 2009(r195199) : +++ head/usr.sbin/MakefileTue Jun 30 18:51:22 2009(r195200) : @@ -190,6 +190,7 @@ SUBDIR= ${_ac} \ : ${_usbconfig} \ : ${_vidcontrol} \ : vipw \ : + wake \ : watch \ : watchdogd \ : ${_wlandebug} \ : : Added: head/usr.sbin/wake/Makefile : == : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009 (r195200) : @@ -0,0 +1,8 @@ : +# $FreeBSD$ : + : +PROG=wake : +MAN= wake.8 : + : +WARNS?= 2 : + : +.include : : Added: head/usr.sbin/wake/wake.8 : == : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009(r195200) : @@ -0,0 +1,61 @@ : +.\" : +.\" $FreeBSD$ : +.\" : +.\" Copyright (c) 2009 Marc Balmer : +.\" : +.\" Permission to use, copy, modify, and distribute this software for any : +.\" purpose with or without fee is hereby granted, provided that the above : +.\" copyright notice and this permission notice appear in all copies. : +.\" : +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES : +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF : +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR : +.\" ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES : +.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN : +.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF : +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. : +.\" : +.Dd June 27 2009 : +.Dt WAKE 8 : +.Os : +.Sh NAME : +.Nm wake : +.Nd send Wake on LAN frames to hosts on a local Ethernet network : +.Sh SYNOPSIS : +.Nm : +.Ar interface : +.Op Ar lladdr ... : +.Sh DESCRIPTION : +The : +.Nm : +program is used to send Wake on LAN (WoL) frames over a local : +Ethernet network to one or more hosts using their link layer (hardware) : +addresses. : +WoL functionality is generally enabled in a machine's BIOS : +and can be used to power on machines from a remote system without : +having physical access to them. : +.Pp : +.Ar interface : +is the network interface of the local machine. : +.Ar lladdr : +are the link layer addresses of the remote machines : +and can be specified as the actual hardware address : +(six hexadecimal numbers separated by colons) : +or a hostname entry in : +.Pa /etc/ethers . : +Link layer addresses can be determined and set on : +.Fx : +machines using : +.Xr ifconfig 8 . : +.Sh FILES : +.Bl -tag -width "/etc/ethers" -compact : +.It /etc/ethers : +Ethernet host name database. : +.El : +.Sh SEE ALSO : +.Xr ethers 5 , : +.Xr ifconfig 8 : +.Sh AUTHORS : +.Nm : +was written by : +.Ar Marc Balmer Aq m...@msys.ch . : : Added: head/usr.sbin/wake/wake.c : == : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : +++ head/usr.sbin/wake/wake.c Tue Jun 30 18:51:22 2009(r195200) : @@ -0,0 +1,174 @@ : +/* : + * Copyright (C) 2006, 2007, 2008, 2009 Marc Balmer : + * Copyright (C) 2000 Eugene M. Kim. All rights reserved. : + * : + * Redistribution and use in source and binary forms, with or without : + * modification, are permitted provided that the following conditions : + * are met: : + * : + * 1. Redistributions of source code must retain the above copyright : + *notice, this list of conditions and the following disclaimer. : + * 2. Author's name may not be used endorse or promote products derived : + *from this software without specific prior written permission. : + * : + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR
svn commit: r195209 - head/sys/kern
Author: alc Date: Tue Jun 30 19:39:17 2009 New Revision: 195209 URL: http://svn.freebsd.org/changeset/base/195209 Log: Remove a stale comment. The very same revision (r85511) that introduced this comment also implemented the proposed change to the code. Approved by: re (kib) Modified: head/sys/kern/vfs_cluster.c Modified: head/sys/kern/vfs_cluster.c == --- head/sys/kern/vfs_cluster.c Tue Jun 30 19:39:15 2009(r195208) +++ head/sys/kern/vfs_cluster.c Tue Jun 30 19:39:17 2009(r195209) @@ -471,9 +471,6 @@ cluster_rbuild(vp, filesize, lbn, blkno, } VM_OBJECT_UNLOCK(tbp->b_bufobj->bo_object); /* -* XXX shouldn't this be += size for both, like in -* cluster_wbuild()? -* * Don't inherit tbp->b_bufsize as it may be larger due to * a non-page-aligned size. Instead just aggregate using * 'size'. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 21:36 schrieb M. Warner Losh: wake really is too generic a name for this. Why didn't the wol port get committed anyway, it seems to be better than this... wake is a short, mnemonic and imperative name that describes what the command does. It is exactly the same command as in NetBSD. - Marc Warner In message: <200906301851.n5uipnjq089...@svn.freebsd.org> Martin Blapp writes: : Author: mbr : Date: Tue Jun 30 18:51:22 2009 : New Revision: 195200 : URL: http://svn.freebsd.org/changeset/base/195200 : : Log: : Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network : : Submitted by: Marc Balmer : Reviewed by:rwatson : Approved by:re : : Musr.sbin/Makefile : Ausr.sbin/wake : AM usr.sbin/wake/wake.c : AM usr.sbin/wake/Makefile : AM usr.sbin/wake/wake.8 : : Added: : head/usr.sbin/wake/ : head/usr.sbin/wake/Makefile (contents, props changed) : head/usr.sbin/wake/wake.8 (contents, props changed) : head/usr.sbin/wake/wake.c (contents, props changed) : Modified: : head/usr.sbin/Makefile : : Modified: head/usr.sbin/Makefile : = = = = = = = = == : --- head/usr.sbin/MakefileTue Jun 30 17:27:53 2009(r195199) : +++ head/usr.sbin/MakefileTue Jun 30 18:51:22 2009(r195200) : @@ -190,6 +190,7 @@ SUBDIR= ${_ac} \ : ${_usbconfig} \ : ${_vidcontrol} \ : vipw \ : + wake \ : watch \ : watchdogd \ : ${_wlandebug} \ : : Added: head/usr.sbin/wake/Makefile : = = = = = = = = == : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009 (r195200) : @@ -0,0 +1,8 @@ : +# $FreeBSD$ : + : +PROG=wake : +MAN= wake.8 : + : +WARNS?= 2 : + : +.include : : Added: head/usr.sbin/wake/wake.8 : = = = = = = = = == : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009(r195200) : @@ -0,0 +1,61 @@ : +.\" : +.\" $FreeBSD$ : +.\" : +.\" Copyright (c) 2009 Marc Balmer : +.\" : +.\" Permission to use, copy, modify, and distribute this software for any : +.\" purpose with or without fee is hereby granted, provided that the above : +.\" copyright notice and this permission notice appear in all copies. : +.\" : +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES : +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF : +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR : +.\" ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES : +.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN : +.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF : +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. : +.\" : +.Dd June 27 2009 : +.Dt WAKE 8 : +.Os : +.Sh NAME : +.Nm wake : +.Nd send Wake on LAN frames to hosts on a local Ethernet network : +.Sh SYNOPSIS : +.Nm : +.Ar interface : +.Op Ar lladdr ... : +.Sh DESCRIPTION : +The : +.Nm : +program is used to send Wake on LAN (WoL) frames over a local : +Ethernet network to one or more hosts using their link layer (hardware) : +addresses. : +WoL functionality is generally enabled in a machine's BIOS : +and can be used to power on machines from a remote system without : +having physical access to them. : +.Pp : +.Ar interface : +is the network interface of the local machine. : +.Ar lladdr : +are the link layer addresses of the remote machines : +and can be specified as the actual hardware address : +(six hexadecimal numbers separated by colons) : +or a hostname entry in : +.Pa /etc/ethers . : +Link layer addresses can be determined and set on : +.Fx : +machines using : +.Xr ifconfig 8 . : +.Sh FILES : +.Bl -tag -width "/etc/ethers" -compact : +.It /etc/ethers : +Ethernet host name database. : +.El : +.Sh SEE ALSO : +.Xr ethers 5 , : +.Xr ifconfig 8 : +.Sh AUTHORS : +.Nm : +was written by : +.Ar Marc Balmer Aq m...@msys.ch . : : Added: head/usr.sbin/wake/wake.c : = = = = = = = = == : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : +++ head/usr.sbin/wake/wake.c Tue Jun 30 18:51:22 2009(r195200) : @@ -0,0 +1,174 @@ : +/* : + * Copyright (C) 2006, 2007, 2008, 2009 Marc Balmer : + * Copyright (C) 2000 Eugene M. Kim. All rights reserved. : + * : + * Redistribution and use in source and binary forms, with or without : + * modification, are permitted provided that the following conditions : + * are met: : + * : + * 1. Redistributions of source code must retain
Re: svn commit: r194628 - head/lib/ncurses/ncurses
On Tue, 30.06.2009 at 09:46:32 -0600, M. Warner Losh wrote: > In message: > Robert Watson writes: > : On Tue, 30 Jun 2009, M. Warner Losh wrote: > : > : > Last time this BBQ came up, I thought it was agreed that there would be a > : > xterm-XXX that didn't do this behavior for those folks that think the > : > current behavior is harmfully wrong... > : > : Whereas I think it's a bug in more(1)/less(1) that it tries to use those > : sequences... > > Agreed. vi too. I'll note that on Mac OS, in the xterm, you don't > see this with either... But I don't know how to undo tic(1) > formatting to get back to the raw xterm entries... For vim(1) you can use something like set t_ti= t_te= Btw, I do like the current behaviour, but if $PAGER can be coerced into not clearing screen after exit, I think more people could be persuaded. Cheers, Ulrich Spörlein -- http://www.dubistterrorist.de/ ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195202 - in head/sys: conf i386/i386 modules/nfsclient modules/nfsserver nfs nfsclient nfsserver
Hi Doug, * Doug Rabson wrote: > Log: > Remove the old kernel RPC implementation and the NFS_LEGACYRPC option. > > Approved by: re It seems /sys/amd64/amd64/genassym.c doesn't build anymore, because it includes . It seems removing the #include fixes the build. Yours, -- Ed Schouten WWW: http://80386.nl/ pgpumfSu52PAA.pgp Description: PGP signature
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 21:07 schrieb Sam Leffler: Martin Blapp wrote: Author: mbr Date: Tue Jun 30 18:51:22 2009 New Revision: 195200 URL: http://svn.freebsd.org/changeset/base/195200 Log: Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network Submitted by: Marc Balmer Reviewed by:rwatson Approved by: re what's wrong with ports/net/wol? wake(8) is smaller and it is actually something needed in base. in modern, ecological "green computing" environments we put the client machines, like our POS terminals to sleep at night. In the morning, a cronjob from the central server wakes up all machines using this command. more and more systems support it, so havin a wake command in base is just about right. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
In message: <0e6d4fb2-a485-40ed-a856-acc311a90...@msys.ch> Marc Balmer writes: : : Am 30.06.2009 um 21:36 schrieb M. Warner Losh: : : > wake really is too generic a name for this. Why didn't the wol port : > get committed anyway, it seems to be better than this... : : wake is a short, mnemonic and imperative name that describes what the : command does. It is exactly the same command as in NetBSD. And the discussions in the NetBSD src discussion mailing lists have resolved the issue with finality? Warner : > Warner : > : > : > In message: <200906301851.n5uipnjq089...@svn.freebsd.org> : >Martin Blapp writes: : > : Author: mbr : > : Date: Tue Jun 30 18:51:22 2009 : > : New Revision: 195200 : > : URL: http://svn.freebsd.org/changeset/base/195200 : > : : > : Log: : > : Add wake, a tool to send Wake on LAN frames to hosts on a local : > Ethernet network : > : : > : Submitted by: Marc Balmer : > : Reviewed by:rwatson : > : Approved by:re : > : : > : Musr.sbin/Makefile : > : Ausr.sbin/wake : > : AM usr.sbin/wake/wake.c : > : AM usr.sbin/wake/Makefile : > : AM usr.sbin/wake/wake.8 : > : : > : Added: : > : head/usr.sbin/wake/ : > : head/usr.sbin/wake/Makefile (contents, props changed) : > : head/usr.sbin/wake/wake.8 (contents, props changed) : > : head/usr.sbin/wake/wake.c (contents, props changed) : > : Modified: : > : head/usr.sbin/Makefile : > : : > : Modified: head/usr.sbin/Makefile : > : : > = : > = : > = : > = : > = : > = : > = : > = : > == : > : --- head/usr.sbin/MakefileTue Jun 30 17:27:53 2009 (r195199) : > : +++ head/usr.sbin/MakefileTue Jun 30 18:51:22 2009 (r195200) : > : @@ -190,6 +190,7 @@ SUBDIR= ${_ac} \ : > : ${_usbconfig} \ : > : ${_vidcontrol} \ : > : vipw \ : > : + wake \ : > : watch \ : > : watchdogd \ : > : ${_wlandebug} \ : > : : > : Added: head/usr.sbin/wake/Makefile : > : : > = : > = : > = : > = : > = : > = : > = : > = : > == : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009 (r195200) : > : @@ -0,0 +1,8 @@ : > : +# $FreeBSD$ : > : + : > : +PROG=wake : > : +MAN= wake.8 : > : + : > : +WARNS?= 2 : > : + : > : +.include : > : : > : Added: head/usr.sbin/wake/wake.8 : > : : > = : > = : > = : > = : > = : > = : > = : > = : > == : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009 (r195200) : > : @@ -0,0 +1,61 @@ : > : +.\" : > : +.\" $FreeBSD$ : > : +.\" : > : +.\" Copyright (c) 2009 Marc Balmer : > : +.\" : > : +.\" Permission to use, copy, modify, and distribute this software : > for any : > : +.\" purpose with or without fee is hereby granted, provided that : > the above : > : +.\" copyright notice and this permission notice appear in all : > copies. : > : +.\" : > : +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL : > WARRANTIES : > : +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES : > OF : > : +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE : > LIABLE FOR : > : +.\" ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR : > ANY DAMAGES : > : +.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, : > WHETHER IN AN : > : +.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, : > ARISING OUT OF : > : +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. : > : +.\" : > : +.Dd June 27 2009 : > : +.Dt WAKE 8 : > : +.Os : > : +.Sh NAME : > : +.Nm wake : > : +.Nd send Wake on LAN frames to hosts on a local Ethernet network : > : +.Sh SYNOPSIS : > : +.Nm : > : +.Ar interface : > : +.Op Ar lladdr ... : > : +.Sh DESCRIPTION : > : +The : > : +.Nm : > : +program is used to send Wake on LAN (WoL) frames over a local : > : +Ethernet network to one or more hosts using their link layer : > (hardware) : > : +addresses. : > : +WoL functionality is generally enabled in a machine's BIOS : > : +and can be used to power on machines from a remote system without : > : +having physical access to them. : > : +.Pp : > : +.Ar interface : > : +is the network interface of the local machine. : > : +.Ar lladdr : > : +are the link layer addresses of the remote machines : > : +and can be specified as the actual hardware address : > : +(six hexadecimal numbers separated by colons) : > : +or a hostname entry in : > : +.Pa /etc/ethers . : > : +Link layer addresses can be determined and set on : > : +.Fx : > : +machines using : > : +.Xr ifconfig 8 . : > : +.Sh FILES : > : +.Bl -tag -width "/etc/ethers" -compact : > : +.It /etc/ethers : > : +Ethernet ho
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Jun 30, 2009, at 08:51 PM, Martin Blapp wrote: +void +usage(void) +{ + (void)fprintf(stderr, "usage: wake interface lladdr\n"); + exit(0); +} [...] + for (n = 2; n < argc; n++) + if (wake(argv[1], argv[n])) + warnx("error sending Wake on LAN frame over %s to %s", + argv[1], argv[n]); + return 0; +} The usage() function doesn't mention the possibility of specifying multiple hosts (although it appears the manual page does mention it). Regards, Thomas ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 22:13 schrieb M. Warner Losh: In message: <0e6d4fb2-a485-40ed-a856-acc311a90...@msys.ch> Marc Balmer writes: : : Am 30.06.2009 um 21:36 schrieb M. Warner Losh: : : > wake really is too generic a name for this. Why didn't the wol port : > get committed anyway, it seems to be better than this... : : wake is a short, mnemonic and imperative name that describes what the : command does. It is exactly the same command as in NetBSD. And the discussions in the NetBSD src discussion mailing lists have resolved the issue with finality? well, yes. the name stays, as martin put it so correctly "the one who does the work chooses the name". And we use this name since 2006 on various OSs. And I think it is not a weak name, I can not think of any other sensible use of this command name, really. Warner : > Warner : > : > : > In message: <200906301851.n5uipnjq089...@svn.freebsd.org> : >Martin Blapp writes: : > : Author: mbr : > : Date: Tue Jun 30 18:51:22 2009 : > : New Revision: 195200 : > : URL: http://svn.freebsd.org/changeset/base/195200 : > : : > : Log: : > : Add wake, a tool to send Wake on LAN frames to hosts on a local : > Ethernet network : > : : > : Submitted by: Marc Balmer : > : Reviewed by:rwatson : > : Approved by: re : > : : > : Musr.sbin/Makefile : > : Ausr.sbin/wake : > : AM usr.sbin/wake/wake.c : > : AM usr.sbin/wake/Makefile : > : AM usr.sbin/wake/wake.8 : > : : > : Added: : > : head/usr.sbin/wake/ : > : head/usr.sbin/wake/Makefile (contents, props changed) : > : head/usr.sbin/wake/wake.8 (contents, props changed) : > : head/usr.sbin/wake/wake.c (contents, props changed) : > : Modified: : > : head/usr.sbin/Makefile : > : : > : Modified: head/usr.sbin/Makefile : > : : > = : > = : > = : > = : > = : > = : > = : > = : > == : > : --- head/usr.sbin/Makefile Tue Jun 30 17:27:53 2009(r195199) : > : +++ head/usr.sbin/Makefile Tue Jun 30 18:51:22 2009(r195200) : > : @@ -190,6 +190,7 @@ SUBDIR=${_ac} \ : > :${_usbconfig} \ : > :${_vidcontrol} \ : > :vipw \ : > : + wake \ : > :watch \ : > :watchdogd \ : > :${_wlandebug} \ : > : : > : Added: head/usr.sbin/wake/Makefile : > : : > = : > = : > = : > = : > = : > = : > = : > = : > == : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009 (r195200) : > : @@ -0,0 +1,8 @@ : > : +# $FreeBSD$ : > : + : > : +PROG= wake : > : +MAN= wake.8 : > : + : > : +WARNS?= 2 : > : + : > : +.include : > : : > : Added: head/usr.sbin/wake/wake.8 : > : : > = : > = : > = : > = : > = : > = : > = : > = : > == : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009(r195200) : > : @@ -0,0 +1,61 @@ : > : +.\" : > : +.\" $FreeBSD$ : > : +.\" : > : +.\" Copyright (c) 2009 Marc Balmer : > : +.\" : > : +.\" Permission to use, copy, modify, and distribute this software : > for any : > : +.\" purpose with or without fee is hereby granted, provided that : > the above : > : +.\" copyright notice and this permission notice appear in all : > copies. : > : +.\" : > : +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL : > WARRANTIES : > : +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES : > OF : > : +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE : > LIABLE FOR : > : +.\" ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR : > ANY DAMAGES : > : +.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, : > WHETHER IN AN : > : +.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, : > ARISING OUT OF : > : +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. : > : +.\" : > : +.Dd June 27 2009 : > : +.Dt WAKE 8 : > : +.Os : > : +.Sh NAME : > : +.Nm wake : > : +.Nd send Wake on LAN frames to hosts on a local Ethernet network : > : +.Sh SYNOPSIS : > : +.Nm : > : +.Ar interface : > : +.Op Ar lladdr ... : > : +.Sh DESCRIPTION : > : +The : > : +.Nm : > : +program is used to send Wake on LAN (WoL) frames over a local : > : +Ethernet network to one or more hosts using their link layer : > (hardware) : > : +addresses. : > : +WoL functionality is generally enabled in a machine's BIOS : > : +and can be used to power on machines from a remote system without : > : +having physical access to them. : > : +.Pp : > : +.Ar interface : > : +is the network interface of the local machine. : > : +.Ar lladdr : > : +are the link layer addresses of the remote machines : > : +and can be specified as the actual hardware address : > : +(six hexadecim
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 22:02 schrieb Thomas Backman: On Jun 30, 2009, at 08:51 PM, Martin Blapp wrote: +void +usage(void) +{ + (void)fprintf(stderr, "usage: wake interface lladdr\n"); + exit(0); +} [...] + for (n = 2; n < argc; n++) + if (wake(argv[1], argv[n])) + warnx("error sending Wake on LAN frame over %s to %s", + argv[1], argv[n]); + return 0; +} The usage() function doesn't mention the possibility of specifying multiple hosts (although it appears the manual page does mention it). yes, that is wrong. I will send mbr@ a diff shortly. Regards, Thomas ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195202 - in head/sys: conf i386/i386 modules/nfsclient modules/nfsserver nfs nfsclient nfsserver
2009/7/1 Ed Schouten : > Hi Doug, > > * Doug Rabson wrote: >> Log: >> Remove the old kernel RPC implementation and the NFS_LEGACYRPC option. >> >> Approved by: re > > It seems /sys/amd64/amd64/genassym.c doesn't build anymore, because it > includes . It seems removing the #include fixes the build. > Moreover, this file should go to ObsoleteFiles.inc. -- wbr, pluknet ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
In message: <7b9c309f-63e3-4cb8-9871-de2dee010...@msys.ch> Marc Balmer writes: : : Am 30.06.2009 um 22:13 schrieb M. Warner Losh: : : > In message: <0e6d4fb2-a485-40ed-a856-acc311a90...@msys.ch> : >Marc Balmer writes: : > : : > : Am 30.06.2009 um 21:36 schrieb M. Warner Losh: : > : : > : > wake really is too generic a name for this. Why didn't the wol : > port : > : > get committed anyway, it seems to be better than this... : > : : > : wake is a short, mnemonic and imperative name that describes what : > the : > : command does. It is exactly the same command as in NetBSD. : > : > And the discussions in the NetBSD src discussion mailing lists have : > resolved the issue with finality? : : well, yes. the name stays, as martin put it so correctly "the one : who does : the work chooses the name". And we use this name since 2006 on various : OSs. And I think it is not a weak name, I can not think of any other : sensible : use of this command name, really. wol is one character shorter and equally descriptive :) Warner : > Warner : > : > : > : > Warner : > : > : > : > : > : > In message: <200906301851.n5uipnjq089...@svn.freebsd.org> : > : >Martin Blapp writes: : > : > : Author: mbr : > : > : Date: Tue Jun 30 18:51:22 2009 : > : > : New Revision: 195200 : > : > : URL: http://svn.freebsd.org/changeset/base/195200 : > : > : : > : > : Log: : > : > : Add wake, a tool to send Wake on LAN frames to hosts on a : > local : > : > Ethernet network : > : > : : > : > : Submitted by: Marc Balmer : > : > : Reviewed by:rwatson : > : > : Approved by:re : > : > : : > : > : Musr.sbin/Makefile : > : > : Ausr.sbin/wake : > : > : AM usr.sbin/wake/wake.c : > : > : AM usr.sbin/wake/Makefile : > : > : AM usr.sbin/wake/wake.8 : > : > : : > : > : Added: : > : > : head/usr.sbin/wake/ : > : > : head/usr.sbin/wake/Makefile (contents, props changed) : > : > : head/usr.sbin/wake/wake.8 (contents, props changed) : > : > : head/usr.sbin/wake/wake.c (contents, props changed) : > : > : Modified: : > : > : head/usr.sbin/Makefile : > : > : : > : > : Modified: head/usr.sbin/Makefile : > : > : : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > : > == : > : > : --- head/usr.sbin/MakefileTue Jun 30 17:27:53 2009 (r195199) : > : > : +++ head/usr.sbin/MakefileTue Jun 30 18:51:22 2009 (r195200) : > : > : @@ -190,6 +190,7 @@ SUBDIR= ${_ac} \ : > : > : ${_usbconfig} \ : > : > : ${_vidcontrol} \ : > : > : vipw \ : > : > : + wake \ : > : > : watch \ : > : > : watchdogd \ : > : > : ${_wlandebug} \ : > : > : : > : > : Added: head/usr.sbin/wake/Makefile : > : > : : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > : > == : > : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : > : +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009 : > (r195200) : > : > : @@ -0,0 +1,8 @@ : > : > : +# $FreeBSD$ : > : > : + : > : > : +PROG=wake : > : > : +MAN= wake.8 : > : > : + : > : > : +WARNS?= 2 : > : > : + : > : > : +.include : > : > : : > : > : Added: head/usr.sbin/wake/wake.8 : > : > : : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > : > == : > : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : > : +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009 (r195200) : > : > : @@ -0,0 +1,61 @@ : > : > : +.\" : > : > : +.\" $FreeBSD$ : > : > : +.\" : > : > : +.\" Copyright (c) 2009 Marc Balmer : > : > : +.\" : > : > : +.\" Permission to use, copy, modify, and distribute this : > software : > : > for any : > : > : +.\" purpose with or without fee is hereby granted, provided : > that : > : > the above : > : > : +.\" copyright notice and this permission notice appear in all : > : > copies. : > : > : +.\" : > : > : +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS : > ALL : > : > WARRANTIES : > : > : +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED : > WARRANTIES : > : > OF : > : > : +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR : > BE : > : > LIABLE FOR : > : > : +.\" ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR : > : > ANY DAMAGES : > : > : +.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, : > : > WHETHER IN AN : > : > : +.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, : > : > ARISING OUT OF : > : > : +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS : > SOFTWARE. : > : > : +.\" : > : > : +.Dd June 27 2009 : > : > : +.Dt WAKE 8 : > : > : +.Os : > : > : +.Sh NAME : > : > : +.Nm wake : > : > : +.Nd
Re: svn commit: r194628 - head/lib/ncurses/ncurses
On Tuesday 30 June 2009 21:37:12 Ulrich Spörlein wrote: > On Tue, 30.06.2009 at 09:46:32 -0600, M. Warner Losh wrote: > > In message: > > > > Robert Watson writes: > > : On Tue, 30 Jun 2009, M. Warner Losh wrote: > > : > Last time this BBQ came up, I thought it was agreed that there > > : > would be a xterm-XXX that didn't do this behavior for those folks > > : > that think the current behavior is harmfully wrong... > > : > > : Whereas I think it's a bug in more(1)/less(1) that it tries to use > > : those sequences... > > > > Agreed. vi too. I'll note that on Mac OS, in the xterm, you don't > > see this with either... But I don't know how to undo tic(1) > > formatting to get back to the raw xterm entries... > > For vim(1) you can use something like set t_ti= t_te= > > Btw, I do like the current behaviour, but if $PAGER can be coerced into > not clearing screen after exit, I think more people could be persuaded. $ alias less='less -X' -X or --no-init Disables sending the termcap initialization and deinitialization strings to the terminal. This is sometimes desirable if the deinitialization string does something unnecessary, like clear- ing the screen. It's one of the first things I do when I get a linux shell account somewhere. -- /"\ Best regards, | mla...@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mla...@efnet / \ ASCII Ribbon Campaign | Against HTML Mail and News ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195211 - head/lib/libc/sys
Author: trasz Date: Tue Jun 30 20:53:56 2009 New Revision: 195211 URL: http://svn.freebsd.org/changeset/base/195211 Log: Make it clear where to look for for protocol-specific socket options. Reviewed by: rwatson Approved by: re (kib) Modified: head/lib/libc/sys/getsockopt.2 Modified: head/lib/libc/sys/getsockopt.2 == --- head/lib/libc/sys/getsockopt.2 Tue Jun 30 19:44:23 2009 (r195210) +++ head/lib/libc/sys/getsockopt.2 Tue Jun 30 20:53:56 2009 (r195211) @@ -139,6 +139,11 @@ argument, defined in .In sys/time.h . .Pp The following options are recognized at the socket level. +For protocol-specific options, see protocol manual pages, +e.g. +.Xr ip 4 +or +.Xr tcp 4 . Except as noted, each may be examined with .Fn getsockopt and set with @@ -499,6 +504,10 @@ on a non-listening socket was attempted. .Xr getprotoent 3 , .Xr mac 3 , .Xr sysctl 3 , +.Xr ip 4 , +.Xr ip6 4 , +.Xr sctp 4 , +.Xr tcp 4 , .Xr protocols 5 , .Xr sysctl 8 , .Xr accept_filter 9 , ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195212 - head/usr.sbin/pkg_install/lib
Author: brian Date: Tue Jun 30 20:53:57 2009 New Revision: 195212 URL: http://svn.freebsd.org/changeset/base/195212 Log: Don't imply that only FTP urls are supported when we can't fetch a package. Approved by: re (kib) MFC after:3 weeks Modified: head/usr.sbin/pkg_install/lib/url.c Modified: head/usr.sbin/pkg_install/lib/url.c == --- head/usr.sbin/pkg_install/lib/url.c Tue Jun 30 20:53:56 2009 (r195211) +++ head/usr.sbin/pkg_install/lib/url.c Tue Jun 30 20:53:57 2009 (r195212) @@ -106,7 +106,7 @@ fileGetURL(const char *base, const char fetchDebug = (Verbose > 0); if ((ftp = fetchGetURL(fname, Verbose ? "v" : NULL)) == NULL) { - printf("Error: FTP Unable to get %s: %s\n", + printf("Error: Unable to get %s: %s\n", fname, fetchLastErrString); return NULL; } ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r194628 - head/lib/ncurses/ncurses
In message: <200906302252.53894@love2party.net> Max Laier writes: : On Tuesday 30 June 2009 21:37:12 Ulrich Spörlein wrote: : > On Tue, 30.06.2009 at 09:46:32 -0600, M. Warner Losh wrote: : > > In message: : > > : > > Robert Watson writes: : > > : On Tue, 30 Jun 2009, M. Warner Losh wrote: : > > : > Last time this BBQ came up, I thought it was agreed that there : > > : > would be a xterm-XXX that didn't do this behavior for those folks : > > : > that think the current behavior is harmfully wrong... : > > : : > > : Whereas I think it's a bug in more(1)/less(1) that it tries to use : > > : those sequences... : > > : > > Agreed. vi too. I'll note that on Mac OS, in the xterm, you don't : > > see this with either... But I don't know how to undo tic(1) : > > formatting to get back to the raw xterm entries... : > : > For vim(1) you can use something like set t_ti= t_te= : > : > Btw, I do like the current behaviour, but if $PAGER can be coerced into : > not clearing screen after exit, I think more people could be persuaded. : : $ alias less='less -X' : :-X or --no-init : Disables sending the termcap initialization and deinitialization : strings to the terminal. This is sometimes desirable if the : deinitialization string does something unnecessary, like clear- : ing the screen. : : It's one of the first things I do when I get a linux shell account : somewhere. Looks like "setenv LESS -X" or "export LESS=-X" would do the same thing, no? And work for "more" too... Warner ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
Marc Balmer wrote: Am 30.06.2009 um 21:07 schrieb Sam Leffler: Martin Blapp wrote: Author: mbr Date: Tue Jun 30 18:51:22 2009 New Revision: 195200 URL: http://svn.freebsd.org/changeset/base/195200 Log: Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network Submitted by: Marc Balmer Reviewed by:rwatson Approved by:re what's wrong with ports/net/wol? wake(8) is smaller and it is actually something needed in base. in modern, ecological "green computing" environments we put the client machines, like our POS terminals to sleep at night. In the morning, a cronjob from the central server wakes up all machines using this command. more and more systems support it, so havin a wake command in base is just about right. The typical way things happen in freebsd is we promote tools from ports when they are deemed needed in the base system. In fact it's probably more important to have the tool in base remain compatible with what users have had in their tree (via ports). I have yet to hear a compelling argument for why wake was chosen over an existing tool that's been successfully used for a while. OTOH this isn't something that'll keep me up at night; it just seems like an ill-advised rush job that completely violates the intent of the 8.0 code freeze.. Sam ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
Marc Balmer wrote: Am 30.06.2009 um 21:36 schrieb M. Warner Losh: wake really is too generic a name for this. Why didn't the wol port get committed anyway, it seems to be better than this... wake is a short, mnemonic and imperative name that describes what the command does. It is exactly the same command as in NetBSD. And you're conveniently ignoring the "discussion" that took place after the netbsd drive-by. Sam ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 23:09 schrieb Sam Leffler: Marc Balmer wrote: Am 30.06.2009 um 21:07 schrieb Sam Leffler: Martin Blapp wrote: Author: mbr Date: Tue Jun 30 18:51:22 2009 New Revision: 195200 URL: http://svn.freebsd.org/changeset/base/195200 Log: Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network Submitted by: Marc Balmer Reviewed by:rwatson Approved by:re what's wrong with ports/net/wol? wake(8) is smaller and it is actually something needed in base. in modern, ecological "green computing" environments we put the client machines, like our POS terminals to sleep at night. In the morning, a cronjob from the central server wakes up all machines using this command. more and more systems support it, so havin a wake command in base is just about right. The typical way things happen in freebsd is we promote tools from ports when they are deemed needed in the base system. In fact it's probably more important to have the tool in base remain compatible with what users have had in their tree (via ports). I have yet to hear a compelling argument for why wake was chosen over an existing tool that's been successfully used for a while. OTOH this isn't something that'll keep me up at night; it just seems like an ill-advised rush job that completely violates the intent of the 8.0 code freeze.. a compelling argument could be that wake(8) is BSD licensed while wol found in ports/net/wol is GPL licensed and brings in a whole lot of a whole lot of a whole lot of a whole lot of a stuff with it, when actually, to send out Wake on LAN package, a small BSD licensed command like wake(8) is sufficient. it is much smaller an cleaner code. Sam ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
2009/6/30 Marc Balmer : > > Am 30.06.2009 um 21:36 schrieb M. Warner Losh: > >> wake really is too generic a name for this. Why didn't the wol port >> get committed anyway, it seems to be better than this... > > wake is a short, mnemonic and imperative name that describes what the > command does. It is exactly the same command as in NetBSD. "wake(8)" seems more complementary to "zzz(8)" :) +1 for the tool, -1 for the name. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, Jun 30, 2009 at 11:25:56PM +0200, Marc Balmer wrote: > > Am 30.06.2009 um 23:09 schrieb Sam Leffler: > > >Marc Balmer wrote: > >> > >>Am 30.06.2009 um 21:07 schrieb Sam Leffler: > >> > >>>Martin Blapp wrote: > Author: mbr > Date: Tue Jun 30 18:51:22 2009 > New Revision: 195200 > URL: http://svn.freebsd.org/changeset/base/195200 > > Log: > Add wake, a tool to send Wake on LAN frames to hosts on a local > Ethernet network > Submitted by: Marc Balmer > Reviewed by:rwatson > Approved by:re > > >>> > >>>what's wrong with ports/net/wol? > >>> > >> > >>wake(8) is smaller and it is actually something needed in base. in > >>modern, ecological "green computing" environments we put the client > >>machines, like our POS terminals to sleep at night. In the > >>morning, a cronjob from the central server wakes up all machines > >>using this command. more and more systems support it, so havin a > >>wake command in base is just about right. > >> > >> > >The typical way things happen in freebsd is we promote tools from > >ports when they are deemed needed in the base system. In fact it's > >probably more important to have the tool in base remain compatible > >with what users have had in their tree (via ports). > > > >I have yet to hear a compelling argument for why wake was chosen > >over an existing tool that's been successfully used for a while. > >OTOH this isn't something that'll keep me up at night; it just seems > >like an ill-advised rush job that completely violates the intent of > >the 8.0 code freeze.. > > a compelling argument could be that wake(8) is BSD licensed while wol > found in ports/net/wol is GPL licensed and brings in a whole lot of a > whole lot of a whole lot of a whole lot of a stuff with it, when > actually, to send out Wake on LAN package, a small BSD licensed > command like wake(8) is sufficient. it is much smaller an cleaner code. Then, add the wake program to ports. My opinion is that this better be kept in ports. pgpZp1eWDrfZh.pgp Description: PGP signature
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 23:29 schrieb Kostik Belousov: [...] a compelling argument could be that wake(8) is BSD licensed while wol found in ports/net/wol is GPL licensed and brings in a whole lot of a whole lot of a whole lot of a whole lot of a stuff with it, when actually, to send out Wake on LAN package, a small BSD licensed command like wake(8) is sufficient. it is much smaller an cleaner code. Then, add the wake program to ports. My opinion is that this better be kept in ports. I find it a rather basic operation to be able to wake up remote systems from a central place, so I think base is the right place for this. Wak-on-LAN as become part of our everydays IT infrastructure, as much as we support it in BIOSes and ifconfig's, we should also support waking up systems. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, Jun 30, 2009 at 11:34:36PM +0200, Marc Balmer wrote: > > Am 30.06.2009 um 23:29 schrieb Kostik Belousov: > >Then, add the wake program to ports. > >My opinion is that this better be kept in ports. > > I find it a rather basic operation to be able to wake up remote > systems from a central place, so I think base is the right place for > this. Wak-on-LAN as become part of our everydays IT infrastructure, > as much as we support it in BIOSes and ifconfig's, we should also > support waking up systems. There are infinite amount of things that are essential for some operations. Just looking around, I found dhcp server, http servers, scripting languages, X, vpns and so on. Hopefully, our base system will not grow to include that too. I actively oppose to the bloat of the base system, and I consider the tool to be unappropriate for it. Use ports. Please. pgpWEoQB0PLX3.pgp Description: PGP signature
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, 30 Jun 2009 18:51:23 + (UTC) Martin Blapp mentioned: > Author: mbr > Date: Tue Jun 30 18:51:22 2009 > New Revision: 195200 > URL: http://svn.freebsd.org/changeset/base/195200 > > Log: > Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet > network > Cool! I always wanted something like this in base. > + > +WARNS?= 2 > + > +.include > What is the reason to use WARNS=2 here? Does it compile with higher warning flags set? Could this warnings be fixed? > + p = (u_char *)&pkt; > + len = sizeof(pkt); > + bw = 0; > + while (len) { > + if ((bw = write(bpf, &pkt, sizeof(pkt))) == -1) > + return -1; > + len -= bw; > + p += bw; > + } > + return 0; > +} What the "p" pointer is used here for? I don't see any usage for it besides incrementing it in the loop. Am I missing something? Thanks! -- Stanislav Sedov ST4096-RIPE pgpDxK4jwOiP2.pgp Description: PGP signature
Re: svn commit: r195200 - in head/usr.sbin: . wake
Am 30.06.2009 um 23:43 schrieb Kostik Belousov: On Tue, Jun 30, 2009 at 11:34:36PM +0200, Marc Balmer wrote: Am 30.06.2009 um 23:29 schrieb Kostik Belousov: Then, add the wake program to ports. My opinion is that this better be kept in ports. I find it a rather basic operation to be able to wake up remote systems from a central place, so I think base is the right place for this. Wak-on-LAN as become part of our everydays IT infrastructure, as much as we support it in BIOSes and ifconfig's, we should also support waking up systems. There are infinite amount of things that are essential for some operations. Just looking around, I found dhcp server, http servers, scripting languages, X, vpns and so on. Hopefully, our base system will not grow to include that too. I actively oppose to the bloat of the base system, and I consider the tool to be unappropriate for it. Use ports. Please. I really don't consider a ~4K command bloat. For this kind of commands/stuff, base is the right place. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r195213 - head/usr.sbin/wake
Author: mbr Date: Tue Jun 30 22:09:47 2009 New Revision: 195213 URL: http://svn.freebsd.org/changeset/base/195213 Log: Compiles without higher warn level Mwake/Makefile Approved by: re (previous commit) Modified: head/usr.sbin/wake/Makefile Modified: head/usr.sbin/wake/Makefile == --- head/usr.sbin/wake/Makefile Tue Jun 30 20:53:57 2009(r195212) +++ head/usr.sbin/wake/Makefile Tue Jun 30 22:09:47 2009(r195213) @@ -3,6 +3,4 @@ PROG= wake MAN= wake.8 -WARNS?= 2 - .include ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
In message: <7b9c309f-63e3-4cb8-9871-de2dee010...@msys.ch> Marc Balmer writes: : : Am 30.06.2009 um 22:13 schrieb M. Warner Losh: : : > In message: <0e6d4fb2-a485-40ed-a856-acc311a90...@msys.ch> : >Marc Balmer writes: : > : : > : Am 30.06.2009 um 21:36 schrieb M. Warner Losh: : > : : > : > wake really is too generic a name for this. Why didn't the wol : > port : > : > get committed anyway, it seems to be better than this... : > : : > : wake is a short, mnemonic and imperative name that describes what : > the : > : command does. It is exactly the same command as in NetBSD. : > : > And the discussions in the NetBSD src discussion mailing lists have : > resolved the issue with finality? : : well, yes. the name stays, as martin put it so correctly "the one : who does : the work chooses the name". And we use this name since 2006 on various : OSs. And I think it is not a weak name, I can not think of any other : sensible : use of this command name, really. That's a crock. You're rushing things into FreeBSD before they have even been settled in NetBSD using NetBSD as a justification? I wouldn't call that playing well with others. Especially since there was no socialization of this issue within FreeBSD before the commit. I didn't see any discussion about this at all. You can't dictate to the community: you have to convince them through sound technical argument. One that you've not made. I hate to be blunt, but this leaves a bad taste in everybody's mouth, even if at the end of the day you get your way. Warner : > Warner : > : > : > : > Warner : > : > : > : > : > : > In message: <200906301851.n5uipnjq089...@svn.freebsd.org> : > : >Martin Blapp writes: : > : > : Author: mbr : > : > : Date: Tue Jun 30 18:51:22 2009 : > : > : New Revision: 195200 : > : > : URL: http://svn.freebsd.org/changeset/base/195200 : > : > : : > : > : Log: : > : > : Add wake, a tool to send Wake on LAN frames to hosts on a : > local : > : > Ethernet network : > : > : : > : > : Submitted by: Marc Balmer : > : > : Reviewed by:rwatson : > : > : Approved by:re : > : > : : > : > : Musr.sbin/Makefile : > : > : Ausr.sbin/wake : > : > : AM usr.sbin/wake/wake.c : > : > : AM usr.sbin/wake/Makefile : > : > : AM usr.sbin/wake/wake.8 : > : > : : > : > : Added: : > : > : head/usr.sbin/wake/ : > : > : head/usr.sbin/wake/Makefile (contents, props changed) : > : > : head/usr.sbin/wake/wake.8 (contents, props changed) : > : > : head/usr.sbin/wake/wake.c (contents, props changed) : > : > : Modified: : > : > : head/usr.sbin/Makefile : > : > : : > : > : Modified: head/usr.sbin/Makefile : > : > : : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > : > == : > : > : --- head/usr.sbin/MakefileTue Jun 30 17:27:53 2009 (r195199) : > : > : +++ head/usr.sbin/MakefileTue Jun 30 18:51:22 2009 (r195200) : > : > : @@ -190,6 +190,7 @@ SUBDIR= ${_ac} \ : > : > : ${_usbconfig} \ : > : > : ${_vidcontrol} \ : > : > : vipw \ : > : > : + wake \ : > : > : watch \ : > : > : watchdogd \ : > : > : ${_wlandebug} \ : > : > : : > : > : Added: head/usr.sbin/wake/Makefile : > : > : : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > : > == : > : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : > : +++ head/usr.sbin/wake/Makefile Tue Jun 30 18:51:22 2009 : > (r195200) : > : > : @@ -0,0 +1,8 @@ : > : > : +# $FreeBSD$ : > : > : + : > : > : +PROG=wake : > : > : +MAN= wake.8 : > : > : + : > : > : +WARNS?= 2 : > : > : + : > : > : +.include : > : > : : > : > : Added: head/usr.sbin/wake/wake.8 : > : > : : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > = : > : > : > == : > : > : --- /dev/null 00:00:00 1970 (empty, because file is newly added) : > : > : +++ head/usr.sbin/wake/wake.8 Tue Jun 30 18:51:22 2009 (r195200) : > : > : @@ -0,0 +1,61 @@ : > : > : +.\" : > : > : +.\" $FreeBSD$ : > : > : +.\" : > : > : +.\" Copyright (c) 2009 Marc Balmer : > : > : +.\" : > : > : +.\" Permission to use, copy, modify, and distribute this : > software : > : > for any : > : > : +.\" purpose with or without fee is hereby granted, provided : > that : > : > the above : > : > : +.\" copyright notice and this permission notice appear in all : > : > copies. : > : > : +.\" : > : > : +.\" THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS : > ALL : > : > WARRANTIES : > : > : +.\" WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED : > WARRANTIES : > : > OF : > : > : +.\" MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR : > BE : > : > LIABLE
Re: svn commit: r194628 - head/lib/ncurses/ncurses
2009/6/30 M. Warner Losh : > In message: <200906302252.53894@love2party.net> > Max Laier writes: > : $ alias less='less -X' > : > : -X or --no-init > : Disables sending the termcap initialization and deinitialization > : strings to the terminal. This is sometimes desirable if the > : deinitialization string does something unnecessary, like clear- > : ing the screen. > : > : It's one of the first things I do when I get a linux shell account > : somewhere. > > Looks like "setenv LESS -X" or "export LESS=-X" would do the same > thing, no? And work for "more" too... Would it be possible to set it by default in /etc/csh.login (or wherever is more appropriate) if the termcap change goes in? ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, Jun 30, 2009 at 06:51:23PM +, Martin Blapp wrote: > Author: mbr > Date: Tue Jun 30 18:51:22 2009 > New Revision: 195200 > URL: http://svn.freebsd.org/changeset/base/195200 > > Log: > Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet > network > > Submitted by: Marc Balmer > Reviewed by:rwatson > Approved by:re > Nice! I guess I can now remove installed net/wol ports which does not work as expected when system have multiple interfaces. And I didn't understand why it requires perl to build such a simple utility. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, 2009-06-30 at 16:40 -0600, M. Warner Losh wrote: > I hate to be blunt, but this leaves a bad taste in everybody's mouth, > even if at the end of the day you get your way. Translation: I did it again. I hate it when that happens... :-( Two things happened here that were a bit unfortunate, and Marc/Martin (most likely unintentionally) tripped over it. The first thing that left a bad taste in some peoples' mouth is this new thing got approved past the point I had said many times was to be the end of new things getting added. But people complained the warnings I had given were buried in messages that had too much other information in them instead of short and to-the-point messages. So deadlines for a few things got extended in short and to-the-point messages yesterday and this pending request fell into one of those categories. The second thing that left a bad taste in some peoples' mouth is that this apparently (strictly judging by the fallout discussions) didn't get as much peer review as some people would have liked. Normally some level of discussion happens on some public mailing lists (not private email among a few potentially interested parties). And even after that happens and the commit gets made there is some time for fallout discussions to happen. Depending on the results of those potentially lengthy discussions it might wind up being backed out. But because of the stage of the release cycle we're in me having approved this can be viewed as short-circuiting the normal public review because odds are it will wind up staying despite some peoples' opinions due to the stage of the release cycle we're in. That second thing is one of the things that I think we're stuck with as part of the release process, but I really need help from you folks on. It's very much like the rant I made about the commit requests. And like I said above I fell for this before, during the 7.0 release cycle. During that release cycle it resulted in a rant with the subject line "I'm not Head Dictator In Charge". People complain if we lock out *all* new additions, even ones as relatively simple as a new command, too early in the release cycle. So we *consider* allowing new stuff that truly shouldn't impact the stability of the pending release until right around now in the release cycle. But we need to be able to trust that if you send in a commit request for something new like this that you've already done the peer review type stuff. RE approval for something like this doesn't trump normal peer review. The alternative is to flat out lock out *all* new stuff no matter how seemingly simple it is earlier in the release cycle just to avoid the problem that maybe someone will try to sneak something through without sufficient peer review. Thanks... -- Ken Smith - From there to here, from here to | kensm...@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | signature.asc Description: This is a digitally signed message part
Re: svn commit: r195200 - in head/usr.sbin: . wake
At 2:09 PM -0700 6/30/09, Sam Leffler wrote: I have yet to hear a compelling argument for why wake was chosen over an existing tool that's been successfully used for a while. OTOH this isn't something that'll keep me up at night; it just seems like an ill-advised rush job that completely violates the intent of the 8.0 code freeze.. Sam I agree completely with what Sam is saying here. I don't see why this had to be done at the time it was done (WRT a code freeze), and without any discussion about adding it to FreeBSD. I also agree that it won't be keeping me up at night, because I'm about to go on vacation for 10-12 days here. But as Warner noted, "this leaves a bad taste in everybody's mouth, even if at the end of the day you get your way" -- Garance Alistair Drosehn = dros...@rpi.edu Senior Systems Programmer or g...@freebsd.org Rensselaer Polytechnic Institute; Troy, NY; USA ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, Jun 30, 2009 at 09:56:42PM -0400, Ken Smith wrote: > On Tue, 2009-06-30 at 16:40 -0600, M. Warner Losh wrote: > > I hate to be blunt, but this leaves a bad taste in everybody's mouth, > > even if at the end of the day you get your way. > > The second thing that left a bad taste in some peoples' mouth is that > this apparently (strictly judging by the fallout discussions) didn't get > as much peer review as some people would have liked. Normally some > level of discussion happens on some public mailing lists (not private > email among a few potentially interested parties). And even after that > happens and the commit gets made there is some time for fallout > discussions to happen. Depending on the results of those potentially > lengthy discussions it might wind up being backed out. But because of > the stage of the release cycle we're in me having approved this can be > viewed as short-circuiting the normal public review because odds are it > will wind up staying despite some peoples' opinions due to the stage of > the release cycle we're in. Given that it doesn't make any significant difference if it makes it into the base for 8.0 (especially given that ports are still open). I'd say the only right course of action is to back it out. I personally wouldn't be surprised if some form of it made it in to a future release, but basically nothing was right with this commit (zero prior discussion, contained trivial bugs, last minute addition). -- Brooks pgpV20zJccD3a.pgp Description: PGP signature
Re: svn commit: r195200 - in head/usr.sbin: . wake
On Tue, 2009-06-30 at 21:56 -0400, Ken Smith wrote: > On Tue, 2009-06-30 at 16:40 -0600, M. Warner Losh wrote: > > I hate to be blunt, but this leaves a bad taste in everybody's mouth, > > even if at the end of the day you get your way. > > Translation: I did it again. I hate it when that happens... :-( > > Two things happened here that were a bit unfortunate, and Marc/Martin > (most likely unintentionally) tripped over it. > > The first thing that left a bad taste in some peoples' mouth is this new > thing got approved past the point I had said many times was to be the > end of new things getting added. But people complained the warnings I > had given were buried in messages that had too much other information in > them instead of short and to-the-point messages. So deadlines for a few > things got extended in short and to-the-point messages yesterday and > this pending request fell into one of those categories. If you missed the deadline because you chose to skim messages from the release manager, then so be it... If people have work that they want to get into the release, then they should be paying attention to mail from r...@. I know that I have work that I would have liked to gotten in, but complications arose which made it obvious that resolving them within the remaining time before the freeze was not practical. > The second thing that left a bad taste in some peoples' mouth is that > this apparently (strictly judging by the fallout discussions) didn't get > as much peer review as some people would have liked. Normally some > level of discussion happens on some public mailing lists (not private > email among a few potentially interested parties). And even after that > happens and the commit gets made there is some time for fallout > discussions to happen. Depending on the results of those potentially > lengthy discussions it might wind up being backed out. But because of > the stage of the release cycle we're in me having approved this can be > viewed as short-circuiting the normal public review because odds are it > will wind up staying despite some peoples' opinions due to the stage of > the release cycle we're in. > > That second thing is one of the things that I think we're stuck with as > part of the release process, but I really need help from you folks on. > It's very much like the rant I made about the commit requests. And like > I said above I fell for this before, during the 7.0 release cycle. > During that release cycle it resulted in a rant with the subject line > "I'm not Head Dictator In Charge". People complain if we lock out *all* > new additions, even ones as relatively simple as a new command, too > early in the release cycle. So we *consider* allowing new stuff that > truly shouldn't impact the stability of the pending release until right > around now in the release cycle. But we need to be able to trust that > if you send in a commit request for something new like this that you've > already done the peer review type stuff. RE approval for something like > this doesn't trump normal peer review. The alternative is to flat out > lock out *all* new stuff no matter how seemingly simple it is earlier in > the release cycle just to avoid the problem that maybe someone will try > to sneak something through without sufficient peer review. A feature freeze in my mind is exactly that. re@ should be approving bug fixes only. No new work should be allowed beyond the freeze date. There is always the next release. That or people should have been paying attention and gotten things into the tree on time with appropriate review. robert. > Thanks... -- Robert Noland FreeBSD signature.asc Description: This is a digitally signed message part
Re: svn commit: r194628 - head/lib/ncurses/ncurses
On Wed, 1 Jul 2009, Ivan Voras wrote: > > Looks like "setenv LESS -X" or "export LESS=-X" would do the same > > thing, no? And work for "more" too... > > Would it be possible to set it by default in /etc/csh.login (or > wherever is more appropriate) if the termcap change goes in? How about vi? Can that be fixed (if it needs it)? About the only use for clearing the screen is when you logout IMO, it is so frustrating otherwise (IMO of course :) -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C signature.asc Description: This is a digitally signed message part.
Re: svn commit: r195200 - in head/usr.sbin: . wake
Martin Blapp skrev: Author: mbr Date: Tue Jun 30 18:51:22 2009 New Revision: 195200 URL: http://svn.freebsd.org/changeset/base/195200 Log: Add wake, a tool to send Wake on LAN frames to hosts on a local Ethernet network Nice. Now I can finally nuke net/wol from my systems. -- Joel ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
AW: svn commit: r195200 - in head/usr.sbin: . wake
Hi folks, I really was not my or Marcs intention to skip any discussions. Rwatson told us that if we like to see it in 8.0, we need to approve it by RE and commit it before the 1. of july, and that's what I've done. Sorry if I've upset anyone. Personally I think the tool is quite handy, better than net/wol (which doesn't seem to work with different interfaces), wake doesn't need any strange libaries as dependencies and it just a very short one (4k) If the concensus is to back it out, I'll back it out. -- Martin___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r195200 - in head/usr.sbin: . wake
> Nice! I guess I can now remove installed net/wol ports which does > not work as expected when system have multiple interfaces. And I > didn't understand why it requires perl to build such a simple > utility. Have a look at the build process and you see exactly why it needs perl. The question should have been: Why didn't they write it in a .pod in the first place! :-P Edwin -- Edwin Groothuis Website: http://www.mavetju.org/ ed...@mavetju.org Weblog: http://www.mavetju.org/weblog/ ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: AW: svn commit: r195200 - in head/usr.sbin: . wake
Am 01.07.2009 um 07:04 schrieb Blapp, Martin: Hi folks, I really was not my or Marcs intention to skip any discussions. Rwatson told us that if we like to see it in 8.0, we need to approve it by RE and commit it before the 1. of july, and that's what I've done. Sorry if I've upset anyone. Personally I think the tool is quite handy, better than net/wol (which doesn't seem to work with different interfaces), wake doesn't need any strange libaries as dependencies and it just a very short one (4k) If the concensus is to back it out, I'll back it out. The only thing I can say is that this code has been around since quite some time and is in use at many places without any problems. This is nothing big, actually really small, but it is really useful. And since Wake-on-LAN is now in almost all computers I think having a tool to use it is justified. This little command can not make your computer crash, nor cause any problems, so I really do not fully understand why all the fuss around it (e.g. I find that some people are exaggerating a little bit, given how small of an addition wake(8) actually is). ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: AW: svn commit: r195200 - in head/usr.sbin: . wake
Am 01.07.2009 um 07:04 schrieb Blapp, Martin: If the concensus is to back it out, I'll back it out. That would be sad. After all there were very positive reactions from folks that actually looked at the tool, the negative replies came from folks that saw some process violated, iirc but hey, after all the committ was approved by the _release_ engineers. I was under the impression that the _release_ folks can give such approval. It was not rush something very in new in, the code is proven and wherever it show up, people immediately see the use of it. The point is that I submittet this in an arbitrary point of my timeline, not being aware of any dates at all, because starting with FreeBSD 8.0 we want to switch a lot of POS terminals/servers to FreeBSD starting with 8.0, and for them we need wake(8). So I yes, I submited this to have it in 8.0, but no, I was not really aware that this was close to a timeline. Now that re@ approved it, where is the sense of removing it from 8.0, just to add then for 9.0? (other that it means I will have to wait for one more release cycle). ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"