Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 12: > It does not seem to catch anything > npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.2.0 > npm notice Run npm install -g npm@11.2.0 to update! > npm notice > { > "comments": {} > } I had implemented and verified the flat file configs to do this for files within www/. But, > Nov 8, 2023 > Everything in the www/ directory gets packaged as part of an Impala > distribution. i'd rather put these somewhere else, maybe a subdirectory of > infra/. Without having ESLint and NodeJS as direct parent directories of scripts, to support linting files externally, not within the same node module/path, without even having configuration files in the same directory as flat file configs in ESLint do not support linting any files without having copies as modules in each subdirectory or having package.json and configs in root directory, IMPALA_HOME. So after trying out many possible configurations, I have changed ESlint to the old common js configuration format, to support linting any file externally. > Also, can you address the WARN deprecated comment please? I have verified the warnings in inflight, it is a very short-lived process, and we are using ESLint only in CI jobs for syntax highlighting, they do not affect builds, also with the last stable version of Eslint 8.57.1. To note, we had also chosen node v16 over the initial patch with node v18 to support possible OS with older GLIB_C https://gerrit.cloudera.org/#/c/20538/3/tests/run-js-tests.sh@53. In summary, we are successfully linting scripts in any directory now. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 12 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Mar 2025 22:17:33 +0000 Gerrit-HasComments: No
