Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 13: (187 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/queries/profileParseWorker.test.js File tests/webui/js_tests/queries/profileParseWorker.test.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/queries/profileParseWorker.test.js@18 PS13, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/queries/profileParseWorker.test.js@19 PS13, Line 19: import {readFileSync} from 'node:fs'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/queries/profileParseWorker.test.js@29 PS13, Line 29: import("pako.min.js").then((pako) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/queries/profileParseWorker.test.js@30 PS13, Line 30: pako = pako.default; Assignment to function parameter 'pako'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/queries/profileParseWorker.test.js@31 PS13, Line 31: expect(pako.inflate(pako.deflate(exampleJSONProfileText, {level : 3}), {to : "string"})) This line has a length of 94. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js File tests/webui/js_tests/query_timeline/chart_commons.test.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@18 PS13, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@21 PS13, Line 21: 'scripts/query_timeline/chart_commons.js'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@29 PS13, Line 29: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@30 PS13, Line 30: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@31 PS13, Line 31: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@33 PS13, Line 33: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@34 PS13, Line 34: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@35 PS13, Line 35: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@36 PS13, Line 36: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@37 PS13, Line 37: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@38 PS13, Line 38: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@39 PS13, Line 39: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@41 PS13, Line 41: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@42 PS13, Line 42: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@43 PS13, Line 43: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@44 PS13, Line 44: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@45 PS13, Line 45: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@47 PS13, Line 47: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@48 PS13, Line 48: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@49 PS13, Line 49: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@50 PS13, Line 50: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@51 PS13, Line 51: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@71 PS13, Line 71: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@72 PS13, Line 72: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@73 PS13, Line 73: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@75 PS13, Line 75: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@76 PS13, Line 76: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@77 PS13, Line 77: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@78 PS13, Line 78: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@79 PS13, Line 79: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@80 PS13, Line 80: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@81 PS13, Line 81: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@83 PS13, Line 83: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@84 PS13, Line 84: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@85 PS13, Line 85: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@86 PS13, Line 86: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@87 PS13, Line 87: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@89 PS13, Line 89: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@90 PS13, Line 90: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@91 PS13, Line 91: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@92 PS13, Line 92: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@93 PS13, Line 93: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@113 PS13, Line 113: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@114 PS13, Line 114: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@115 PS13, Line 115: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@117 PS13, Line 117: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@118 PS13, Line 118: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@119 PS13, Line 119: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@120 PS13, Line 120: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@121 PS13, Line 121: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@122 PS13, Line 122: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@123 PS13, Line 123: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@125 PS13, Line 125: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@126 PS13, Line 126: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@127 PS13, Line 127: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@128 PS13, Line 128: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@129 PS13, Line 129: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@131 PS13, Line 131: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@132 PS13, Line 132: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@133 PS13, Line 133: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@134 PS13, Line 134: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@135 PS13, Line 135: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@168 PS13, Line 168: period: 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@169 PS13, Line 169: num: 2000, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@170 PS13, Line 170: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@195 PS13, Line 195: period: 200, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@196 PS13, Line 196: num: 300, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@197 PS13, Line 197: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@223 PS13, Line 223: period: 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@224 PS13, Line 224: num: 300, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@225 PS13, Line 225: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@250 PS13, Line 250: period: 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@251 PS13, Line 251: num: 300, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@252 PS13, Line 252: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@349 PS13, Line 349: expect(values_array).toEqual([DATA_TYPE, 0, null, null, null, null, null, null, null]); This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@358 PS13, Line 358: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@359 PS13, Line 359: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@360 PS13, Line 360: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@362 PS13, Line 362: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@363 PS13, Line 363: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@364 PS13, Line 364: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@365 PS13, Line 365: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@366 PS13, Line 366: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@367 PS13, Line 367: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@368 PS13, Line 368: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@370 PS13, Line 370: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@371 PS13, Line 371: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@372 PS13, Line 372: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@373 PS13, Line 373: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@374 PS13, Line 374: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@376 PS13, Line 376: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@377 PS13, Line 377: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@378 PS13, Line 378: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@379 PS13, Line 379: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@380 PS13, Line 380: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@384 PS13, Line 384: "profile_name": "host-1:27001", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@385 PS13, Line 385: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@386 PS13, Line 386: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@387 PS13, Line 387: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@388 PS13, Line 388: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@389 PS13, Line 389: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@390 PS13, Line 390: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@392 PS13, Line 392: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@393 PS13, Line 393: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@394 PS13, Line 394: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@395 PS13, Line 395: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@396 PS13, Line 396: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@398 PS13, Line 398: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@399 PS13, Line 399: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@400 PS13, Line 400: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@401 PS13, Line 401: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@402 PS13, Line 402: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@406 PS13, Line 406: "profile_name": "host-1:27001", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@407 PS13, Line 407: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@408 PS13, Line 408: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@409 PS13, Line 409: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@410 PS13, Line 410: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@411 PS13, Line 411: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@412 PS13, Line 412: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@414 PS13, Line 414: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@415 PS13, Line 415: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@416 PS13, Line 416: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@417 PS13, Line 417: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@418 PS13, Line 418: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@420 PS13, Line 420: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@421 PS13, Line 421: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@422 PS13, Line 422: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@423 PS13, Line 423: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@424 PS13, Line 424: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@452 PS13, Line 452: ['avg io wait', 0, 0, 0, 0, 210, 0, 0, 0, 0, 0, 30], Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@453 PS13, Line 453: ['avg sys', 0, 936, 2037, 1335,1320, 903, 903, 936, 375, 375, 1311], Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/chart_commons.test.js@454 PS13, Line 454: ['avg user', 0, 936, 2037, 1335, 1320, 903, 903, 936, 375, 375, 1311] Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js File tests/webui/js_tests/query_timeline/fragment_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@18 PS13, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@24 PS13, Line 24: const stroke_fill_colors = { black : "#000000", dark_grey : "#505050", There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@25 PS13, Line 25: light_grey : "#F0F0F0", transperent : "rgba(0, 0, 0, 0)" }; There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@30 PS13, Line 30: '<rect x="0" y="0" width="100" height="100"' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@39 PS13, Line 39: '<line x1="0" y1="0" x2="100" y2="100"' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@41 PS13, Line 41: + ' stroke-dasharray="2 2"></line>'); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@47 PS13, Line 47: '<text x="0" y="0" style="font-size: 10px;" dominant-baseline="middle" ' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@49 PS13, Line 49: + 'lengthAdjust="spacingAndGlyphs">Text</text>'); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js File tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@27 PS13, Line 27: "profile_name": "Coordinator Fragment F31", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@28 PS13, Line 28: "num_children": 1, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@29 PS13, Line 29: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@31 PS13, Line 31: "profile_name": "Instance fe45c9c56d1:efd1b2a70000 (host=host-1:27000)", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@32 PS13, Line 32: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@33 PS13, Line 33: "counter_name": "MemoryUsage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@34 PS13, Line 34: "unit": "BYTES", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@35 PS13, Line 35: "num": 6, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@36 PS13, Line 36: "period": 500, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@37 PS13, Line 37: "data": "12288,12288,12288,12288,12288,12288" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@39 PS13, Line 39: "counter_name": "ThreadUsage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@40 PS13, Line 40: "unit": "UNIT", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@41 PS13, Line 41: "num": 1, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@42 PS13, Line 42: "period": 500, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@43 PS13, Line 43: "data": "4" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js File tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@18 PS13, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@28 PS13, Line 28: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@29 PS13, Line 29: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@30 PS13, Line 30: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@32 PS13, Line 32: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@33 PS13, Line 33: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@34 PS13, Line 34: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@35 PS13, Line 35: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@36 PS13, Line 36: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@37 PS13, Line 37: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@38 PS13, Line 38: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@40 PS13, Line 40: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@41 PS13, Line 41: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@42 PS13, Line 42: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@43 PS13, Line 43: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@44 PS13, Line 44: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@46 PS13, Line 46: "counter_name": "HostNetworkRx", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@47 PS13, Line 47: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@48 PS13, Line 48: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@49 PS13, Line 49: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@50 PS13, Line 50: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint.config.js File tests/webui/linting/eslint.config.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint.config.js@76 PS13, Line 76: overrides: [ Missing space after key 'overrides'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint.config.js@79 PS13, Line 79: parserOptions: { Missing space after key 'parserOptions'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint.config.js@80 PS13, Line 80: sourceType: "script" Missing space after key 'sourceType'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint.config.js@84 PS13, Line 84: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint/eslint_custom_output_formatter.js File tests/webui/linting/eslint/eslint_custom_output_formatter.js: http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint/eslint_custom_output_formatter.js@24 PS13, Line 24: message: message.message, // Include the error/warning message Missing space after key 'message'. http://gerrit.cloudera.org:8080/#/c/21970/13/tests/webui/linting/eslint/eslint_custom_output_formatter.js@25 PS13, Line 25: line: message.line // Include the line number Missing space after key 'line'. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 17:45:46 +0000 Gerrit-HasComments: Yes
