Surya Hebbar has posted comments on this change. (
http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with
ESLint
......................................................................
Patch Set 10:
I did not realize two seperate auto-critic-jobs run for the same patchset now,
* one dryrun (gerrit-auto-critic-test)
* another time while posting comments (gerrit-auto-critic)
Please let me know, if there is a reason for two seperate auto-critic jobs.
Also, within the jobs, the same revision is being used to review the scripts
themselves.
GERRIT_REPO_URL
GERRIT_REFSPEC
I think, previously scripts from the following refspec were being used to
review the current patch.
IMPALA_REPO_URL=https://gitbox.apache.org/repos/asf/impala.git
IMPALA_REPO_BRANCH=master
I am not sure, if it is better to use master as reference for reviewing changes
as before.
But, if the current is the expected behavior, we possibly do not need to clone
twice.
--
To view, visit http://gerrit.cloudera.org:8080/21970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f
Gerrit-Change-Number: 21970
Gerrit-PatchSet: 10
Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 14:06:32 +0000
Gerrit-HasComments: No
