Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 10: > I did not realize two seperate auto-critic-jobs run for the same patchset > now, > * one dryrun (gerrit-auto-critic-test) > * another time while posting comments (gerrit-auto-critic) > > Please let me know, if there is a reason for two seperate auto-critic jobs. > If gerrit-auto-critic failed due to bugs in the script, it won't be able to report anything, which acts like everything is good. Note that it's not a sub-task of gerrit-code-review-checks. It's triggered by gerrit events directly. The other dryrun task, gerrit-auto-critic-test, is a sub-task of gerrit-code-review-checks. If it fails, gerrit-auto-critic-test will report the failure by posting comments here. This helps to avoid bugs like IMPALA-13597. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 12:59:24 +0000 Gerrit-HasComments: No
