Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 11: I test adding bad JS commit right above this, and run critique-gerrit-review.py like this: python3 bin/jenkins/critique-gerrit-review.py --dryrun --base-revision dc13b06 Requirement already satisfied: wheel in /usr/lib/python3/dist-packages (0.34.2) Requirement already satisfied: flake8==7.1.1 in ./gerrit_critic_venv/lib/python3.8/site-packages (7.1.1) Requirement already satisfied: flake8-diff==0.2.2 in ./gerrit_critic_venv/lib/python3.8/site-packages (0.2.2) Requirement already satisfied: pyparsing==3.1.4 in ./gerrit_critic_venv/lib/python3.8/site-packages (3.1.4) Requirement already satisfied: flake8-unused-arguments==0.0.13 in ./gerrit_critic_venv/lib/python3.8/site-packages (0.0.13) Requirement already satisfied: mccabe<0.8.0,>=0.7.0 in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8==7.1.1) (0.7.0) Requirement already satisfied: pyflakes<3.3.0,>=3.2.0 in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8==7.1.1) (3.2.0) Requirement already satisfied: pycodestyle<2.13.0,>=2.12.0 in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8==7.1.1) (2.12.1) Requirement already satisfied: blessings in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8-diff==0.2.2) (1.7) Requirement already satisfied: argparse in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8-diff==0.2.2) (1.4.0) Requirement already satisfied: six in /usr/lib/python3/dist-packages (from flake8-diff==0.2.2) (1.14.0) Updated 0 paths from the index npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported npm WARN deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm WARN deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead npm WARN deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options. npm notice npm notice New major version of npm available! 8.19.4 -> 11.2.0 npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.2.0 npm notice Run npm install -g npm@11.2.0 to update! npm notice { "comments": {} } It does not seem to catch anything (notice empty "comments"). Also, can you address the WARN deprecated comment please? -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 11 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 15:52:51 +0000 Gerrit-HasComments: No
