Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 12: > Patch Set 12: > > > If gerrit-auto-critic failed due to bugs in the script, it won't be > > able to report anything, which acts like everything is good. Note > > that it's not a sub-task of gerrit-code-review-checks. It's > > triggered by gerrit events directly. > > > > The other dryrun task, gerrit-auto-critic-test, is a sub-task of > > gerrit-code-review-checks. If it fails, gerrit-auto-critic-test > > will report the failure by posting comments here. This helps to > > avoid bugs like IMPALA-13597. > > > > But, if the current is the expected behavior, we possibly do not > > need to clone twice. > > IMPALA_REPO_URL=https://gitbox.apache.org/repos/asf/impala.git > > IMPALA_REPO_BRANCH=master > > Thank you for the clarification. By cloning, I was actually referring to two > repeated "git clone. > > Even if we are not using the asf-master, do we still need to clone > twice(IMPALA_SCRIPTS_HOME, IMPALA_REVIEWS_HOME) for both jobs. I had the same question before. I guess at the very begining, the script could mess up the folder by some git commands so we create a separate folder for it. We can try single clone in a duplicated job. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 12 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 01:38:54 +0000 Gerrit-HasComments: No
