Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 9: > Patch Set 9: > > Build Failed > > https://jenkins.impala.io/job/gerrit-code-review-checks/18561/ : Initial code > review checks failed. See linked job for details on the failure. Have you investigate what is the issue here? I see this error. 16:03:53 23:03:53.323399 git.c:439 trace: built-in: git diff HEAD^..HEAD --name-only -- '*.js' 16:03:53 Traceback (most recent call last): 16:03:53 File "/var/lib/jenkins/workspace/gerrit-auto-critic-test/Impala/bin/jenkins/critique-gerrit-review.py", line 489, in <module> 16:03:53 merge_comments(comments, get_eslint_comments(base_revision, revision)) 16:03:53 File "/var/lib/jenkins/workspace/gerrit-auto-critic-test/Impala/bin/jenkins/critique-gerrit-review.py", line 428, in get_eslint_comments 16:03:53 NODEJS_SETUP = os.path.join(node_env["IMPALA_HOME"], "bin/nodejs/setup_nodejs.sh") 16:03:53 File "/usr/lib/python3.8/posixpath.py", line 76, in join 16:03:53 a = os.fspath(a) 16:03:53 TypeError: expected str, bytes or os.PathLike object, not NoneType -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 9 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Mar 2025 16:25:17 +0000 Gerrit-HasComments: No
