findepi commented on code in PR #14483:
URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942619187
##########
.github/workflows/extended.yml:
##########
@@ -87,7 +87,7 @@ jobs:
- name: Run tests
run: |
cd datafusion
- cargo test --profile ci --exclude datafusion-examples --exclude
datafusion-benchmarks --exclude datafusion-sqllogictest --workspace --lib
--tests --features=force_hash_collisions,avro,extended_tests
+ cargo test --profile ci --exclude datafusion-examples --exclude
datafusion-benchmarks --exclude datafusion-sqllogictest --workspace --lib
--tests --features=force_hash_collisions,avro,extended_tests --locked
Review Comment:
Fail-fast is not unreasonable, i didn't think about this.
otoh one could say same thing about formatting issues. there is definitely
tradeoff between conserving CI resources and maxing our single PR feedback
signal.
let's put cargo.lock consistency in the "formatting bucket", ie reuse
previous design decision for now. i am open to revisiting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
