mbrobbel commented on code in PR #14483:
URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942627197
##########
ci/scripts/rust_clippy.sh:
##########
@@ -18,6 +18,4 @@
# under the License.
set -ex
-cargo clippy --all-targets --workspace --features
avro,pyarrow,integration-tests -- -D warnings
-cd datafusion-cli
-cargo clippy --all-targets --all-features -- -D warnings
Review Comment:
The above passes, except for one warning:
```
error: use of a disallowed method `tokio::task::spawn`
--> datafusion/sqllogictest/src/engines/postgres_engine/mod.rs:93:27
```
I think we can just add `#[allow(clippy::disallowed_methods)]` there.
But I agree, let's do this in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
