alamb commented on code in PR #14483:
URL: https://github.com/apache/datafusion/pull/14483#discussion_r1946783959
##########
.github/workflows/rust.yml:
##########
@@ -60,7 +60,10 @@ jobs:
with:
rust-version: stable
- name: Prepare cargo build
- run: cargo check --profile ci --all-targets --features
integration-tests
+ # Adding `--locked` here to assert that the `Cargo.lock` file is up to
+ # date with the manifest. When this fails, please make sure to commit
+ # the changes to `Cargo.lock` after building with the updated manifest.
+ run: cargo check --profile ci --workspace --all-targets --features
integration-tests --locked
Review Comment:
when written like this the comments don't show up in the CI output (only
what is run via `run` is
```suggestion
run: |
# Adding `--locked` here to assert that the `Cargo.lock` file is
up to
# date with the manifest. When this fails, please make sure to
commit
# the changes to `Cargo.lock` after building with the updated
manifest.
cargo check --profile ci --workspace --all-targets --features
integration-tests --locked
```
##########
.github/workflows/rust.yml:
##########
@@ -60,7 +60,10 @@ jobs:
with:
rust-version: stable
Review Comment:
this is a nice idea to only use `--locked` in one test 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
