mbrobbel commented on code in PR #14483:
URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942614160
##########
.github/workflows/extended.yml:
##########
@@ -87,7 +87,7 @@ jobs:
- name: Run tests
run: |
cd datafusion
- cargo test --profile ci --exclude datafusion-examples --exclude
datafusion-benchmarks --exclude datafusion-sqllogictest --workspace --lib
--tests --features=force_hash_collisions,avro,extended_tests
+ cargo test --profile ci --exclude datafusion-examples --exclude
datafusion-benchmarks --exclude datafusion-sqllogictest --workspace --lib
--tests --features=force_hash_collisions,avro,extended_tests --locked
Review Comment:
Yes, I added it everywhere to let all these jobs fail early when the lock
file needs to be updated (to save CI resources), because in that case all those
jobs are going to have to run again when the lock file is updated. But I'm also
fine with only keeping it for one check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]