alamb commented on code in PR #14483: URL: https://github.com/apache/datafusion/pull/14483#discussion_r1941893809
########## README.md: ########## @@ -152,26 +152,13 @@ deprecate methods before removing them, according to the [deprecation guidelines [deprecation guidelines]: https://datafusion.apache.org/library-user-guide/api-health.html -## Dependencies and a `Cargo.lock` +## Dependencies and `Cargo.lock` -`datafusion` is intended for use as a library and thus purposely does not have a -`Cargo.lock` file checked in. You can read more about the distinction in the -[Cargo book]. +Following the [updated guidance] on committing `Cargo.lock` files, this project +commits its `Cargo.lock` file. -CI tests always run against the latest compatible versions of all dependencies -(the equivalent of doing `cargo update`), as suggested in the [Cargo CI guide] -and we rely on Dependabot for other upgrades. This strategy has two problems -that occasionally arise: +CI uses the committed `Cargo.lock` file, and dependencies are updated regularly Review Comment: ❤️ ########## datafusion-cli/Cargo.toml: ########## @@ -18,23 +18,22 @@ [package] name = "datafusion-cli" description = "Command Line Client for DataFusion query engine." -version = "45.0.0" -authors = ["Apache DataFusion <d...@datafusion.apache.org>"] -edition = "2021" -keywords = ["arrow", "datafusion", "query", "sql"] -license = "Apache-2.0" -homepage = "https://datafusion.apache.org"; -repository = "https://github.com/apache/datafusion"; -rust-version = "1.81.0" readme = "README.md" +version = { workspace = true } Review Comment: this is pretty sweet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
