mbrobbel commented on code in PR #14483: URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942595648
########## ci/scripts/rust_clippy.sh: ########## @@ -18,6 +18,4 @@ # under the License. set -ex -cargo clippy --all-targets --workspace --features avro,pyarrow,integration-tests -- -D warnings -cd datafusion-cli -cargo clippy --all-targets --all-features -- -D warnings Review Comment: I agree. We could change this to: ``` cargo clippy --workspace --all-targets --all-features --exclude datafusion-benchmarks -- -Dwarnings cargo clippy -p datafusion-benchmarks --all-targets -- -Dwarnings ``` What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
