findepi commented on code in PR #14483: URL: https://github.com/apache/datafusion/pull/14483#discussion_r1942581503
########## README.md: ########## @@ -152,26 +152,13 @@ deprecate methods before removing them, according to the [deprecation guidelines [deprecation guidelines]: https://datafusion.apache.org/library-user-guide/api-health.html -## Dependencies and a `Cargo.lock` +## Dependencies and `Cargo.lock` -`datafusion` is intended for use as a library and thus purposely does not have a -`Cargo.lock` file checked in. You can read more about the distinction in the -[Cargo book]. +Following the [updated guidance] on committing `Cargo.lock` files, this project Review Comment: "updated" makes sense from history perspective (eg for someone looking at the PR diff, or project history) The (future) reader of this page doesn't need to care about what was the previous guidance. _if we were writing this document anew today_, we would just say "guidance" (or "Rust guidance"). So let's say so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
