On Thu, 14 Nov 2024 19:51:33 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> See review comments from @RogerRiggs: >> >> https://github.com/openjdk/jdk/pull/22099#pullrequestreview-2435969401 >> https://github.com/openjdk/jdk/pull/22099#discussion_r1842150753 >> >> where the folding of these lines into one was suggested. >> >> I'm fine either way, but I agree the lines are somewhat long. It makes the >> longest line in `ZipOutputStream` and the fifth longest line in `JarFile`. >> >> Can you coordinate with @RogerRiggs and let me know what is the preferred >> style here? Thanks! > > As long as the line in your ide is around 80 characters or less you are good > to go. If it is say 100 bytes so you have to scroll, that is when I would > fold the line. > > I think you are OK here Yes, they are 96 and 98 chars long, which means I sympathise with both views :) Unless hearing back from @seanjmullan I'll go with Roger's suggestion of one line here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842817353
