On Thu, 14 Nov 2024 19:45:27 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 182:
>>
>>> 180: }
>>> 181: RUNTIME_VERSION =
>>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>>> 182: String enableMultiRelease =
>>> System.getProperty("jdk.util.jar.enableMultiRelease", "true");
>>
>> The line is a little long, can you break it in 2 lines?
>
> See review comments from @RogerRiggs:
>
> https://github.com/openjdk/jdk/pull/22099#pullrequestreview-2435969401
> https://github.com/openjdk/jdk/pull/22099#discussion_r1842150753
>
> where the folding of these lines into one was suggested.
>
> I'm fine either way, but I agree the lines are somewhat long. It makes the
> longest line in `ZipOutputStream` and the fifth longest line in `JarFile`.
>
> Can you coordinate with @RogerRiggs and let me know what is the preferred
> style here? Thanks!
As long as the line in your ide is around 80 characters or less you are good
to go. If it is say 100 bytes so you have to scroll, that is when I would fold
the line.
I think you are OK here
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842809954
