On Thu, 14 Nov 2024 20:02:50 GMT, Lance Andersen <lan...@openjdk.org> wrote:

>> I think both are in the 90-100 range. Line length is a bit subjective, but I 
>> know that at least in the Security Group, we try to keep code to around 80 
>> chars so it is easy to review in a side-by-side diff. It also is visually 
>> easier to read I think. In these cases, when breaking, I think it makes 
>> sense to break after the `=`. The other option is to make the variable names 
>> smaller.
>
> So if the line is 90+ bytes, then please wrap it

Ok, seems consensus  is converging on wrapping these lines. 

See a93a7ed which reverts the folding.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842846855

Reply via email to