On Thu, 14 Nov 2024 19:30:58 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fold lines for System::getProperty when reading enableMultiRelease and
>> inhibitZip64
>
> src/java.base/share/classes/java/util/jar/JarFile.java line 182:
>
>> 180: }
>> 181: RUNTIME_VERSION =
>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>> 182: String enableMultiRelease =
>> System.getProperty("jdk.util.jar.enableMultiRelease", "true");
>
> The line is a little long, can you break it in 2 lines?
See review comments from @RogerRiggs:
https://github.com/openjdk/jdk/pull/22099#pullrequestreview-2435969401
https://github.com/openjdk/jdk/pull/22099#discussion_r1842150753
where the folding of these lines into one was suggested.
I'm fine either way, but I agree the lines are somewhat long. It makes the
longest line in `ZipOutputStream` and the fifth longest line in `JarFile`.
Can you coordinate with @RogerRiggs and let me know what is the preferred style
here? Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842802846
