On Thu, 14 Nov 2024 20:25:35 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Please review this PR which cleans up security manager related code in >> `java.util.zip` and `java.util.jar`: >> >> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead >> of `GetPropertyAction::privilegedGetProperty` >> * `ZipFile` is updated to not call SM::checkRead, SM::checkDelete when >> opening files >> * `ZipOutputStream` is updated to use `Boolean::getBoolean` instead of >> `GetBooleanAction::privilegedGetProperty` >> >> The field `ZipFile.startsWithLoc` is deliberately left alone, that should be >> handled separately. I found no SM-dependent code in the ZIP or JAR tests. >> >> Testing: This is a cleanup PR, no tests are changed or updated. ZIP and JAR >> tests run green locally. GHA results pending. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Revert "Fold lines for System::getProperty when reading enableMultiRelease > and inhibitZip64" > > This reverts commit 6a72b060501981842822680cfa700d1d287f8c04. Marked as reviewed by lancea (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/22099#pullrequestreview-2437128522
