On Thu, 14 Nov 2024 12:37:33 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fold lines for System::getProperty when reading enableMultiRelease and
>> inhibitZip64
>
> src/java.base/share/classes/java/util/jar/JarFile.java line 183:
>
>> 181: RUNTIME_VERSION =
>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>> 182: String enableMultiRelease = System.
>> 183: getProperty("jdk.util.jar.enableMultiRelease", "true");
>
> I'd fold this to a single line.
Thanks, makes sense. This makes this line the fifth longest line in
`JarFile.java`.
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 60:
>
>> 58: */
>> 59: private static final boolean inhibitZip64 =
>> 60: Boolean.getBoolean("jdk.util.zip.inhibitZip64");
>
> fold to a single line.
Thanks, makes sense. This makes this line the longest line in
`ZipOutputStream.java`, the next longest being one character shorer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842207585
PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842207626
