vkagamlyk commented on code in PR #3384:
URL: https://github.com/apache/tinkerpop/pull/3384#discussion_r3138934383
##########
docker/gremlin-server/gremlin-server-integration-krb5.yaml:
##########
@@ -27,14 +27,21 @@ graphs: {
sink: conf/tinkergraph-empty.properties,
tx: conf/tinkertransactiongraph-empty.properties
}
-scriptEngines: {
- gremlin-lang : {},
- gremlin-groovy: {
- plugins: {
org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
-
org.apache.tinkerpop.gremlin.tinkergraph.jsr223.TinkerGraphGremlinPlugin: {},
-
org.apache.tinkerpop.gremlin.groovy.jsr223.GroovyCompilerGremlinPlugin:
{expectedCompilationTime: 30000},
- org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin:
{classImports: [java.lang.Math], methodImports: [java.lang.Math#*]},
- org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin:
{files: [scripts/generate-all.groovy]}}}}
+traversalSources: {
Review Comment:
Other possible options:
1. To have all graph related config in single `.properties` file, something
like
```
gremlin.graph=org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph
gremlin.graph.traversalSource=g
gremlin.graph.traversalSource={ name: "gg", gremlinExpression:
"g.withStrategies(ReadOnlyStrategy)", language: "gremlin-lang" }
gremlin.graph.lifecycleHook={ className:
org.apache.tinkerpop.gremlin.server.util.TinkerFactoryDataLoader, config:
{dataset: modern}}
gremlin.graph.lifecycleHook={ className:
com.software.company.GroovyInsanity, config: {script: "System.exit(0)"}}
gremlin.tinkergraph.vertexIdManager=LONG
```
or structured
```
gremlin.graph.traversalSource.1.name=gg
gremlin.graph.traversalSource.1.gremlinExpression=g.withStrategies(ReadOnlyStrategy)
gremlin.graph.traversalSource.1.language=gremlin-lang
```
2. To get rid of `.properties` files and have all config in same file
```
graphs: {
graph: {
graph: org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph,
vertexIdManager: LONG,
traversalSources:
- g
- { name: "gg", gremlinExpression:
"g.withStrategies(ReadOnlyStrategy)", language: "gremlin-lang" }
lifecycleHooks:
- { className:
org.apache.tinkerpop.gremlin.server.util.TinkerFactoryDataLoader, config:
{dataset: modern}}
- { className: com.software.company.GroovyInsanity, config: {script:
"System.exit(0)"}}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
