Cole-Greer commented on code in PR #3384:
URL: https://github.com/apache/tinkerpop/pull/3384#discussion_r3164638039
##########
docker/gremlin-server/gremlin-server-integration-krb5.yaml:
##########
@@ -27,14 +27,21 @@ graphs: {
sink: conf/tinkergraph-empty.properties,
tx: conf/tinkertransactiongraph-empty.properties
}
-scriptEngines: {
- gremlin-lang : {},
- gremlin-groovy: {
- plugins: {
org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
-
org.apache.tinkerpop.gremlin.tinkergraph.jsr223.TinkerGraphGremlinPlugin: {},
-
org.apache.tinkerpop.gremlin.groovy.jsr223.GroovyCompilerGremlinPlugin:
{expectedCompilationTime: 30000},
- org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin:
{classImports: [java.lang.Math], methodImports: [java.lang.Math#*]},
- org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin:
{files: [scripts/generate-all.groovy]}}}}
+traversalSources: {
Review Comment:
I've pushed changes which relocates `traversalSources` according to the
suggestion but leaves `lifecycleHooks` alone. I couldn't find something there I
liked that handled both globally-scoped hooks and graph-scoped hooks. One thing
to note, is that the format as discussed (see below) is a breaking change as it
moves the graph properties file into a new `configuration` key.
```
graphs: {
graph: {
configuration: conf/tinkergraph-empty.properties,
traversalSources:
- g
- { name: "gg", gremlinExpression:
"g.withStrategies(ReadOnlyStrategy)", language: "gremlin-lang" }
}
}
```
I chose to workaround this by allowing that syntax alongside the old format
of:
```
graphs: {
graph: conf/tinkergraph-empty.properties
}
```
The `Settings` get normalized to the new complex form upon parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
