vkagamlyk commented on code in PR #3384:
URL: https://github.com/apache/tinkerpop/pull/3384#discussion_r3135586031


##########
docker/gremlin-server/gremlin-server-integration-krb5.yaml:
##########
@@ -27,14 +27,21 @@ graphs: {
   sink: conf/tinkergraph-empty.properties,
   tx: conf/tinkertransactiongraph-empty.properties
 }
-scriptEngines: {
-  gremlin-lang : {},
-  gremlin-groovy: {
-    plugins: { 
org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
-               
org.apache.tinkerpop.gremlin.tinkergraph.jsr223.TinkerGraphGremlinPlugin: {},
-               
org.apache.tinkerpop.gremlin.groovy.jsr223.GroovyCompilerGremlinPlugin: 
{expectedCompilationTime: 30000},
-               org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin: 
{classImports: [java.lang.Math], methodImports: [java.lang.Math#*]},
-               org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin: 
{files: [scripts/generate-all.groovy]}}}}
+traversalSources: {

Review Comment:
   Considering that this is TinkerPop 4, maybe it makes sense to reconsider the 
graph initialization?
   
   for example can traversal sources and lifecycleHooks be part of graph 
configuration?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to