spmallette commented on code in PR #3384:
URL: https://github.com/apache/tinkerpop/pull/3384#discussion_r3137504653
##########
docker/gremlin-server/gremlin-server-integration-krb5.yaml:
##########
@@ -27,14 +27,21 @@ graphs: {
sink: conf/tinkergraph-empty.properties,
tx: conf/tinkertransactiongraph-empty.properties
}
-scriptEngines: {
- gremlin-lang : {},
- gremlin-groovy: {
- plugins: {
org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
-
org.apache.tinkerpop.gremlin.tinkergraph.jsr223.TinkerGraphGremlinPlugin: {},
-
org.apache.tinkerpop.gremlin.groovy.jsr223.GroovyCompilerGremlinPlugin:
{expectedCompilationTime: 30000},
- org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin:
{classImports: [java.lang.Math], methodImports: [java.lang.Math#*]},
- org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin:
{files: [scripts/generate-all.groovy]}}}}
+traversalSources: {
Review Comment:
that makes some sense actually. maybe the configuration makes more sense
living with the graph rather than referencing the graph all over the yaml (i
think that's what @vkagamlyk 's comment was about at least). that would lead to
a nicer configuration:
```yaml
graphs: {
graph: {
configuration: conf/tinkergraph-empty.properties,
traversalSources:
- g
- { name: "gg", gremlinExpression:
"g.withStrategies(ReadOnlyStrategy)", language: "gremlin-lang" }
lifecycleHooks:
- { className:
org.apache.tinkerpop.gremlin.server.util.TinkerFactoryDataLoader, config:
{dataset: modern}}
- { className: com.software.company.GroovyInsanity, config: {script:
"System.exit(0)"}}
}
}
````
also, in the docs it's written that:
> * A graph named `graph` is implicitly bound to `g`
> * All others are bound to `g_<graph-name>` (e.g. `modern` gets `g_modern`)
but does that mean that the configuration below produces 2 traversal sources
in this server (except for `g: {graph: graph},` - like, `gclassic` and
`g_classic`? a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
