kenhuuu commented on code in PR #3384:
URL: https://github.com/apache/tinkerpop/pull/3384#discussion_r3163587058


##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java:
##########
@@ -392,6 +392,15 @@ private void iterateScriptEvalResult(final Context 
context, MessageSerializer<?>
         final String language = args.containsKey(Tokens.ARGS_LANGUAGE) ? 
(String) args.get(Tokens.ARGS_LANGUAGE) : "gremlin-lang";
         final GremlinScriptEngine scriptEngine = 
gremlinExecutor.getScriptEngineManager().getEngineByName(language);
 
+        if (scriptEngine == null) {

Review Comment:
   This check can be done as soon as the RequestMessage is formed so it should 
be done before sendHttpResponse() so that the reponse from the server is an 
error rather than a 200 OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to