spmallette commented on code in PR #3384:
URL: https://github.com/apache/tinkerpop/pull/3384#discussion_r3130320258
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/util/LifeCycleHook.java:
##########
@@ -29,6 +32,15 @@
*/
public interface LifeCycleHook {
+ /**
+ * Called once after instantiation to pass configuration from the {@code
lifecycleHooks} YAML section.
+ * Implementations that require configuration should override this method.
The default implementation
+ * is a no-op so that existing hooks are not forced to implement it.
+ *
+ * @param config the key/value pairs from the {@code config} block in the
YAML entry
+ */
+ public default void init(final Map<String, Object> config) {}
Review Comment:
this was never clear before i don't think but can a `LifeCycleHook` prevent
the server from starting by throwing an exception? if so, i think it would be
good to add some guidance here in the javadoc for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
