On 29.03.2019 17:53, Stefan Roese wrote: > External E-Mail > > > On 29.03.19 11:04, eugen.hris...@microchip.com wrote: >> >> >> On 26.03.2019 14:16, Stefan Roese wrote: >> >>> >>> This patch adds the CONFIG_SPL_IMAGE option to select the SPL image that >>> shall be used to generate the combined SPL + U-Boot image. The default >>> value is the current value "spl/u-boot-spl.bin". > >>> This patch also sets CONFIG_SPL_IMAGE to "spl/boot.bin" for AT91 targets >>> which use SPL NAND support (boot from NAND). >>> >>> Signed-off-by: Stefan Roese <s...@denx.de> >>> Cc: Heiko Schocher <h...@denx.de> >>> Cc: Andreas Bießmann <andr...@biessmann.org> >>> Cc: Eugen Hristev <eugen.hris...@microchip.com> >>> --- >>> v2: >>> - No change >>> >>> Kconfig | 10 ++++++++++ >>> Makefile | 4 +++- >>> 2 files changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/Kconfig b/Kconfig >>> index 305b265ed7..7c2b86f1f3 100644 >>> --- a/Kconfig >>> +++ b/Kconfig >>> @@ -224,6 +224,15 @@ config BUILD_ROM >>> which are not shipped in the U-Boot source tree. >>> Please, see doc/README.x86 for details. >>> +config SPL_IMAGE >>> + string "SPL image filename that is generated" >>> + default "spl/boot.bin" if ARCH_AT91 && SPL_NAND_SUPPORT >>> + default "spl/u-boot-spl.bin" >> >> Hi Stefan, >> >> This means that the old spl/u-boot-spl.bin is gone for AT91 and NAND ? >> Please correct me if I am wrong > > No, its still there. > >>> + help >>> + The SPL image filename that is generated by the build process. >>> + This image might be used to generated a combined image with >>> + SPL and main U-Boot proper as well. >>> + >>> config BUILD_TARGET >>> string "Build target special images" >>> default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10 >>> @@ -232,6 +241,7 @@ config BUILD_TARGET >>> default "u-boot-elf.srec" if RCAR_GEN3 >>> default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI >>> default "u-boot.kwb" if KIRKWOOD >>> + default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT >> >> >> This means that before this patch, there was no special target for AT91 >> ? > > Yes. > >> Thus no special image was built ? > > Yes. > >> And after this patch, there will >> also be a new binary u-boot-with-spl.bin, except spl/boot.bin and >> spl/u-boot-spl.bin ? > > The old binaries are still generated. Only a new combined image is > generated too. > >> Thus your patch does a bit more than what it's explained in the commit >> message ? > > Does it? What exactly is missing in the commit message? Please explain > and I'll add something in the next patch version.
A new binary is generated on build after this patch is applied. Your commit states that you add a new Kconfig to select the name of a file which is included in a generating a binary (which did not exist before ) So I see 2 changes: 1) new binary will be created from now on 2) to create this binary a new Kconfig is used which selects one of the files used to create it > > Thanks, > Stefan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
