Hi!

> Warning (unit_address_vs_reg): Node /soc/usbphy@0 has a unit name,
>  but no reg property

I don't know who produces the warnings, but perhaps fix the tool,
instead?

> @@ -9,5 +9,5 @@
>       #size-cells = <1>;
>       chosen { };
>       aliases { };
> -     memory { device_type = "memory"; reg = <0 0>; };
> +     memory@0 { device_type = "memory"; reg = <0 0>; };
>  };

This does not look like an improvement to me...

> @@ -128,7 +128,7 @@
>                                               compatible = "fixed-clock";
>                                       };
>  
> -                                     main_pll: main_pll {
> +                                     main_pll: main_pll@40 {
>                                               #address-cells = <1>;
>                                               #size-cells = <0>;
>                                               #clock-cells = <0>;
> @@ -136,7 +136,7 @@
>                                               clocks = <&osc1>;
>                                               reg = <0x40>;
>  
> -                                             mpuclk: mpuclk {
> +                                             mpuclk: mpuclk@48 {
>                                                       #clock-cells = <0>;
>                                                       compatible = 
> "altr,socfpga-perip-clk";
>                                                       clocks = <&main_pll>;

Neither do these, actually. So we have clock at fixed addresses. Why
is it wrong?

> @@ -742,7 +742,7 @@
>                       reg = <0xffd05000 0x1000>;
>               };
>  
> -             usbphy0: usbphy@0 {
> +             usbphy0: usbphy {
>                       #phy-cells = <0>;
>                       compatible = "usb-nop-xceiv";
>                       status = "okay";

And this sounds like a bug waiting to happen..

Best regards,
                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to