On Wed, 21 Aug 2024 14:54:40 GMT, Simon Tooke <sto...@openjdk.org> wrote:

>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) 
>> to Windows.
>> 
>> System.map and System.dump_map are implemented using the Windows API and 
>> provide roughly the same information in the same format.  Most of the heavy 
>> lifting was implemented by @tstuefe in #16301 - this PR adds the Windows 
>> implementation and enables the common code for Windows 64 bit.
>>  
>> [Sample output (with NMT 
>> enabled)](https://github.com/user-attachments/files/16663332/vm_memory_map_760.txt)
>
> Simon Tooke has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   debug copilation error fix

> I think `test/jdk/sun/tools/jcmd/TestJcmdPIDSubstitution.java` should be 
> updated to allow System.dump_map on Windows, not just linux.
> 
> [6733b89](https://github.com/openjdk/jdk/commit/6733b89de1ed9ebcc1e8a8271970048ad0f0aac3)

Make sense. Should work out of the box. @stooke this is a test Sonia added some 
weeks ago, see https://bugs.openjdk.org/browse/JDK-8334492

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20597#issuecomment-2304118446

Reply via email to