On Thu, 22 Aug 2024 16:28:19 GMT, Simon Tooke <sto...@openjdk.org> wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 162: >> >>> 160: outputStream* st = session.out(); >>> 161: os::print_os_info(st); >>> 162: os::print_memory_info(st); >> >> The "danger" here is that both of these functions may bloat in the future >> and print a lot more than today; and that we may want to use this printout >> in places where we also print out OS info and memory info, and therefore get >> duplicated printout (e.g. hs-err printing or jcmd VM.info). >> >> But I would print out the number of mappings you counted, and the total size >> of committed regions. > > I have rolled my own "print_os_info" from the utility functions, but have > left print_memory_info in for now - if you want, I will remove it entirely, > but I think the information provided is valuable to readers of this report. I've also printed the region count. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1733427765
