On Thu, 22 Aug 2024 15:59:25 GMT, Simon Tooke <sto...@openjdk.org> wrote:

>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) 
>> to Windows.
>> 
>> System.map and System.dump_map are implemented using the Windows API and 
>> provide roughly the same information in the same format.  Most of the heavy 
>> lifting was implemented by @tstuefe in #16301 - this PR adds the Windows 
>> implementation and enables the common code for Windows 64 bit.
>>  
>> [Sample output (with NMT 
>> enabled)](https://github.com/user-attachments/files/16663332/vm_memory_map_760.txt)
>
> Simon Tooke has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - fix test failure
>  - enabled TestJcmdPIDSubstitution.java test for Windows

Still good

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20597#pullrequestreview-2256968537

Reply via email to