On Wed, 21 Aug 2024 12:32:00 GMT, Simon Tooke <sto...@openjdk.org> wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 1207: >> >>> 1205: const char* absname = os::Posix::realpath(name, tmp, sizeof(tmp)); >>> 1206: name = absname != nullptr ? absname : name; >>> 1207: #endif >> >> I wince a bit a the new ifdefs. Possibly for a separate RFE, it would be >> nice to have a function os::realpath() that uses realpath(2) on POSIX >> platforms, _fullpath on Windows. > > I agree, and was surprised this wasn't originally implemented. I'll prepare > a second PR. I have filed issue [#8338851](https://bugs.openjdk.org/browse/JDK-8338851) "Hoist os::Posix::realpath() to os::realpath() and implement on Windows" and will submit a PR shortly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1727460486
