Re: OpenId and Oauth

2011-02-16 Thread Yuri Zelikov
OAuth authentication is implemented to allow programmatic access to user data via Data API. http://code.google.com/apis/wave/wavedata/ On Thu, Feb 17, 2011 at 1:11 AM, Jeremy LeBard wrote: > Hi All, > > I can't find documentation on the security authentication models for Apache > Wave current an

Re: Code review request using Upload.py

2011-02-17 Thread Yuri Zelikov
I had this error using request_codereview when I tried to specify a message using '-m'. Try to submit the patch initially without a message, the script will ask you to enter the message anyway before uploading. On Thu, Feb 17, 2011 at 7:07 PM, Monami Sharma wrote: > Hi > Thanks for replying

Another WIAB demo instance.

2011-02-21 Thread Yuri Zelikov
Hi All. Whoever interested there's another federated Wave in a Box demo server running on waveinabox.net:9898. I enabled accounts and waves persistence so this instance can serve as more stable demo without daily accounts and waves wipe outs (still this is only a demo server and data wipe outs can

Re: GSoC projects?

2011-03-11 Thread Yuri Zelikov
The patch that enables public waves is already under review, so I hope it's a matter of days until public waves will be available. On Fri, Mar 11, 2011 at 10:42 PM, Peter Escamilla Mahecha < pescamil...@gmail.com> wrote: > If you ask for votes, I would like the personal tags (I use a lot the save

Re: GSoC projects?

2011-03-28 Thread Yuri Zelikov
I am not sure, but as far as I could understand - we already missed the deadline for ideas submissions. And even if not so, each idea should be submitted by a would be mentor that is ready to spend 3-5 hours per week for guiding the student. So unless there are commiters that are interested to bec

Re: need a starting point

2011-03-29 Thread Yuri Zelikov
Hi Glacomo I think a good starting point would be to visit the Google Wave API documentation - http://code.google.com/apis/wave/ . Almost all of it still relevant also for Wave in a Box. Also you can checkout the Splash and microwave projects and see how they work. Splash: svn checkout https://goog

Re: need a starting point

2011-03-29 Thread Yuri Zelikov
es ... > > Something more learning-oriented would be very appreciated ... > > Il giorno 29/mar/2011, alle ore 21.52, Yuri Zelikov ha scritto: > > > Hi Glacomo > > I think a good starting point would be to visit the Google Wave API > > documentation - http://code.

Re: Review Request: Jetty updated to version 8, socketio patched and socket/socketio workaround

2011-10-21 Thread Yuri Zelikov
sit: > https://reviews.apache.org/r/2533/ > --- > > (Updated 2011-10-21 22:38:53) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > New chrome (14, 15) use the new websocket sp

Re: Review Request: Jetty updated to version 8, socketio patched and socket/socketio workaround

2011-10-22 Thread Yuri Zelikov
13:42) > > > Review request for wave, Yuri Zelikov, Tad Glines, soren, and Nelson Silva. > > > Summary > --- > > New chrome (14, 15) use the new websocket specification that is not support > by socketio-java (that uses socket-io.js 0.6). > > As a temporal

Re: Review Request: Jetty updated to version 8, socketio patched and socket/socketio workaround

2011-10-23 Thread Yuri Zelikov
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2533/ > --- > > (Updated 2011-10-23 01:50:32) > > >

Re: Review Request: Jetty updated to version 8, socketio patched and socket/socketio workaround

2011-10-25 Thread Yuri Zelikov
automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2533/ > --- > > (Updated 2011-10-24 14:39:57) > > > Review request for wave, Yuri Zelikov, Tad Glines, soren, and Nelson Silva. >

Re: Review Request: Jetty updated to version 8, socketio patched and socket/socketio workaround

2011-10-25 Thread Yuri Zelikov
> Review request for wave, Yuri Zelikov, Tad Glines, soren, and Nelson Silva. > > > Summary > --- > > New chrome (14, 15) use the new websocket specification that is not support > by socketio-java (that uses socket-io.js 0.6). > > As a temporal solut

Review Request: Improves persistence logic and addresses some old TODOs

2011-10-30 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2632/ --- Review request for wave, Michael MacFadd, vjrj, and soren. Summary --- Impr

Re: Review Request: Improves persistence logic and addresses some old TODOs

2011-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2632/ --- (Updated 2011-11-01 17:58:03.331152) Review request for wave, Michael MacFadd, v

Re: Review Request: Jetty updated to version 8, socketio patched and socket/socketio workaround

2011-11-01 Thread Yuri Zelikov
> On 2011-10-25 20:17:22, Yuri Zelikov wrote: > > Committed revision 117. Please close the review. - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2533/#r

Review Request: Improves persistence logic and addresses some old TODOs - Part 2 (delta eviction)

2011-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2662/ --- Review request for wave, Michael MacFadd and soren. Summary --- Improves pe

Re: Review Request: Improves persistence logic and addresses some old TODOs - Part 2 (delta eviction)

2011-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2662/ --- (Updated 2011-11-01 20:07:26.165806) Review request for wave, Michael MacFadd an

Re: Review Request: Improves persistence logic and addresses some old TODOs - Part 2 (delta eviction)

2011-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2662/ --- (Updated 2011-11-01 20:10:05.372946) Review request for wave, Michael MacFadd an

Re: Review Request: Improves persistence logic and addresses some old TODOs - Part 2 (delta eviction)

2011-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2662/ --- (Updated 2011-11-01 20:16:43.783381) Review request for wave, Michael MacFadd an

Re: Review Request: Improves persistence logic and addresses some old TODOs - Part 2 (delta eviction)

2011-11-15 Thread Yuri Zelikov
weeks and seems to work OK, so unless anyone objects during the next 24 hours I am going to commit it. Off course comments can be accepted also after that addressed and subsequent patches. - Yuri On 2011-11-01 20:16:43, Yuri Zelikov wrote

Review Request: Reduces response buffer size used by implementations of AbstractWaveSocketIOServlet. issue WAVE-302.

2011-11-18 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2878/ --- Review request for wave, Michael MacFadd and Tad Glines. Summary --- It see

Review Request: Refactors the SearchService related classes to allow easier integration of alternative search provider

2011-11-19 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2882/ --- Review request for wave, Michael MacFadd and Tad Glines. Summary --- Refact

Re: Review Request: Refactors the SearchService related classes to allow easier integration of alternative search provider

2011-11-22 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2882/ --- (Updated 2011-11-22 19:13:17.845982) Review request for wave, Michael MacFadden,

Review Request: Adds support for the onGadgetStateChanged event to the Robot API

2011-11-23 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2928/ --- Review request for wave, Michael MacFadden and vjrj. Summary --- Adds suppo

Re: Review Request: Refactors the SearchService related classes to allow easier integration of alternative search provider

2011-11-25 Thread Yuri Zelikov
patch. - Yuri On 2011-11-22 19:13:17, Yuri Zelikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2882/ > --

Re: Review Request: Reverts back encoding fix that was accidently renmoved by 44df3b71b7aaca2480d4b8e6ed3b20ec7e70caee

2011-11-25 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2911/ --- (Updated 2011-11-25 15:54:26.263938) Review request for wave and vjrj. Summary

Review Request: Fixes bad dependency from org.waveprotocol.wave to org.waveprotocol.box - issue WAVE-306

2011-11-26 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2935/ --- Review request for wave and Christian Ohler. Summary --- Fixes https://issu

Re: Review Request: WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

2011-11-26 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3515 --- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.

Re: Review Request: WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

2011-11-26 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 --- Ship it! Thanks for contributing to the Apache Wave project. Besides

Re: Review Request: Fixes bad dependency from org.waveprotocol.wave to org.waveprotocol.box - issue WAVE-306

2011-11-26 Thread Yuri Zelikov
I also wasn't sure if it worth to keep the methods or maybe just use directly the methods in GwtWaverefEncoder. Maybe move them into a new HistorySupportUtil class? - Yuri --- This is an automatically gener

Review Request: Fixes several unit test failures described in issue WAVE-303

2011-11-26 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2936/ --- Review request for wave. Summary --- Fixes several unit test failures descr

Re: Review Request: WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

2011-11-26 Thread Yuri Zelikov
> On 2011-11-26 10:12:55, Yuri Zelikov wrote: > > Thanks for contributing to the Apache Wave project. Besides minor comments > > this patch LGTM. > > I will address the comments by myself and commit if it's OK with you. > > Antonio Bello wrote: > Yeah su

Re: Review Request: WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

2011-11-26 Thread Yuri Zelikov
> On 2011-11-26 10:12:55, Yuri Zelikov wrote: > > Thanks for contributing to the Apache Wave project. Besides minor comments > > this patch LGTM. > > I will address the comments by myself and commit if it's OK with you. > > Antonio Bello wrote: > Yeah su

Re: Review Request: Implement WAVE-142 sub/super clearing

2011-12-07 Thread Yuri Zelikov
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3033/ > --- > > (Updated 2011-12-06 21:22:30) > > > Re

Review Request: Changes default WIAB configuration to use persistence + Updates README file with updated instructions and more info.

2011-12-09 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3094/ --- Review request for wave and Michael MacFadden. Summary --- Changes default

Re: Review Request: Changes default WIAB configuration to use persistence + Updates README file with updated instructions and more info.

2011-12-09 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3094/ --- (Updated 2011-12-09 11:19:15.142238) Review request for wave and Michael MacFadd

Review Request: Addresses TODO to move the thread counts from the code into server.config properties.

2011-12-09 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3128/ --- Review request for wave and Michael MacFadden. Summary --- Addresses TODO t

Re: Review Request: Changes default WIAB configuration to use persistence + Updates README file with updated instructions and more info.

2011-12-10 Thread Yuri Zelikov
moved. - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3094/#review3824 --- On 2011-12-09 11:19:15, Yur

Re: Review Request: Changes default WIAB configuration to use persistence + Updates README file with updated instructions and more info.

2011-12-10 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3094/ --- (Updated 2011-12-10 14:41:26.263548) Review request for wave and Michael MacFadd

Re: Review Request: Fixes bad dependency from org.waveprotocol.wave to org.waveprotocol.box - issue WAVE-306

2011-12-10 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2935/ --- (Updated 2011-12-10 17:38:36.590638) Review request for wave and Christian Ohler

Re: Review Request: Implement WAVE-142 sub/super clearing

2011-12-11 Thread Yuri Zelikov
> On 2011-12-07 17:31:21, Yuri Zelikov wrote: > > LGTM Can you please close this review request? - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3033/#r

Re: Review Request: Implement WAVE-313: registration disabling

2011-12-22 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4097 --- /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java

Re: Review Request: Implement WAVE-275 Auto-linker

2011-12-24 Thread Yuri Zelikov
1:27, Ali Lown wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3294/ > ------- > > (Updated 2011-12-23

Re: Review Request: Implement WAVE-275 Auto-linker

2011-12-30 Thread Yuri Zelikov
==" operator instead of equals() method? - Yuri On 2011-12-23 23:01:27, Ali Lown wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3294/ > -----

Re: Review Request: Implement WAVE-313: registration disabling

2011-12-31 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4161 --- /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.jav

Review Request: Fixes failing test - issue WAVE-308

2011-12-31 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3338/ --- Review request for wave and Michael MacFadden. Summary --- Fixes failing te

Re: Review Request: Implement WAVE-313: registration disabling

2012-01-07 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4235 --- Ship it! Committed as r1228584. Thanks for the effort! Please close t

Re: Review Request: Add an extra date formatting category between same day and same year

2012-01-08 Thread Yuri Zelikov
51:01) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > --- > > This is at a friend's (user) request: > It adds an extra fidelity for the wave client date formatting functions (used > in blip displaying and in the w

Re: Review Request: Implement fix for WAVE-321 to prevent a complete crash when only a delta corruption issue occurs

2012-01-08 Thread Yuri Zelikov
://reviews.apache.org/r/3432/ > --- > > (Updated 2012-01-08 23:28:50) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > --- > > Nothing exciting in this patch, just prevents the length being processed a

Re: Review Request: Correct url to favicon on authentication page

2012-01-11 Thread Yuri Zelikov
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3438/ > --- > > (Updated 2012-01-09 17:48:06) > > > Re

Re: Review Request: Add an extra date formatting category between same day and same year

2012-01-11 Thread Yuri Zelikov
> Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > --- > > This is at a friend's (user) request: > It adds an extra fidelity for the wave client date formatting functions (used > in blip displaying and in the wave listing), for waves cre

Re: Review Request: Correct url to favicon on authentication page

2012-01-11 Thread Yuri Zelikov
> On 2012-01-11 19:08:15, Yuri Zelikov wrote: > > LGTM Committed as r1230205 - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3438/#r

Re: Review Request: Fixes failing test - issue WAVE-308

2012-01-13 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3338/ --- (Updated 2012-01-13 13:32:58.074069) Review request for wave, Michael MacFadden

Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-14 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/ --- Review request for wave, Michael MacFadden and Lennard de Rijk. Summary ---

Re: Review Request: Print wave title in blue bar and page title

2012-01-16 Thread Yuri Zelikov
(Updated 2012-01-16 21:23:00) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > --- > > For waves with a title determined by the existing WaveTitleHandler code, this > renders it in the page's html title tag and in the blue

Re: Review Request: Implement fix for WAVE-321 to prevent a complete crash when only a delta corruption issue occurs

2012-01-16 Thread Yuri Zelikov
e.org/r/3432/ > --- > > (Updated 2012-01-16 21:46:20) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > --- > > Nothing exciting in this patch, just prevents the length being proce

Re: Review Request: Implement fix for WAVE-321 to prevent a complete crash when only a delta corruption issue occurs

2012-01-16 Thread Yuri Zelikov
> On 2012-01-16 21:55:27, Yuri Zelikov wrote: > > If it lets the server to continue with loading - it LGTM. But maybe need to > > open another issue to prevent this condition to happen. Committed as r1232186. Thanks! Please close the review re

Re: Review Request: Print wave title in blue bar and page title

2012-01-17 Thread Yuri Zelikov
> On 2012-01-16 21:39:13, Yuri Zelikov wrote: > > Hmm, I think I already implemented something like this for waveinabox.net > > as experimental feature. But then I removed all experimental features. And > > I didn't bother to submit it later... Too b

Re: Review Request: WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

2012-01-18 Thread Yuri Zelikov
> On 2011-11-26 10:12:55, Yuri Zelikov wrote: > > Thanks for contributing to the Apache Wave project. Besides minor comments > > this patch LGTM. > > I will address the comments by myself and commit if it's OK with you. > > Antonio Bello wrote: > Yeah su

Review Request: Sets the current wave title also as the browser window title

2012-01-18 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/ --- Review request for wave, Michael MacFadden and Ali Lown. Summary --- Sets t

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-18 Thread Yuri Zelikov
s. But I am OK with extending LifecycleListener too, let me know if you still prefer this option. - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/#review4442 -------

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-19 Thread Yuri Zelikov
che.org/r/3530/#review4447 --- On 2012-01-18 19:45:01, Yuri Zelikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-19 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/ --- (Updated 2012-01-19 20:11:38.548936) Review request for wave, Michael MacFadden

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-19 Thread Yuri Zelikov
/WindowTitleHandler.java <https://reviews.apache.org/r/3530/#comment10046> done - Yuri On 2012-01-19 20:11:38, Yuri Zelikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-19 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/ --- (Updated 2012-01-19 20:49:33.627593) Review request for wave, Michael MacFadden

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-19 Thread Yuri Zelikov
server/waveserver/MemorySearchProviderTest.java <https://reviews.apache.org/r/3508/#comment10058> Done - Yuri On 2012-01-19 20:49:33, Yuri Zelikov wrote: > > --- > This is an automatically g

Re: Review Request: Import GWave waves to Wiab.

2012-01-20 Thread Yuri Zelikov
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > --- > > (Updated 2012-01-20 13:48:50) > > > Review req

Re: Review Request: Sets the current wave title also as the browser window title

2012-01-20 Thread Yuri Zelikov
ut I don't see that it us used anywhere outside > > of this class. done - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/#review4442

Review Request: Removes blip auto focus and adds blip navigation buttons to the wave view toolbar instead.

2012-01-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3577/ --- Review request for wave, Michael MacFadden, vjrj, and Ali Lown. Summary ---

Review Request: Returns the buffer size back to 1MB

2012-01-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3578/ --- Review request for wave, Michael MacFadden, vjrj, and Ali Lown. Summary ---

Re: Review Request: Returns the buffer size back to 1MB

2012-01-22 Thread Yuri Zelikov
//reviews.apache.org/r/3578/#review4512 --- On 2012-01-21 16:09:06, Yuri Zelikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request: Removes blip auto focus and adds blip navigation buttons to the wave view toolbar instead.

2012-01-22 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3577/#review4523 --- Committed as revision 1234538 - Yuri On 2012-01-21 15:59:13, Yuri

Re: Review Request: Returns the buffer size back to 1MB

2012-01-22 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3578/#review4524 --- Committed as revision 1234540 - Yuri On 2012-01-21 16:09:06, Yuri

Re: Review Request: Import GWave waves to Wiab.

2012-01-23 Thread Yuri Zelikov
o reply, visit: > https://reviews.apache.org/r/3564/ > --- > > (Updated 2012-01-23 08:51:37) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > Exports waves from GWave to f

Re: Review Request: Add SSL serving capabilites

2012-01-23 Thread Yuri Zelikov
y, visit: > https://reviews.apache.org/r/3584/ > --- > > (Updated 2012-01-22 22:57:25) > > > Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Summary > --- > > Adds SSL capabilities as: > > - Adds 3 new config options (globally en

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-27 Thread Yuri Zelikov
there will be no more comments during next 24 hours I ll consider it as "LGTM" :) - Yuri On 2012-01-19 20:49:33, Yuri Zelikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request: Import GWave waves to Wiab.

2012-01-27 Thread Yuri Zelikov
rc/org/waveprotocol/box/waveimport/google/google-import.proto <https://reviews.apache.org/r/3564/#comment10370> Why do we nee this proto? Do we compile it into corresponding java class? - Yuri On 2012-01-26 11:34:03, Andrew Kaplanov wrote: > > --- > This is an automatically generated e-mail

Re: Review Request: Import GWave waves to Wiab.

2012-01-27 Thread Yuri Zelikov
sit: > https://reviews.apache.org/r/3564/ > --- > > (Updated 2012-01-26 11:34:03) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > Exports waves from GWave to files, and imports t

Re: Review Request: Import GWave waves to Wiab.

2012-01-28 Thread Yuri Zelikov
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > --- > > (Updated 2012-01-28 04:58:44) > > > Review request for wave and Yuri Zelikov. > > > Summary > -

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-28 Thread Yuri Zelikov
commit comments, I ll work to address them in subsequent patch. - Yuri On 2012-01-19 20:49:33, Yuri Zelikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apach

Re: Review Request: Import GWave waves to Wiab.

2012-01-29 Thread Yuri Zelikov
ated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > --- > > (Updated 2012-01-28 04:58:44) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > Exports waves

Re: Review Request: Some user-suggested usability tweaks

2012-01-31 Thread Yuri Zelikov
d 2012-01-31 21:47:45) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > --- > > This is a few minor changes based on user feedback from my server. > > - Makes the WIAB logo on the client page link back to the domain root (like > ev

Re: Review Request: Makes focusNext go back up a wave too

2012-02-02 Thread Yuri Zelikov
01 22:18:20) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > After feedback from users pressing 'space' or clicking the 'next unread' > button, they wondered why it only went down the wave when pressed. > The '

Re: Review Request: Link WIAB icon to homepage

2012-02-02 Thread Yuri Zelikov
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3728/ > --- > > (Updated 2012-02-01 22:12:49) > > > Re

Re: Review Request: Add SSL serving capabilites

2012-02-02 Thread Yuri Zelikov
/reviews.apache.org/r/3584/ > --- > > (Updated 2012-02-01 22:42:14) > > > Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Summary > --- > > Adds SSL capabilities as: > > - Add

Re: Review Request: Import GWave waves to Wiab.

2012-02-03 Thread Yuri Zelikov
iews.apache.org/r/3564/ > --- > > (Updated 2012-02-03 09:59:29) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > The implem

Review Request: Make attachment links URL be relative instead of absolute.

2012-02-03 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3753/ --- Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. Summa

Review Request: Sets webscocket connection timeout idle time to infinity

2012-02-03 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3754/ --- Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. Summa

Re: Review Request: Sets webscocket connection timeout idle time to infinity

2012-02-03 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3754/#review4807 --- Committed as r1240250. - Yuri On 2012-02-03 12:09:46, Yuri Zelikov

Re: Review Request: Add SSL serving capabilites

2012-02-03 Thread Yuri Zelikov
To reply, visit: > https://reviews.apache.org/r/3584/ > --- > > (Updated 2012-02-01 22:42:14) > > > Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Summary > --- > > Adds

Re: Review Request: Import GWave waves to Wiab.

2012-02-04 Thread Yuri Zelikov
views.apache.org/r/3564/ > --- > > (Updated 2012-02-03 09:59:29) > > > Review request for wave and Yuri Zelikov. > > > Summary > --- > > Exports waves from GWave to files, and imports them to Wiab by

Re: Review Request: Import GWave waves to Wiab.

2012-02-06 Thread Yuri Zelikov
e.org/r/3564/#comment10633> Consider using the split() method of String instead of StringTokenizer - Yuri On 2012-02-06 08:08:26, Andrew Kaplanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > -

Re: Review Request: Add SSL serving capabilites

2012-02-06 Thread Yuri Zelikov
n automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3584/ > --- > > (Updated 2012-02-05 22:16:10) > > > Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Su

Re: Review Request: Add SSL serving capabilites

2012-02-06 Thread Yuri Zelikov
16:10) > > > Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Summary > --- > > Adds SSL capabilities as: > > - Adds 3 new config options (globally enable ssl, keystore, keystore password) > - Changes to use the SSLSelectChannelConnect

Re: Review Request: Add SSL serving capabilites

2012-02-06 Thread Yuri Zelikov
> Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Summary > --- > > Adds SSL capabilities as: > > - Adds 3 new config options (globally enable ssl, keystore, keystore password) > - Changes to use the SSLSelectChannelConnector if neede

Re: Review Request: Swap location of 'Next' and 'Previous' blip buttons on ViewToolbar

2012-02-06 Thread Yuri Zelikov
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3730/ > --- > > (Updated 2012-02-01 22:21:51) > > > Re

Re: Review Request: Swap location of 'Next' and 'Previous' blip buttons on ViewToolbar

2012-02-06 Thread Yuri Zelikov
> On 2012-02-06 18:49:48, Yuri Zelikov wrote: > > LGTM Committed as r1241108 - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3730/#r

Re: Review Request: Fix to WAVE-328.

2012-02-07 Thread Yuri Zelikov
; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3771/ > --- > > (Updated 2012-02-07 11:13:34) > > > Review request for wave and Yuri Zelikov. > > > Summary >

Re: Review Request: Makes focusNext go back up a wave too

2012-02-07 Thread Yuri Zelikov
> On 2012-02-02 08:46:23, Yuri Zelikov wrote: > > /src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java, > > line 208 > > <https://reviews.apache.org/r/3729/diff/1/?file=71720#file71720line208> > > > > Another possibility is

Re: Review Request: Makes focusNext go back up a wave too

2012-02-07 Thread Yuri Zelikov
> On 2012-02-02 08:46:23, Yuri Zelikov wrote: > > /src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java, > > line 208 > > <https://reviews.apache.org/r/3729/diff/1/?file=71720#file71720line208> > > > > Another possibility is

  1   2   3   4   5   >