> On 2011-11-26 10:12:55, Yuri Zelikov wrote: > > Thanks for contributing to the Apache Wave project. Besides minor comments > > this patch LGTM. > > I will address the comments by myself and commit if it's OK with you. > > Antonio Bello wrote: > Yeah sure - thanks for "fixing" my code. I think I still have to read > some rules and conventions about how to write code and how to submit it. > Also, I plan to give my contribution to this project on a regular basis, > watching and trying to solve issues at beginning, but I'd like to get more > involved in development at a later stage, when I'll have a better > understanding of the architecture. > > Antonio > > Yuri Zelikov wrote: > This is great, thanks! > > Antonio Bello wrote: > My pleasure :) > I'm a bit confused about what repository to use... svn, git@apache, > git@github? I wouldn't want I work on the wrong one
For getting the latest code you can use either the SVN repository or the Git mirror SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/ Git mirror: git://git.apache.org/wave.git If you feel ready to submit a patch - then just use this Review Board for this. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2932/ > ----------------------------------------------------------- > > (Updated 2011-11-25 18:23:15) > > > Review request for wave. > > > Summary > ------- > > This patch solves the problem in my case. > > I'm running ubuntu x64, and experienced the same problem. > > What I did is simply change the parameter type passed to the thenReturn() > method: > * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest > * replace ImmutableMap.of() with new Hashtable<String, String[]>() in > DataApiServletTest > > > This addresses bug WAVE-298. > https://issues.apache.org/jira/browse/WAVE-298 > > > Diffs > ----- > > /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java > 1206126 > /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java > 1206126 > > Diff: https://reviews.apache.org/r/2932/diff > > > Testing > ------- > > ant test runs with no errors on ubuntu x64 10.04 > > > Thanks, > > Antonio > >
