I had this error using request_codereview when I tried to specify a message using '-m'. Try to submit the patch initially without a message, the script will ask you to enter the message anyway before uploading.
On Thu, Feb 17, 2011 at 7:07 PM, Monami Sharma <monami.sha...@gmail.com>wrote: > Hi > Thanks for replying ! But I also tried without commit! For that purpose > I created a fresh clone and just overwrote my changed file and this time > did > not commit ! > Still same message.Hg Diff shows the proper differences but script doest > run > properly! > > I am trying following command(tried both,with --rev and without rev) > > upload.py -s=http://codereview.waveprotocol.org-e=monami.sha...@gmail.com-r > = > zdw...@google.com,so...@google.com,hearn...@google.com --cc= > wave-protocol-code-disc...@googlegroups.com -d=Null check added before > performing any operation on "frameUrl" and "gadget.get("userPrefs")" > objects > --send_mail --rev=711 > > Thanks > Monami > > On Thu, Feb 17, 2011 at 10:56 AM, Lennard de Rijk <ljvder...@gmail.com > >wrote: > > > Hi Monami, > > > > Please read [0] for a tutorial on submitting code. Basically hg diff > won't > > show you anything but there is no diff against your own head (since you > did > > a commit), you would need to specify the revision as is indicated in [0]. > If > > the hg commit is the last transactional thing you did you should be able > to > > perform "hg rollback" which would make hg diff show what you need again > :). > > > > Greetings, > > Lennard > > > > [0] http://www.waveprotocol.org/code/submitting-code > > > > > > On Thu, Feb 17, 2011 at 16:52, Monami Sharma <monami.sha...@gmail.com > >wrote: > > > >> Hello > >> I am developing on WinXP and trying to use Upload.py for code > >> review request but I keep on getting following message : > >> > >> "No valid patches found in output from hg diff" > >> > >> I have committed my changes and it shows in the hg log and also I am > able > >> to "hg export" with proper header and diffs. > >> > >> I am not sure what I am missing ! Please help! > >> > >> Attached is the diff file I generated using hg export and it shows all > my > >> changes. > >> > >> Thanks in advance > >> Monami Sharma > >> > >> > >> > >> > >> > >> > >> > >> > >> On Thu, Feb 17, 2011 at 5:30 AM, <wave-proto...@googlecode.com> wrote: > >> > >>> > >>> Comment #3 on issue 166 by vega113: Client shiny on broken gadget (Good > >>> First Timer Project) > >>> http://code.google.com/p/wave-protocol/issues/detail?id=166 > >>> > >>> Great. Send a patch for review according to instructions at: > >>> http://www.waveprotocol.org/code/submitting-code > >>> Make sure to add also hearn...@google.com as reviewer. > >>> > >>> -- > >>> You received this message because you starred the issue. > >>> You may adjust your notification preferences at: > >>> https://code.google.com/hosting/settings > >>> > >>> Reply to this email to add a comment. > >>> > >> > >> > >> > >> -- > >> Regards > >> Monami Sharma > >> > >> > > > > > -- > Regards > Monami Sharma >
