----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 -----------------------------------------------------------
Ship it! Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. I will address the comments by myself and commit if it's OK with you. - Yuri On 2011-11-25 18:23:15, Antonio Bello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2932/ > ----------------------------------------------------------- > > (Updated 2011-11-25 18:23:15) > > > Review request for wave. > > > Summary > ------- > > This patch solves the problem in my case. > > I'm running ubuntu x64, and experienced the same problem. > > What I did is simply change the parameter type passed to the thenReturn() > method: > * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest > * replace ImmutableMap.of() with new Hashtable<String, String[]>() in > DataApiServletTest > > > This addresses bug WAVE-298. > https://issues.apache.org/jira/browse/WAVE-298 > > > Diffs > ----- > > /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java > 1206126 > /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java > 1206126 > > Diff: https://reviews.apache.org/r/2932/diff > > > Testing > ------- > > ant test runs with no errors on ubuntu x64 10.04 > > > Thanks, > > Antonio > >
