> On 2011-12-22 22:25:41, Patrick Coleman wrote: > > Nice work - the framework stuff is great, though this looks like it'd be > > rather slow on a client with a large blip document; > > can it be made faster? The editor update event should come with flags > > (content changes / cursor changed etc) so only ones where the content > > changed > > need to be inspected, and for those, only the content around the cursor > > (which should also be available) need be inspected. > > Ali Lown wrote: > I wasn't aware of this contextual information being available. (I agree > that the current implementation could get quite slow with _very_ big > documents. (Not sure how often it would be found in practice (excluding > mobile clients)). > > Ali Lown wrote: > Looking at EditorContext (the information passed by > EditorUpdateListener.onUpdate), I don't appear to be able to retrieve the > location of the changes (only of a selection), just a few boolean flags to > state that the content has cahnged.
Take a look at EditToolbar#insertGadget method - you can find there example on how to find the location of current change. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3294/#review4088 ----------------------------------------------------------- On 2011-12-23 23:01:27, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3294/ > ----------------------------------------------------------- > > (Updated 2011-12-23 23:01:27) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Implements an auto-linker feature as requested. > > This implementation works by splitting the data by the uri seperator "://" > and then attempting to match the scheme to a known (currently hard-coded > list) of schemes. The end is detected by either a space or EOL. > > This implementation allows any character to be before a valid scheme, but > relies upon a space or EOL to find the end. > > > This addresses bug WAVE-275. > https://issues.apache.org/jira/browse/WAVE-275 > > > Diffs > ----- > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java PRE-CREATION > /src/org/waveprotocol/wave/client/StageThree.java 1213039 > /src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java 1213039 > /src/org/waveprotocol/wave/client/doodad/link/Link.java 1213039 > > Diff: https://reviews.apache.org/r/3294/diff > > > Testing > ------- > > Tested manually by running the server and typing in URLs in various forms, as > well as by copy-pasting in. > > > Thanks, > > Ali > >
