> On 2012-01-18 21:29:49, Ali Lown wrote: > > LGTM. Though this doesn't appear to put the title in the waveFrame header > > which was the primary intention of my patch (which this is replacing). > > Could you extend it to do this?
That would require to pass the waveFrame to StagesProvider etc... I would prefer to accomplish it with subsequent patch to simplify the review. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/#review4447 ----------------------------------------------------------- On 2012-01-18 19:45:01, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3530/ > ----------------------------------------------------------- > > (Updated 2012-01-18 19:45:01) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Summary > ------- > > Sets the current wave title also as the browser window title. > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/client/StagesProvider.java 8a5355a > src/org/waveprotocol/wave/client/StageThree.java f31ed3b > src/org/waveprotocol/wave/client/doodad/title/TitleAnnotationHandler.java > e8b13f7 > src/org/waveprotocol/wave/client/scroll/ProxyScrollPanel.java 27e5da7 > src/org/waveprotocol/wave/client/wavepanel/WavePanel.java d1944b7 > src/org/waveprotocol/wave/client/wavepanel/impl/WavePanelImpl.java 282387e > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > b4f141b > > src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java > 1351987 > > src/org/waveprotocol/wave/client/wavepanel/impl/title/WindowTitleHandler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3530/diff > > > Testing > ------- > > Tested locally, verified that the wave title also set as browser window title. > > > Thanks, > > Yuri > >
