Re: [U-Boot] [PATCH 3/3]: arm: Kirkwood: See to it that sent data is 8-byte aligned

2009-08-17 Thread Simon Kagstrom
On Wed, 05 Aug 2009 23:08:16 +0200 Wolfgang Denk wrote: > In message <20090702150401.06ded...@marrow.netinsight.se> Simon > Kagstrom wrote: > > See to it that sent data is 8-byte aligned > > > > U-boot might use non-8-byte-aligned addresses for sending data, wh

Re: [U-Boot] [PATCH 3/8]: Define test_and_set/clear_bit for ARM

2009-08-17 Thread Simon Kagstrom
On Sun, 19 Jul 2009 11:47:13 +0200 Jean-Christophe PLAGNIOL-VILLARD wrote: > On 15:58 Tue 07 Jul , Simon Kagstrom wrote: > > Signed-off-by: Simon Kagstrom > > --- > > include/asm-arm/bitops.h |4 ++-- > > 1 files changed, 2 insertions(+), 2 deleti

[U-Boot] [PATCH 0/4]: bitops cleanup and fixes

2009-08-18 Thread Simon Kagstrom
Hi again! This patch series is an update to "[PATCH 0/8]: Fixes for ubifs build on ARM" sent in july: http://lists.denx.de/pipermail/u-boot/2009-July/055594.html and contains the patches which were not accepted. The patches are: 0001-Move-__set-clear_bit-from-ubifs.h-to-bitops.h.patch -

[U-Boot] [PATCH 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

2009-08-18 Thread Simon Kagstrom
code style (newline between __set_bit and __clear_bit) Signed-off-by: Simon Kagstrom --- fs/ubifs/ubifs.h | 32 include/asm-avr32/bitops.h |4 include/asm-m68k/bitops.h |4 include/asm-nios/bitops.h |4 include/asm-nios2/bit

Re: [U-Boot] [PATCH 2/4]: Define ffs/fls for all architectures

2009-08-18 Thread Simon Kagstrom
) Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h|4 include/asm-avr32/bitops.h |4 include/asm-i386/bitops.h |2 ++ include/asm-m68k/bitops.h |2 ++ include/asm-microblaze/bitops.h |2 ++ include/asm-mips/bitops.h |2

[U-Boot] [PATCH 3/4]: Remove duplicate set_cr

2009-08-18 Thread Simon Kagstrom
Remove duplicate set_cr set_cr is defined in both asm-arm/proc-armv/system.h and include/asm-arm/system.h. This patch removes it (and some duplicate defines) from the former. Signed-off-by: Simon Kagstrom --- include/asm-arm/proc-armv/system.h | 30 -- 1 files

[U-Boot] [PATCH 4/4]: Define test_and_set_bit and test_and_clear bit for ARM

2009-08-18 Thread Simon Kagstrom
Define test_and_set_bit and test_and_clear bit for ARM Needed for (e.g.) ubifs support to work. Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/include/asm-arm/bitops.h b/include/asm

[U-Boot] [PATCH] arm:kirkwood See to it that sent data is 8-byte aligned

2009-08-18 Thread Simon Kagstrom
from Stefan Roese) v3: No need to use jumbo frames, use 1518 bytes buffer instead (comment from Ben Warren) Signed-off-by: Simon Kagstrom --- drivers/net/kirkwood_egiga.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/driver

Re: [U-Boot] [PATCH] arm:kirkwood See to it that sent data is 8-byte aligned

2009-08-18 Thread Simon Kagstrom
Thanks for the review Prafulla! On Tue, 18 Aug 2009 03:12:07 -0700 Prafulla Wadaskar wrote: > > v2: Malloc send buffer (comment from Stefan Roese) > Malloc will always be an overhead. It's only allocated once (the first time a non-aligned buffer is passed), so the overhead is minimal. > I stro

[U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes

2009-08-19 Thread Simon Kagstrom
oot/2009-August/058829.html For other devices, I've setup send_alignment to 1. Signed-off-by: Simon Kagstrom --- board/MAI/AmigaOneG3SE/enet.c |1 + board/Marvell/db64360/mv_eth.c |1 + board/Marvell/db64460/mv_eth.c |1 + board/esd/cpci750/mv_eth.c |1 +

Re: [U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes

2009-08-19 Thread Simon Kagstrom
On Wed, 19 Aug 2009 15:36:04 +0800 "Liu Dave-R63238" wrote: > > Currently kirkwood_egiga.c has an 8-byte requirement. This patch is an > > alternative and replacement for "[PATCH] arm:kirkwood See to it that > > sent data is 8-byte aligned" sent here > > > > http://lists.denx.de/pipermail/u-bo

Re: [U-Boot] [PATCH] arm:kirkwood See to it that sent data is 8-byte aligned

2009-08-19 Thread Simon Kagstrom
On Tue, 18 Aug 2009 11:32:06 +0200 Simon Kagstrom wrote: > + /* Copy buffer if it's misaligned */ > if ((u32) dataptr & 0x07) { > - printf("Err..(%s) xmit dataptr not 64bit aligned\n", > - __FUNCTION__); > -

Re: [U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes

2009-08-19 Thread Simon Kagstrom
On Wed, 19 Aug 2009 16:06:12 +0800 "Liu Dave-R63238" wrote: > > Well, that's what the other patch I sent does (the link above), but > > there were wishes then to handle this above the driver layer, hence > > this patch :-) > > > > I'm fine with either way, but if there are other drivers with >

[U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on kirkwood network init

2009-08-19 Thread Simon Kagstrom
(before the link has come up). Signed-off-by: Simon Kagstrom --- drivers/net/kirkwood_egiga.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/net/kirkwood_egiga.c b/drivers/net/kirkwood_egiga.c index f31fefc..9ac9c1f 100644 --- a/drivers/net

Re: [U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes

2009-08-19 Thread Simon Kagstrom
On Wed, 19 Aug 2009 09:55:46 -0700 Ben Warren wrote: > My preference is for the drivers to handle alignment. OK, I'm fine with that. I'd like to withdraw this patch then. > I like Dave's idea of creating a buffer (or multiple buffers) in > initialization(), > then memcpy'ing to to it in the

[U-Boot] [PATCH v4] arm: kirkwood: See to it that sent data is 8-byte aligned

2009-08-20 Thread Simon Kagstrom
uffer instead v4: Correct alignment passed to memalign (should be 8!), allocate buffer at initialization(), use PKTSIZE_ALIGN Signed-off-by: Simon Kagstrom --- drivers/net/kirkwood_egiga.c | 21 + drivers/net/kirkwood_egiga.h |1 + 2 files changed, 18 insertions(

Re: [U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on kirkwood network init

2009-08-20 Thread Simon Kagstrom
On Wed, 19 Aug 2009 10:08:02 -0700 Ben Warren wrote: > > - u16 phyadr; > > - miiphy_read(dev->name, 0xEE, 0xEE, &phyadr); > > - if (!miiphy_link(dev->name, phyadr)) { > > - printf("%s: No link on %s\n", __FUNCTION__, dev->name); > > > Please use __func__ instead. It's defined

[U-Boot] [PATCH 3/3] [repost]: arm: kirkwood: See to it that sent data is 8-byte aligned

2009-08-20 Thread Simon Kagstrom
uffer instead v4: Correct alignment passed to memalign (should be 8!), allocate buffer at initialization(), use PKTSIZE_ALIGN Signed-off-by: Simon Kagstrom --- drivers/net/kirkwood_egiga.c | 21 + drivers/net/kirkwood_egiga.h |1 + 2 files changed, 18 insertions(

[U-Boot] [PATCH 2/3]: Wait for the link to come up on kirkwood network init

2009-08-20 Thread Simon Kagstrom
printout Signed-off-by: Simon Kagstrom --- drivers/net/kirkwood_egiga.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/kirkwood_egiga.c b/drivers/net/kirkwood_egiga.c index 065e335..9f36633 100644 --- a/drivers/net/kirkwood_egiga.c +++ b

[U-Boot] [PATCH 0/3]: arm:Kirkwood network driver fixes

2009-08-20 Thread Simon Kagstrom
Hi! Three patches to fix various network driver issues on kirkwood. Patch 3 is a repost of the patch sent earlier today which is rebased on top of the other two. // Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo

[U-Boot] [PATCH 1/3]: arm:kirkwood Define kirkwood phy address magic number

2009-08-20 Thread Simon Kagstrom
Signed-off-by: Simon Kagstrom --- drivers/net/kirkwood_egiga.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/kirkwood_egiga.c b/drivers/net/kirkwood_egiga.c index f31fefc..065e335 100644 --- a/drivers/net/kirkwood_egiga.c +++ b/drivers/net

Re: [U-Boot] [PATCH 2/4]: Define ffs/fls for all architectures

2009-08-20 Thread Simon Kagstrom
On Thu, 20 Aug 2009 01:11:09 +0200 Jean-Christophe PLAGNIOL-VILLARD wrote: > On 11:13 Tue 18 Aug , Simon Kagstrom wrote: > > Define ffs/fls for all architectures > > > > UBIFS requires fls(), which is not defined for arm (and some other > > architectures)

[U-Boot] [PATCH v2 0/4]: bitops cleanup and fixes

2009-08-20 Thread Simon Kagstrom
Hi again! This patch series is an update to "[PATCH 0/4]: bitops cleanup and fixes": http://article.gmane.org/gmane.comp.boot-loaders.u-boot/66184 and contains the patches which were not accepted. The patches are: 0001-Move-__set-clear_bit-from-ubifs.h-to-bitops.h.patch - Code style upd

[U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

2009-08-20 Thread Simon Kagstrom
r_bit) v3: Move BIT_MASK and BIT_WORD above the include of asm/bitops.h Signed-off-by: Simon Kagstrom --- fs/ubifs/ubifs.h | 32 include/asm-avr32/bitops.h |4 include/asm-m68k/bitops.h |4 include/asm-nios/bitops.h |4 in

[U-Boot] [PATCH v2 2/4]: Make arm bitops endianness-independent

2009-08-20 Thread Simon Kagstrom
Bring over the bitop implementations from the Linux include/asm-generic/bitops/non-atomic.h to provide endianness-independence. Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions

[U-Boot] [PATCH v2 3/4]: Define ffs/fls for all architectures

2009-08-20 Thread Simon Kagstrom
UBIFS requires fls(), which is not defined for arm (and some other architectures) and this patch adds it. The implementation is taken from Linux and is generic. ffs() is also defined for those that miss it. v2: Unify code style (empty line between ffs/fls) Signed-off-by: Simon Kagstrom

[U-Boot] [PATCH v2 4/4]: Define test_and_set_bit and test_and_clear bit for ARM

2009-08-20 Thread Simon Kagstrom
Needed for (e.g.) ubifs support to work. Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/include/asm-arm/bitops.h b/include/asm-arm/bitops.h index b3a9578..b62ff90 100644 --- a/include

Re: [U-Boot] [PATCH 1/3]: arm:kirkwood Define kirkwood phy address magic number

2009-08-20 Thread Simon Kagstrom
On Thu, 20 Aug 2009 02:40:48 -0700 Prafulla Wadaskar wrote: > > > > +#define KIRKWOOD_PHY_ADR_REQUEST 0xee > define this in header file > > Basically this is needed in drivers/net/phy/mv88e61xx.c for multi chip support > in this case we need to define this in include/miiphy.h. > which conflict

Re: [U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

2009-08-20 Thread Simon Kagstrom
On Thu, 20 Aug 2009 13:44:35 -0400 Mike Frysinger wrote: > On Thursday 20 August 2009 04:52:50 Simon Kagstrom wrote: > > --- a/include/asm-sh/bitops.h > > +++ b/include/asm-sh/bitops.h > > @@ -146,6 +146,11 @@ static inline int ffs (int x) > > } > > re

Re: [U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

2009-08-21 Thread Simon Kagstrom
On Fri, 21 Aug 2009 02:29:30 -0400 Mike Frysinger wrote: > > > this is just silly to put into every arch header. why not do in the > > > common code: > > > #ifndef __set_bit > > > # define __set_bit generice_set_bit > > > #endif > > > > It's a function (static inline) in some architectures. > >

[U-Boot] [PATCH v3 0/4]: bitops cleanup and fixes

2009-08-21 Thread Simon Kagstrom
Hi yet again! This patch series is an update to "[PATCH 0/4]: bitops cleanup and fixes": http://article.gmane.org/gmane.comp.boot-loaders.u-boot/66184 and contains the patches which were not accepted. The patches are: 0001-Move-__set-clear_bit-from-ubifs.h-to-bitops.h.patch - Code style

[U-Boot] [PATCH v3 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

2009-08-21 Thread Simon Kagstrom
code style (newline between __set_bit and __clear_bit) v3: Move BIT_MASK and BIT_WORD above the include of asm/bitops.h v4: Move the definition to generic code (Mike Frysinger) Signed-off-by: Simon Kagstrom --- fs/ubifs/ubifs.h| 32 include/as

[U-Boot] [PATCH v3 2/4]: arm: Make arm bitops endianness-independent

2009-08-21 Thread Simon Kagstrom
arm: Make arm bitops endianness-independent Bring over the bitop implementations from the Linux include/asm-generic/bitops/non-atomic.h to provide endianness-independence. v2: Use generic __set_bit and __clear_bit for ARM Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h | 47

[U-Boot] [PATCH v3 3/4]: Define ffs/fls for all architectures

2009-08-21 Thread Simon Kagstrom
/fls) v3: Move the definition to generic code (Mike Frysinger) Signed-off-by: Simon Kagstrom --- include/asm-i386/bitops.h |1 + include/asm-m68k/bitops.h |1 + include/asm-nios/bitops.h |1 + include/asm-nios2/bitops.h |1 + include/asm-ppc/bitops.h |2 + include/asm-sh

[U-Boot] [PATCH v3 4/4]: arm: Define test_and_set_bit and test_and_clear bit for ARM

2009-08-21 Thread Simon Kagstrom
arm: Define test_and_set_bit and test_and_clear bit for ARM Needed for (e.g.) ubifs support to work. Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) diff --git a/include/asm-arm/bitops.h b

Re: [U-Boot] [PATCH 1/3]: arm:kirkwood Define kirkwood phy address magic number

2009-08-21 Thread Simon Kagstrom
On Thu, 20 Aug 2009 20:20:08 -0700 Prafulla Wadaskar wrote: > > > > +#define KIRKWOOD_PHY_ADR_REQUEST 0xee > > > define this in header file > > > > > > Basically this is needed in drivers/net/phy/mv88e61xx.c for > > multi chip support > > > in this case we need to define this in include/miiphy.

[U-Boot] [PATCH v4 0/4]: bitops cleanup and fixes

2009-08-24 Thread Simon Kagstrom
Hi yet again! This update to the patch series just cleans up the commit messages to have the comments in the git comments section. // Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-08-24 Thread Simon Kagstrom
Define ffs/fls for all architectures UBIFS requires fls(), which is not defined for arm (and some other architectures) and this patch adds it. The implementation is taken from Linux and is generic. ffs() is also defined for those that miss it. Signed-off-by: Simon Kagstrom --- ChangeLog: v2

[U-Boot] [PATCH v4 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

2009-08-24 Thread Simon Kagstrom
ff-by: Simon Kagstrom --- ChangeLog: v2: Unify code style (newline between __set_bit and __clear_bit) v3: Move BIT_MASK and BIT_WORD above the include of asm/bitops.h v4: Move the definition to generic code (Mike Frysinger) fs/ubifs/ubifs.h|

[U-Boot] [PATCH v4 4/4]: arm: Define test_and_set_bit and test_and_clear bit for ARM

2009-08-24 Thread Simon Kagstrom
arm: Define test_and_set_bit and test_and_clear bit for ARM Needed for (e.g.) ubifs support to work. Signed-off-by: Simon Kagstrom --- include/asm-arm/bitops.h | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) diff --git a/include/asm-arm/bitops.h b

[U-Boot] [PATCH v4 2/4]: arm: Make arm bitops endianness-independent

2009-08-24 Thread Simon Kagstrom
arm: Make arm bitops endianness-independent Bring over the bitop implementations from the Linux include/asm-generic/bitops/non-atomic.h to provide endianness-independence. Signed-off-by: Simon Kagstrom --- ChangeLog: v2: Use generic __set_bit and __clear_bit for ARM include/asm-arm

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-08-24 Thread Simon Kagstrom
Hi, On Fri, 21 Aug 2009 23:12:45 +0200 Wolfgang Denk wrote: > For some time there have been repeated reports about build problems > with some ARM (cross) tool chains. Especially issues about > (in)compatibility with the tool chain provided runtime support > library libgcc.a caused to add and su

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-08-24 Thread Simon Kagstrom
On Mon, 24 Aug 2009 12:01:54 +0200 Wolfgang Denk wrote: > > I updated my git tree today and got this patch (among other things). It > > does not work very well for me, unfortunately. I've tried three > > toolchains (4.3.3, 4.3.4, 4.4.1) built with crosstool-ng, and all of > > them build an image

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-08-24 Thread Simon Kagstrom
On Mon, 24 Aug 2009 14:01:20 +0200 Wolfgang Denk wrote: > Please re-run the tests with > > $ USE_PRIVATE_LIBGCC=yes > $ export USE_PRIVATE_LIBGCC > $ make mrproper > $ make ..._config > $ make all > > and with > > $ unset USE_PRIVATE_LIBGCC > $ make mr

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-08-24 Thread Simon Kagstrom
On Mon, 24 Aug 2009 05:41:59 -0700 Prafulla Wadaskar wrote: > I get following erro only if I execute following build command > make mrproper; make sheevaplug_config; make USE_PRIVATE_LIBGCC=no > CROSS_COMPILE=armv5tel-redhat-linux-gnueabi- 2> warn.txt > > And cat warn.txt > armv5tel-redhat-linu

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-08-25 Thread Simon Kagstrom
On Mon, 24 Aug 2009 12:01:54 +0200 Wolfgang Denk wrote: > Dear Simon Kagstrom, > > In message <20090824105935.038bd...@marrow.netinsight.se> you wrote: > > > > I updated my git tree today and got this patch (among other things). It > > does not work very well

Re: [U-Boot] U-boot environment on Sheevaplug

2009-08-25 Thread Simon Kagstrom
Hi again! I just wanted to check if there has been any progress on the issue below (4-bit ECC support to read for the kernel / U-boot) during the summer. On Wed, 8 Jul 2009 15:59:27 +0200 Simon Kagstrom wrote: > Hi Prafulla (and the list)! > > I'm wondering a bit how Sheevaplug

Re: [U-Boot] [PATCH v4 0/4]: bitops cleanup and fixes

2009-08-31 Thread Simon Kagstrom
On Mon, 24 Aug 2009 09:06:05 +0200 Simon Kagstrom wrote: > This update to the patch series just cleans up the commit messages to > have the comments in the git comments section. Sorry to ping you all, but are there any more comments on work to be done before this patch series can be ac

Re: [U-Boot] [PATCH v3 4/4] tools: mkimage: Add: Kirkwood Boot Image support (kwbimage)

2009-09-03 Thread Simon Kagstrom
On Mon, 24 Aug 2009 23:03:59 +0530 Prafulla Wadaskar wrote: > This patch adds type kwbimabe support for new mkimage core > For more details refer docs/README.kwbimage > +Command syntax: > +-- > +./tools/mkimage -l > + to list the kwb image file details > + > +./tools/mki

Re: [U-Boot] U-boot environment on Sheevaplug

2009-09-04 Thread Simon Kagstrom
On Thu, 3 Sep 2009 23:20:02 -0700 Prafulla Wadaskar wrote: > > I just wanted to check if there has been any progress on the issue > > below (4-bit ECC support to read for the kernel / U-boot) during the > > summer. > > I am restarting work on this issue for u-boot, > Does anybody have any sugges

Re: [U-Boot] [PATCH v3 4/4] tools: mkimage: Add: Kirkwood Boot Image support (kwbimage)

2009-09-03 Thread Simon Kagstrom
Hi Prafulla! I see the complications and understand that it might be difficult to get it running. On Thu, 3 Sep 2009 07:15:48 -0700 Prafulla Wadaskar wrote: > > I think it could also be useful to be able to produce just the boot > > header without the U-boot image. For example if you want to pl

Re: [U-Boot] [PATCH v3 4/4] tools: mkimage: Add: Kirkwood Boot Image support (kwbimage)

2009-09-04 Thread Simon Kagstrom
On Fri, 4 Sep 2009 00:17:57 -0700 Prafulla Wadaskar wrote: > > I see the complications and understand that it might be difficult to > > get it running. > > So we can keep this complex enhancement for future updates, keeping this > patch simpler I agree, let's merge this patch first before think

Re: [U-Boot] [PATCH v3 4/4] tools: mkimage: Add: Kirkwood Boot Image support (kwbimage)

2009-09-04 Thread Simon Kagstrom
On Fri, 04 Sep 2009 10:24:38 +0200 Wolfgang Denk wrote: > Dear Simon Kagstrom, > > In message <20090904083003.3f7f0...@marrow.netinsight.se> you wrote: > > > > Understandable. On the other hand, it should be possible to pad the > > U-boot image to some specif

[U-Boot] [PATCH, RFC] Make arm926ejs use -march=armv5t to avoid problems with EABI

2009-09-04 Thread Simon Kagstrom
Make arm926ejs use -march=armv5t to avoid problems with EABI Using -march=armv5t instead of armv5te allows Marvell Kirkwood-based boards to boot with the EABI changes introduced in commit f772acf8a584067033eff1e231fcd1fb3a00d3d9 Signed-off-by: Simon Kagstrom --- This allows me to build with

Re: [U-Boot] [PATCH v3 4/4] tools: mkimage: Add: Kirkwood Boot Image support (kwbimage)

2009-09-04 Thread Simon Kagstrom
On Fri, 04 Sep 2009 12:57:57 +0200 Wolfgang Denk wrote: > Dear Simon Kagstrom, > > In message <20090904103602.7a0ec...@marrow.netinsight.se> you wrote: > > > > > > Understandable. On the other hand, it should be possible to pad the > > > > U-boot

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-09-06 Thread Simon Kagstrom
On Fri, 04 Sep 2009 22:05:45 +0200 Wolfgang Denk wrote: > > nand_bbt: Can't scan flash and build the RAM-based BBT > > Net: egiga0 > > 88E1116 Initialized on egiga0 > > Hit any key to stop autoboot: 0 > > Marvell>> > > > > The 4.1 version just hangs on the NAND printout. I've test

Re: [U-Boot] [PATCH v4 4/4]: arm: Define test_and_set_bit and test_and_clear bit for ARM

2009-09-06 Thread Simon Kagstrom
Hi Justin! On Fri, 4 Sep 2009 17:27:59 -0400 Justin Waters wrote: > I found a slight problem with this section of the patch: > > On Mon, 2009-08-24 at 03:10 -0400, Simon Kagstrom wrote: > > diff --git a/include/asm-arm/bitops.h b/include/asm-arm/bitops.h > > index 85

Re: [U-Boot] [PATCH 1/1] at91: Update MEESC board support

2009-09-07 Thread Simon Kagstrom
On Mon, 07 Sep 2009 09:26:17 +0200 Daniel Gorsulowski wrote: >> nack this will be done when u-boot will need to use the macb# > Just imagine: U-boot boots a Linux kernel from NAND flash. It does NOT need > the > ethernet interface, so it does NOT initialize ethernet, so the ethernet > address >

Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support

2009-09-07 Thread Simon Kagstrom
On Mon, 7 Sep 2009 01:59:13 -0700 Prafulla Wadaskar wrote: > > Well, I sent a patch "[PATCH, RFC] Make arm926ejs use -march=armv5t to > > avoid problems with EABI", which corrects this for me, although I'd > > like some input on if it really makes any sense. > > I have tested this with Sheevaplug,

Re: [U-Boot] [RFC/PATCH 1/2]: Arm: Kirkwood: Split PHY-related initialization to a common file

2009-11-22 Thread Simon Kagstrom
On Sun, 22 Nov 2009 21:57:05 +0100 Wolfgang Denk wrote: > > In message <20090713131125.6e6a3...@marrow.netinsight.se> Simon Kagstrom > > wrote: > > > The mv881116 PHY initialization is split out to a common file to enable > > > code reuse between differen

[U-Boot] [PATCH] Support for the OpenRD base board

2009-09-10 Thread Simon Kagstrom
Support for the OpenRD base board The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code and likely to be a bit incomplete. Signed-off-by: Simon Kagstrom --- The configuration does not include UBIFS support, which still needs he remaining patches for the bitops

[U-Boot] [PATCH v2] Support for the OpenRD base board

2009-09-11 Thread Simon Kagstrom
Support for the OpenRD base board The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code and likely to be a bit incomplete. Signed-off-by: Simon Kagstrom --- The configuration does not include UBIFS support, which still needs he remaining patches for the bitops

Re: [U-Boot] [PATCH v2] Support for the OpenRD base board

2009-09-11 Thread Simon Kagstrom
Thanks for the comments Prafulla! I'll update the patch according to them, but have some questions: On Fri, 11 Sep 2009 03:43:04 -0700 Prafulla Wadaskar wrote: > > +#define CONFIG_ENV_SIZE 0x2 /* 128k */ > > +#define CONFIG_ENV_ADDR 0xa > > +#de

Re: [U-Boot] [PATCH v2] Support for the OpenRD base board

2009-09-11 Thread Simon Kagstrom
On Fri, 11 Sep 2009 06:33:44 -0700 Prafulla Wadaskar wrote: > > > > +#define CONFIG_ENV_SIZE 0x2 /* 128k */ > > > > +#define CONFIG_ENV_ADDR 0xa > > > > +#define CONFIG_ENV_OFFSET0xa /* env > > starts here */ > > > Do you really n

[U-Boot] [PATCH v3] Support for the OpenRD base board

2009-09-14 Thread Simon Kagstrom
Support for the OpenRD base board The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code and likely to be a bit incomplete. Signed-off-by: Simon Kagstrom --- The configuration does not include UBIFS support, which still needs the remaining patches for the bitops

Re: [U-Boot] [PATCH, RFC] Make arm926ejs use -march=armv5t to avoid problems with EABI

2009-09-14 Thread Simon Kagstrom
On Fri, 4 Sep 2009 11:27:19 +0200 Simon Kagstrom wrote: > Make arm926ejs use -march=armv5t to avoid problems with EABI > > Using -march=armv5t instead of armv5te allows Marvell Kirkwood-based > boards to boot with the EABI changes introduced in commit > f772acf8a584067033eff1e23

[U-Boot] [PATCH] ubifs: Add support for looking up directory and relative symlinks

2009-09-15 Thread Simon Kagstrom
ubifs: Add support for looking up directory and relative symlinks This patch adds support for resolving symlinks to directories as well as relative symlinks. Symlinks are now always resolved during file lookup, so the load stage no longer needs to special-case them. Signed-off-by: Simon Kagstrom

[U-Boot] UBIFS LZO decompression failure

2009-09-15 Thread Simon Kagstrom
Hi List! I have a slight problem with UBIFS on the OpenRD base board (an ARM board very similar to sheevaplug). Loading files which have been compressed with LZO by ubifs fails: OpenRD>> ubi part root; ubifsmount rootfs Creating 1 MTD partitions on "nand0": 0x001e-0x2000

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-16 Thread Simon Kagstrom
On Wed, 16 Sep 2009 21:19:03 +0200 Stefan Roese wrote: > include/asm-ppc/bitops.h: > @@ -230,6 +231,7 @@ extern __inline__ int ffs(int x) > { > return __ilog2(x & -x) + 1; > } > +#define ffs > > So after "ffs()" is define as an inline function, you define it to nothing. I > understand t

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-17 Thread Simon Kagstrom
On Thu, 17 Sep 2009 08:56:08 +0200 > > Yes, the patch should have contained something like that. Well, we'll > > have to cook up a fix for this then. Sorry about that again. > > Simon, could you do this please? Yes, absolutely. I'll try to have it done by this afternoon. > And btw: > > #ifndef

[U-Boot] [PATCH] Correct ffs/fls regression for PowerPC etc

2009-09-17 Thread Simon Kagstrom
itself. Signed-off-by: Simon Kagstrom --- I've runtime tested on ARM (OpenRD base) and build-tested on MPC8536DS, where __ilog2_u64 now at least is non-empty. It would be nice if (at least!) some PowerPC people could test the patch. include/asm-arm/bitops.h|8 includ

[U-Boot] [PATCH] arm: Correct build with CONFIG_SYS_HUSH_PARSER set

2009-09-17 Thread Simon Kagstrom
arm: Correct build with CONFIG_SYS_HUSH_PARSER set FLAG_PARSE_SEMICOLON is not defined without hush.h, so include that. Signed-off-by: Simon Kagstrom --- cpu/arm926ejs/kirkwood/cpu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cpu/arm926ejs/kirkwood/cpu.c b/cpu

[U-Boot] [PATCH v2] Correct ffs/fls regression for PowerPC etc

2009-09-17 Thread Simon Kagstrom
itself. Signed-off-by: Simon Kagstrom --- I've runtime tested on ARM (OpenRD base) and build-tested on MPC8536DS, where __ilog2_u64 now at least is non-empty. It would be nice if (at least!) some PowerPC people could test the patch. ChangeLog: v2 - Make _all_ macros upper case (Stefan, Wol

Re: [U-Boot] [PATCH v2] Correct ffs/fls regression for PowerPC etc

2009-09-17 Thread Simon Kagstrom
On Thu, 17 Sep 2009 16:13:26 +0200 Stefan Roese wrote: > You have the subject "Correct ffs/fls regression for PowerPC etc" twice in > the > commit message, once in the email subject and once at the beginning of the > mail body. Well, I'll admit that I haven't setup git to send emails yet, so

Re: [U-Boot] [PATCH v4] Support for the OpenRD base board

2009-09-21 Thread Simon Kagstrom
The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code. Unsupported (or untested) is the SD card, PCIe and SATA. Signed-off-by: Simon Kagstrom --- I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood

Re: [U-Boot] [PATCH, RFC] Make arm926ejs use -march=armv5t to avoid problems with EABI

2009-09-24 Thread Simon Kagstrom
On Thu, 24 Sep 2009 14:36:47 +0200 Stefan Roese wrote: > On Monday 14 September 2009 11:02:15 Simon Kagstrom wrote: > > > Make arm926ejs use -march=armv5t to avoid problems with EABI > > > > > > Using -march=armv5t instead of armv5te allows Marvell Kirkwood-based

Re: [U-Boot] [PATCH] arm: Correct build with CONFIG_SYS_HUSH_PARSER set

2009-09-24 Thread Simon Kagstrom
Hi Prafulla! Small reminder :-). Perhaps you missed this patch - and I also forgot to add you under To:. It's a simple one-liner to get kirkwood/cpu.c to build when CONFIG_SYS_HUSH_PARSER is set. // Simon On Thu, 17 Sep 2009 14:40:18 +0200 Simon Kagstrom wrote: > arm: Correct bu

[U-Boot] [PATCH] ubifs: Correct dereferencing of files-after-symlinks

2009-09-25 Thread Simon Kagstrom
off-by: Simon Kagstrom --- fs/ubifs/ubifs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c index b03ed0b..286739c 100644 --- a/fs/ubifs/ubifs.c +++ b/fs/ubifs/ubifs.c @@ -439,7 +439,7 @@ static unsigned long ubifs_findfile(str

[U-Boot] [RFC] Detecting coldstart on kirkwood CPUs

2009-09-25 Thread Simon Kagstrom
s warm. But... Isn't there some better way of checking this on Kirkwood? // Simon [PATCH] Reset sysrst count before restarting Signed-off-by: Simon Kagstrom --- cpu/arm926ejs/kirkwood/cpu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cpu/arm926ejs/kirkwood

[U-Boot] [PATCH] arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards

2009-09-28 Thread Simon Kagstrom
Initialize by calling kw_watchdog_init() with the number of seconds for the watchdog to timeout. Signed-off-by: Simon Kagstrom --- cpu/arm926ejs/kirkwood/timer.c | 29 + include/asm-arm/arch-kirkwood/cpu.h |2 ++ 2 files changed, 31 insertions(+), 0

Re: [U-Boot] [PATCH] arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards

2009-09-28 Thread Simon Kagstrom
On Mon, 28 Sep 2009 07:36:32 -0500 Tom wrote: > > +void hw_watchdog_reset(void) > > +{ > > + unsigned long time = CONFIG_SYS_TCLK * watchdog_timeout; > > > diff --git a/include/asm-arm/arch-kirkwood/cpu.h > > b/include/asm-arm/arch-kirkwood/cpu.h > > index b3022a3..df49c3f 100644 > > --- a/inc

Re: [U-Boot] [PATCH] arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards

2009-09-29 Thread Simon Kagstrom
On Mon, 28 Sep 2009 19:16:16 -0700 Prafulla Wadaskar wrote: > But do you really need Watchdog support for u-boot? Paranoia really has no limits :-). The main objective for me personally is to have the watchdog on when Linux starts, but if there is a risk (for whatever reason) that U-boot hangs,

Re: [U-Boot] [PATCH] arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards

2009-09-29 Thread Simon Kagstrom
On Tue, 29 Sep 2009 06:45:44 -0700 Prafulla Wadaskar wrote: > > The main objective for me personally is to have the watchdog on when Linux > > starts, > > but if there is a risk (for whatever reason) that U-boot hangs, it would > > also help there. > > Its good to have watchdog, it will be ver

Re: [U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND

2009-09-29 Thread Simon Kagstrom
On Tue, 29 Sep 2009 17:16:42 +0200 Dieter Kiermaier wrote: > Hm, it looks like there is the whole nand system somewhat broken :( > Haven't seen it earlier, but: > U-Boot 2009.08-00208-g9ef0569-dirty (Sep 29 2009 - 15:42:42) > OpenRD_base > > SoC:   Kirkwood 88F6281_A0 > DRAM:  27535155593740288

Re: [U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND

2009-09-30 Thread Simon Kagstrom
On Wed, 30 Sep 2009 09:02:14 +0200 Dieter Kiermaier wrote: > arm-none-linux-gnueabi-ld: ERROR: Source object > /home/dieter/ArtistaNET-III/Software/trunk/SDK/tools/gcc/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.0/libgcc.a(_udivsi3.o) > has EABI version 4, but target u-boot has EABI version 0 >

Re: [U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND

2009-09-30 Thread Simon Kagstrom
roper fix? I realise that this also affects other arm926ejs-boards, but is there some way to isolate this to kirkwood? // Simon >From 29ff02ca77406e820203ad27369e0684aa1a098c Mon Sep 17 00:00:00 2001 From: Simon Kagstrom Date: Fri, 4 Sep 2009 11:15:20 +0200 Subject: [PATCH] Make arm926e

Re: [U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND

2009-09-30 Thread Simon Kagstrom
On Wed, 30 Sep 2009 10:15:35 +0200 Dieter Kiermaier wrote: > > > is there anywhere a document how to build open source u-boot for > > > sheevaplug which explains all these details? > > > (haven't found some documentation about this) > > > > (Wearing my Prafulla hat): I guess this should be desc

[U-Boot] [PATCH] Make arm926ejs use -mabi=apcs-gnu to avoid EABI problems

2009-10-01 Thread Simon Kagstrom
Using -mabi=apcs-gnu allows Marvell Kirkwood-based boards to boot with the EABI changes introduced in commit f772acf8a584067033eff1e231fcd1fb3a00d3d9. Signed-off-by: Simon Kagstrom --- Wolfgang can live with this change to make Kirkwood builds work again: On Wed, 30 Sep 2009 22:32:08 +0200

Re: [U-Boot] [PATCH] Make arm926ejs use -mabi=apcs-gnu to avoid EABI problems

2009-10-02 Thread Simon Kagstrom
On Thu, 01 Oct 2009 20:27:11 +0200 Wolfgang Denk wrote: > > > > > -PLATFORM_CPPFLAGS += -march=armv5te > > > > > +PLATFORM_CPPFLAGS += -march=armv5te -mabi=apcs-gnu > > I have to admit that I really hesitate ifwe should add this - the > longer I think about it, the more I tend to say no. > > I ca

[U-Boot] [PATCH] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems

2009-10-05 Thread Simon Kagstrom
undefined behavior), and start.S gave the stack a 12-byte alignment. Tested on an OpenRD base board, where both printouts and ubifs stuff now works. Signed-off-by: Simon Kagstrom --- cpu/arm926ejs/start.S |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cpu/arm926ejs/start.S

Re: [U-Boot] [PATCH] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems

2009-10-05 Thread Simon Kagstrom
On Mon, 5 Oct 2009 09:30:54 -0500 Andrew Dyer wrote: > >        sub     r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ) > >  #endif > > -       sub     sp, r0, #12             /* leave 3 words for abort-stack     > > */ > > +       sub     sp, r0, #16             /* leave 3 words for abort-s

[U-Boot] [PATCH v2] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems

2009-10-05 Thread Simon Kagstrom
undefined behavior), and start.S gave the stack a 12-byte alignment. Tested on an OpenRD base board, where both printouts and ubifs stuff now works. Signed-off-by: Simon Kagstrom --- ChangeLog: v2: Update after Andrews comments * Mask away the low address bits to get 16-byte alignment cpu

[U-Boot] [PATCH v3] arm926ejs: 8-byte align stack to avoid LDRD/STRD problems

2009-10-05 Thread Simon Kagstrom
undefined behavior). Tested on an OpenRD base board, where both printouts and ubifs stuff now works. Signed-off-by: Simon Kagstrom --- ChangeLog: v2: Update after Andrews comments * Mask away the low address bits to get 16-byte alignment v3: Update after Andrews and Måns comments * Use bic

Re: [U-Boot] [PATCH v2] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems

2009-10-06 Thread Simon Kagstrom
On Mon, 05 Oct 2009 13:37:36 -0500 Tom wrote: > Simon Kagstrom wrote: > > U-boot for Marvell Kirkwood boards no longer work after the EABI changes > > introduced in commit f772acf8a584067033eff1e231fcd1fb3a00d3d9. This > > turns out to be caused by a stack alignme

Re: [U-Boot] arm/master merged

2009-10-12 Thread Simon Kagstrom
On Sun, 11 Oct 2009 14:00:15 -0500 Tom Rix wrote: > I have merged arm/next into arm/master. > > There are new warnings in > CPU9260 , CONFIG_SYS_64BIT_VSPRINTF > CPU9G20 , CONFIG_SYS_64BIT_VSPRINTF > GPUAT91 , CONFIG_NET_MULTI, > davinci_dm355evm , CONFIG_SYS_64BIT_VSPRINTF, generic_set_bit >

Re: [U-Boot] ARM pull request v3

2009-10-13 Thread Simon Kagstrom
On Tue, 13 Oct 2009 16:51:14 +0200 Wolfgang Denk wrote: > > I want to let you know that there will probably be some compilation > > warnings. These are patches for these. These have been sent to the > > list and ACK'ed by Tom and currently in my master. This will be part > > of my next pull reque

Re: [U-Boot] ARM pull request v3

2009-10-14 Thread Simon Kagstrom
On Wed, 14 Oct 2009 06:18:30 -0500 Tom Rix wrote: > > Tom: Perhaps you could pick up "[PATCH v3] arm926ejs: 8-byte align > > stack to avoid LDRD/STRD problems" for the ARM repo as well then? > > > > I know it could go via Prafullas tree, but it's not really > > Marvell-specific, just fixes an is

Re: [U-Boot] [PATCH] sheevaplug: correct SDRAM address control register value

2009-10-18 Thread Simon Kagstrom
On Fri, 16 Oct 2009 13:09:15 -0400 Mark Asselstine wrote: > The SheevaPlug DevKit is shipped with 4x8 by 1Gb DDR devices in > two banks for a total of 512MB of RAM. Based on this configuration > the existing values for SDRAM address control register are incorrect > -DATA 0xFFD01410 0x0099

Re: [U-Boot] ARM pull request v3

2009-10-23 Thread Simon Kagstrom
Hi Tom and Wolfgang! On Sun, 18 Oct 2009 17:58:48 -0500 Tom wrote: > [...] > The following changes since commit a380279b2abe130c2d3d2c8de36f8ff98bc6b3b0: >Daniel Gorsulowski (1): > at91: Update MEESC board support > > are available in the git repository at: > >git://git.denx.d

Re: [U-Boot] [PATCH] arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards

2009-10-28 Thread Simon Kagstrom
Hi again Prafulla and the list! On Mon, 28 Sep 2009 09:06:26 +0200 Simon Kagstrom wrote: > Initialize by calling kw_watchdog_init() with the number of seconds for > the watchdog to timeout. > > Signed-off-by: Simon Kagstrom Were there any particular problems with this patch t

  1   2   >