2011/11/24 Marek Vasut
> > On 11/12/2011 06:45 PM, Jana Rapava wrote:
> > > This commit adds USB support for EfikaMX and EfikaSB.
> > >
> > > Signed-off-by: Jana Rapava
> > > Signed-off-by: Marek Vasut
> > > Cc: Remy Bohmer
> > > Cc
Add generic functions for ULPI init and setting bits in
ULPI registers.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
Changes for v2:
- make code EHCI-independent
- use udelay() in waiting loop
e two functions be united in one,
> say ulpi_pulldown(u32 ..., int enable)?
>
>
If I understand ULPI specification well, the overall effect is the same
when both bits are set to 1 as when they are set to 0.
And default setting is for both bits to be 1, so I don't think that have
one function for both bits make sense.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Add generic functions for ULPI init and setting bits in
ULPI registers.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
Changes for v2:
- make code EHCI-independent
- use udelay() in waiting loop
n for this patch not to be accepted,
and I agree with him.
And I'll rename this function into ulpi_request(), ulpi_wait() is really a
bit deceiveing.
Thanks for your comments.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
st for the second parameter.
> > Perhaps you could avoid this if you make the reg parameter u8 *
> > instead?
>
> This is what I would call a "no go"...
> Jana, can you, please deal with this?
> And if you do, then you can deal with *most* of other comments as well.
>
>
Ok, I'll do so.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Add generic functions for reading, writing and setting bits in ULPI registers.
Signed-off-by: Jana Rapava
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
Cc: Simon Glass
---
Changes for v2:
- make code EHCI-independent
- use udelay() in waiting loop
Add generic functions for reading, writing and setting bits in ULPI registers.
Signed-off-by: Jana Rapava
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
Cc: Simon Glass
Acked-by: Igor Grinberg
Acked-by: Simon Glass
---
Changes for v2:
- make code EHCI
--- a/board/efikamx/efikamx-usb.c
+++ b/board/efikamx/efikamx-usb.c
@@ -154,6 +154,7 @@ void efika_usb_phy_reset(void)
gpio_set_value(IOMUX_TO_GPIO(MX51_PIN_EIM_D27), 1);
}
+
/*
* Configure control registers of the USB controller
*/
@@ -161,56 +162,56 @@ void control_regs_setup(void)
/board/efikamx/efikamx-usb.c: cleanup
Signed-off-by: Jana Rapava
---
board/efikamx/efikamx-usb.c | 111 +++
include/usb/ehci-fsl.h | 49 +++
2 files changed, 108 insertions(+), 52 deletions(-)
diff --git a/board/efikamx/efikamx
From: Marek Vasut
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Marek Vasut
Signed-off-by: Jana Rapava
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access changed
a patch with git-format-patch, aligning is messed up. So I fix it
in git-send-email, but after sending whitespace characters are messed up
again.
I wasn't able to find a way to fix it yet.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
htt
2011/10/31 Igor Grinberg
> > +struct mxc_ulpi_regs {
> > + u8 vendor_id_low; /* 0x00 - Vendor ID lower byte */
> > + u8 vendor_id_high; /* 0x01 - Vendor ID upper byte */
> > + u8 product_id_low; /* 0x02 - Product ID lower byte */
> > + u8
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
---
Changes for v2:
- whitespace and coding style changes (no
2011/11/1 Igor Grinberg
>
> Do you already have a header for the generic ULPI support?
> Can't the above be put in that header and the next patch set
> (ULPI) will just extend this?
>
Ok, I'll send ulpi header as a separate patch, thanks for suggestion.
>
>
> --
> Regards,
> Igor.
>
___
Add ULPI header file needed by Efika USB support patchset and generic
ULPI support patch, which is to be posted soon.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
---
include/usb/ulpi.h | 195
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
---
Changes for v2:
- whitespace and coding style changes
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Acked-by: Marek Vasut
---
Changes for v2:
- introduce temporary variable in ulpi_write
- whitespace changes
Changes for v3:
- add
2011/11/2 Igor Grinberg
> Hi Jana,
>
> On 11/01/11 21:24, Jana Rapava wrote:
>
> > diff --git a/board/efikamx/efika.h b/board/efikamx/efika.h
> > new file mode 100644
> > index 000..fec9ee0
> > --- /dev/null
> > +++ b/board/efikamx/efika.h
> >
Add ULPI header file needed by Efika USB support patchset and generic
ULPI support patch, which is to be posted soon.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
---
Changes for v2:
- whitespace and comment changes
include/usb
Add generic functions for ULPI init and setting bits in
ULPI registers.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
---
Makefile |1 +
drivers/usb/ulpi/Makefile| 44 ++
drivers/usb/ulpi
This patch changes Efika USB support code to use generic ULPI implementation
instead of driver's own.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
---
board/efikamx/efikamx-usb.c | 105 +--
in
2011/11/5 Marek Vasut
>
> > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 ulpi_mask)
>
> So this works only with EHCI? How generic is it then ?
>
>
I thought until now that ULPI is EHCI-dependent, but isn't... Ok, what else
should be supported? OHCI? I haven't any hardware to test it,
2011/11/6 Marek Vasut
> > 2011/11/5 Marek Vasut
> >
> > > > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 ulpi_mask)
> > >
> > > So this works only with EHCI? How generic is it then ?
> >
> > I thought until now that ULPI is EHCI-dependent, but isn't... Ok, what
> else
> > should be
1 and mx53, so I think it would be nice
to find some way to get them together.
Last but not least, I'm sorry that I didn't respond to your first e-mail,
but I had to study for a test and hadn't time to look at your patch better.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
u32 tmp = 0;
> > + int reg;
> > +
> > + /* Assemble ID from four ULPI ID registers (8 bits each). */
> > + for (reg = ULPI_ID_REGS_COUNT - 1; reg >= 0; reg--)
> > + tmp |= ulpi_read(ehci, reg) << (reg * 8);
> > +
> > + /* Split ID into vendor and product ID. */
> > + debug("Found ULPI TX, ID %04x:%04x\n", tmp >> 16, tmp & 0x);
>
> What is TX? Is it transceiver or xceiver or both in one?
>
>
According to ULPI 1.1 specification, it is transceiver.
--
> Regards,
> Igor.
>
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Add ULPI header file needed by Efika USB support patchset and generic
ULPI support patch.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
This patch is a prerequisite for Efika USB patchset.
Changes for v2
Add generic functions for ULPI init and setting bits in
ULPI registers.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
This patch is a prerequisite for Efika USB patchset.
Changes for v2:
- make code EHCI
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
Changes for v2:
- whitespace and
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
Acked-by: Marek Vasut
---
Changes for v2:
- introduce temporary variable in ulpi_write
de the ulpi.c. Any objections?
>
>
This looks like a good idea, thanks.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
ster bits of interest */
> > +#define MX51_H2_ULPI_IE (1 << 8)
> > +#define MX51_H2_WUE (1 << 7)
> > +#define MX51_H2_PM (1 << 4)
>
> Most of the definitions above are arch specific and would better be
> placed in arch/arm/inc
2011/11/17 Marek Vasut
>
> Jana, you have efikamx and I can get you HDMI cable. Can you recheck
> tomorrow ?
>
> M
>
Ok, I can.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
27;t work with current u-boot-imx tree (no LCD output after
'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
2011/11/20 Marek Vasut
>
> > HDMI output doesn't work with current u-boot-imx tree (no LCD output
> after
> > 'setenv stdout lcd'),
> > but works with current u-boot-marex/efikasb tree.
> >
>
> Ok, so are you debugging it or not ?
>
No, I thought that if it works with u-boot-marex/efikasb, it's
EHCI: add callback ehci_fixup to solve VBUS reset
issue for Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based
This commit changes MX31 prefix in common USB_CTRL bits to MXC.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Stefano Babic
Cc: Remy Bohmer
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based
From: Marek Vasut
USB: Add usb_event_poll() to get keyboards working with
EHCI
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based acc
USB: move ehci.h and ehci-core.h into /include/usb/
Signed-off-by: Jana Rapava
Cc: Remy Bohmer
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access changed to struct-based access
- use
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Fabio Estevam
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access changed to struct-based access
- use {clrset,clr,set
Add callback to ehci_fixup to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
Add into ./include/usb/ehci-fsl.h macros and structures
needed by following patch; change prefix of common MX31 USB_CTRL bits
to MXC.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based
Why don´t you just resend my original patch (put my name in the From:
> field) as part of this series?
> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/109335
>
Thanks, I'll be glad to use it.
Regards,
Jana Rapava
___
U-Boot
at.
The problem is in the middle of usb_new_device, but it looks like no
function calling ULPI operations is called from that function.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
From: feste...@gmail.com (Fabio Estevam)
Move ehci.h and ehci-core.h to include/usb directory.
Cc: Remy Bohmer
Cc: Marek Vasut
Signed-off-by: Fabio Estevam
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offse
first argument stays u8 and
> the
> result is truncated.
>
Thanks, but I had to change the type from u8 to u32 to silence compiler
warnings and it's solved the problem too.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Add callback to ehci_fixup to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access
2011/9/27 Fabio Estevam
> Jana,
>
> On Tue, Sep 27, 2011 at 8:07 AM, Fabio Estevam wrote:
>
> This is even worse: you sent an email with my name. ferma...@gmail.com
> is your email address, not mine.
>
Now I really don't understand where it went wrong. My git send-email log
says "From: Fabio Es
s in this patchset is one of them. When I repost this
patch, I'll try to express this more clearly.
Thanks for your comments.
Cheers,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
header and move this to the header please.
>
Should I move all #define's and #ifdef's, or only this?
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
robably need some changes and I can't test them
because I haven't EfikaSB.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
From: Fabio Estevam
Move ehci.h and ehci-core.h to include/usb directory.
Signed-off-by: Fabio Estevam
Cc: Remy Bohmer
Cc: Marek Vasut
---
Changes for v5:
- reorder patches in patchset
- use patch from Fabio Estevam
Changes for v6:
- fix From field
drivers/usb/host/e
Add callback to ehci_fixup to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v4:
- split into patchset
- add callback ehci_fixup
Changes for v5:
- make this the second
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v4:
- split into patchset
Changes for v5:
- make this the third
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access
27;t be entries
with version numbers before the patch was introduced (v4 for this patch).
It looks reasonable to me, but if you would insist on keeping the whole
changelog, there is no problem.
Cheers,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
2011/9/27 Marek Vasut
> > diff --git a/board/efikamx/efika.h b/board/efikamx/efika.h
> > new file mode 100644
> > index 000..2134e75
> > --- /dev/null
> > +++ b/board/efikamx/efika.h
> > @@ -0,0 +1,8 @@
>
> Proper header is missing here, with license, author etc.
>
What should I write into
From: Fabio Estevam
Move ehci.h and ehci-core.h to include/usb directory.
Signed-off-by: Fabio Estevam
Cc: Remy Bohmer
Cc: Marek Vasut
---
Changes for v1:
- reorder patches in patchset
- use patch from Fabio Estevam
Changes for v2:
- fix From field
- rebase on
Add callback to ehci_fixup to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v1:
- split into patchset
- add callback ehci_fixup
Changes for v2:
- make this the second patch
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v1:
- split into patchset
Changes for v2:
- make this the third
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access changed
> Otherwise:
> Acked-by: Marek Vasut
>
> (please add this line to the final revision of this patch.)
>
Thanks, should I add this line also to the first two patches of this
patchset? There weren't any change requests for the last version of them.
they don't
>
Thanks, Marek already told me.
Regards,
Jana Rapava
> Best regards,
> Stefano Babic
>
> --
> =
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Mun
root. */
>
> Where can I read about this please?
>
Universal Serial Bus Specification Revision 2.0, chapter 7.1.7.5 Reset
Signaling says: "It is required that resets from root ports have a duration
of at least 50 ms (TDRSTR)."
Regards,
Jana Rapava
__
From: Fabio Estevam
Move ehci.h and ehci-core.h to include/usb directory.
Signed-off-by: Fabio Estevam
Cc: Remy Bohmer
Cc: Marek Vasut
---
Changes for v1:
- reorder patches in patchset
- use patch from Fabio Estevam
Changes for v2:
- fix From field
- rebase on
Add callback to ehci_hcd.c to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Acked-by: Marek Vasut
---
Changes for v1:
- split into patchset
- add callback ehci_fixup
Changes for v2:
- make
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v1:
- split into patchset
Changes for v2:
- make this the third
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access changed to
2011/9/28 Marek Vasut
> > +if (!timeout)
> > +return -1;
> > +else
> > +return tmp;
> > +}
>
> Won't 'return !timeout;' be enough?
>
> > +tmp = ulpi_wait(ehci, ULPI_RWRUN);
> +if (tmp == -1) {
> +printf("ULPI read timed out\n");
> +return 0;
> +
From: Fabio Estevam
Move ehci.h and ehci-core.h to include/usb directory.
Signed-off-by: Fabio Estevam
Cc: Remy Bohmer
Cc: Marek Vasut
---
Changes for v1:
- reorder patches in patchset
- use patch from Fabio Estevam
Changes for v2:
- fix From field
- rebase on
Add callback to ehci_fixup to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Acked-by: Marek Vasut
---
Changes for v1:
- split into patchset
- add callback ehci_fixup
Changes for v2:
- make this
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v1:
- split into patchset
Changes for v2:
- make this the third patch
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- changed to proper patch
Changes for v3:
- merged other USB patches from u-boot-pxa/efikasb
- offset-based access changed to
t more clearly. I'll be glad
for any suggestions.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
h proper version numbers if you want.
>
> So please, if you submit a series and then update only SOME patches, you
> have to
> send only the updated patches. And the email in-reply-to should be set
> per-patch
> to it's predecesor.
>
Ok.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
2011/9/28 Marek Vasut
> Can you repost the whole series with proper cover letter explaining you're
> burying this mess and all ? Start versioning from V1 then.
>
> Thanks
>
>
Ok, what Message-ID should I then use for In-Reply-To field
2011/9/29 Marek Vasut
>
> > Ok, what Message-ID should I then use for In-Reply-To field?
>
> None in this case ... did you actually read the patch submission rules?
>
>
I read this and didn't find this information here:
http://www.denx.de/wiki/U-Boot/Patches
Is there anything else I should read?
and start with a clean
plate. Version of patches in this patchset will then be 1.
Fabio Estevam (1):
usb: Move ehci.h and ehci-core.h to include/usb directory
Jana Rapava (3):
EHCI: add callback ehci_fixup
EHCI: adjust for mx5
Add USB support for Efika
board/efikamx/Makefile
Add callback to ehci_hcd.c to prepare
for solving the problem with VBUS reset on Efika.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Acked-by: Marek Vasut
---
drivers/usb/host/ehci-hcd.c | 14 +-
1 files changed, 13 insertions(+), 1 deletions
From: Fabio Estevam
Move ehci.h and ehci-core.h to include/usb directory.
Signed-off-by: Fabio Estevam
Cc: Remy Bohmer
Cc: Marek Vasut
---
drivers/usb/host/ehci-core.h | 29 --
drivers/usb/host/ehci-fsl.c |4 +-
drivers/usb/host/ehci-hcd.c |2 +-
drivers/usb/host/
Add macros and structures needed by Efika USB support code.
Move shared offset and bits definitions into common header file.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
drivers/usb/host/ehci-mxc.c | 31 +
include/usb/ehci-fsl.h | 146
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
board/efikamx/Makefile |3 +
board/efikamx/efika.h | 30 +++
board/efikamx/efikamx-usb.c | 420
2011/9/29 Marek Vasut
> the cover letter is missing
sorry, I forgot to Cc: you
> and it's sent as a set of separate patches. Why?
>
I thought this should be a patchset, it doesn't look like one logical change
to me...
Regards,
Jana Rapava
__
and start with a clean
plate. Version of patches in this patchset will then be 1.
Changes for v2:
- no changes, I only forget to add Cc: when I sent this
Fabio Estevam (1):
usb: Move ehci.h and ehci-core.h to include/usb directory
Jana Rapava (3):
EHCI: add callback ehci_fixup
EHCI
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- introduce temporary variable in ulpi_write
- whitespace changes
board/efikamx/Makefile |3 +
board
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- introduce temporary variable in ulpi_write
- whitespace changes
Changes for v3:
- add protection against
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- introduce temporary variable in ulpi_write
- whitespace changes
Changes for v3:
- add protection against
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
---
Changes for v2:
- introduce temporary variable in ulpi_write
- whitespace changes
Changes for v3:
- add protection against multiple
This commit adds USB support for EfikaMX and EfikaSB.
Signed-off-by: Jana Rapava
Signed-off-by: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Acked-by: Marek Vasut
---
Changes for v2:
- introduce temporary variable in ulpi_write
- whitespace changes
Changes for v3:
- add
ead but I messed up some In-Reply-To: headers).
On the last version checkpatch says only two warnings, both are about
including files not from and doesn't make sense in this case.
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
2011/10/9 Marek Vasut
> On Sunday, September 25, 2011 07:25:07 PM Jana Rapava wrote:
> > Signed-off-by: Jana Rapava
> > Cc: Marek Vasut
> > Cc: Remy Bohmer
> > Cc: Fabio Estevam
> > ---
> > Changes for v2:
> > - changed to proper patch
>
or simply add rule for new files?
Regards,
Jana Rapava
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
96 matches
Mail list logo
