Re: [PATCH 3/3] patman: Add a tag for when a patch gets added to a series

Hi, On Thu, Apr 18, 2024 at 7:36 PM Sean Anderson wrote: > > When a patch is added to a series after the initial version, there are no > changes to note except that it is new. This is typically done to suppress > the "(no changes in vN)" message. It's also nice to add a change to the > cover lett

Re: [PATCH 3/3] patman: Add a tag for when a patch gets added to a series

Hi, On Thu, Apr 18, 2024 at 7:36 PM Sean Anderson wrote: > > When a patch is added to a series after the initial version, there are no > changes to note except that it is new. This is typically done to suppress > the "(no changes in vN)" message. It's also nice to add a change to the > cover lett

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

Hi, On Tue, Dec 5, 2023 at 3:16 AM Ahmad Fatoum wrote: > > Hello, > > On 04.12.23 18:52, Doug Anderson wrote:> On Sat, Dec 2, 2023 at 8:37 AM Simon > Glass wrote: > >> On Thu, 30 Nov 2023 at 19:04, Ahmad Fatoum wrote: > >>> On 30.11.23 21:30, Simon Gla

Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree

> > > > > I don't have an example to hand, but this is the required mechanism of > > > FIT. This feature has been in place for many years and is used by > > > ChromeOS, at least. > > > > I see the utility of a FIT configuration with > > > > compatible = "vendor,board-rev-a", "vendor,board-rev-b"; > > > > I fail to see a utility for a configuration with > > > > compatible = "vendor,board", "vendor,SoM", "vendor,SoC"; > > > > Any configuration that ends up being booted because "vendor,SoC" was > > matched is > > most likely doomed to fail. Therefore, I would suggest that only the top > > level > > configuration is written into the FIT configurations automatically. > > Firstly, I am not an expert on this. > > Say you have a board with variants. The compatible string in U-Boot > may be something like: > > "google,veyron-brain-rev1", "google,veyron-brain", "google,veyron", > "rockchip,rk3288"; > > If you then have several FIT configurations, they may be something like: > > "google,veyron-brain-rev0", "google,veyron-brain", "google,veyron", > "rockchip,rk3288"; > "google,veyron-brain-rev1", "google,veyron-brain", "google,veyron", > "rockchip,rk3288"; > "google,veyron-brain-rev2", "google,veyron-brain", "google,veyron", > "rockchip,rk3288"; > > You want to choose the second one, since it is a better match than the others. > > +Doug Anderson who knows a lot more about this than me. Hopefully this is all explained by: https://docs.kernel.org/arch/arm/google/chromebook-boot-flow.html

Re: [PATCH v2 4/4] patman: Check patches in parallel

Hi, On Sun, Feb 19, 2023 at 3:50 PM Simon Glass wrote: > > For large series this can take a while. Run checkpatch in parallel to > try to reduce the time. The checkpatch information is still reported in > sequential order, so a very slow patch at the start can still slow > things down. But overal

Re: [PATCH v2 3/4] patman: Run get_maintainer.pl in parallel

Hi, On Sun, Feb 19, 2023 at 3:50 PM Simon Glass wrote: > > This script can take ages on some series. Try to limit the time by > using threads. If a few stubborn patches remain, show progress so the > user has some idea what is going on. > > Signed-off-by: Simon Glass > --- > > (no changes since

Re: [PATCH v2 2/4] patman: Refactor MakeCcFile() into two functions

Hi, On Sun, Feb 19, 2023 at 3:50 PM Simon Glass wrote: > > @@ -234,6 +234,48 @@ class Series(dict): > str = 'Change log exists, but no version is set' > print(col.build(col.RED, str)) > > +def GetCcForCommit(self, commit, process_tags, warn_on_error, > +

Re: [PATCH v2 1/4] patman: Drop an incorrect comment about git am

Hi, On Sun, Feb 19, 2023 at 3:50 PM Simon Glass wrote: > > Patman does not do this anymore, so drop the comment. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Fix 'uncorrect' typo in subject > > tools/patmanu/control.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I gu

Re: [PATCH v3 3/5] patman: Make most bool arguments BooleanOptionalAction

Hi, On Sat, Jul 16, 2022 at 4:55 AM Simon Glass wrote: > > Hi Doug, > > On Thu, 7 Jul 2022 at 09:26, Douglas Anderson wrote: > > > > For boolean arguments it's convenient to be able to specify both the > > argument and its opposite on the command line. This is especially > > convenient because y

Re: [PATCH v2 1/6] patman: Fix updating argument defaults from settings

Hi, On Thu, Jul 7, 2022 at 8:11 AM Sean Anderson wrote: > > On 7/6/22 8:07 PM, Doug Anderson wrote: > > Hi, > > > > On Tue, Jul 5, 2022 at 11:16 AM Sean Anderson > > wrote: > >> > >> Hi Doug, > >> > >> On 7/1/22 4:23 PM, Doug

Re: [PATCH v2 1/6] patman: Fix updating argument defaults from settings

Hi, On Tue, Jul 5, 2022 at 11:16 AM Sean Anderson wrote: > > Hi Doug, > > On 7/1/22 4:23 PM, Douglas Anderson wrote: > > Ever since commit 4600767d294d ("patman: Refactor how the default > > subcommand works"), when I use patman on the Linux tree I get grumbles > > about unknown tags. This is bec

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

Hi, On Thu, Sep 26, 2019 at 6:50 PM Simon Glass wrote: > > Hi Doug, > > On Tue, 3 Sep 2019 at 13:15, Douglas Anderson wrote: > > > > As per the centithread on ksummit-discuss [1], there are folks who > > feel that if a Change-Id is present in a developer's local commit that > > said Change-Id co

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

Johannes, On Thu, Sep 5, 2019 at 12:48 PM Johannes Berg wrote: > > On Tue, 2019-09-03 at 13:15 -0700, Douglas Anderson wrote: > > > > Let's give that a try. > > > > In theory (if there is enough adoption) this could help a tool more > > reliably find various versions of a commit. > > It's not qui

Re: [U-Boot] [RFC PATCH] patman: Use the Change-Id, version, and prefix in the Message-Id

Hi, On Wed, Aug 28, 2019 at 2:05 PM Johannes Berg wrote: > > Hi Doug, > > Some comments on the actual mechanics here (vs. on the kernel list I > picked this up from). > > It seems like perhaps you could increase the "count" variable. You got: > > 20190828132723.0.RFC.Ie6289f437ae533d7fcaddfcee920

Re: [U-Boot] [PATCH] pwm: add MACRO to limit some code which only for rk3288

Hi, On Mon, Jul 11, 2016 at 7:45 PM, Kever Yang wrote: > Hi Simon, > > CC Doug for this topic. > > > On 07/12/2016 07:54 AM, Simon Glass wrote: >> >> Hi Kever, >> >> On 11 July 2016 at 00:58, Kever Yang wrote: >>> >>> Hi Simon, >>> >>> On 07/09/2016 10:39 PM, Simon Glass wrote: Hi Keve

Re: [U-Boot] [PATCH v2] patman: make run results better visible

endebury > --- > > Changes in v2: > - modified the error message for accuracy > > tools/patman/patman.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] patman: make run results better visible

Vadim, On Wed, Sep 3, 2014 at 4:00 PM, Vadim Bendebury wrote: > On Wed, Sep 3, 2014 at 3:14 PM, Doug Anderson wrote: >> Vadim, >> >> On Wed, Sep 3, 2014 at 12:16 PM, Vadim Bendebury >> wrote: >>> For an occasional user of patman some failures are not obvio

Re: [U-Boot] [PATCH] patman: make run results better visible

Vadim, On Wed, Sep 3, 2014 at 12:16 PM, Vadim Bendebury wrote: > For an occasional user of patman some failures are not obvious: for > instance when checkpatch reports warnings, the dry run still reports > that the email would be sent. If it is not dry run, the warnings are > shown on the screen,

Re: [U-Boot] [PATCH] patman: Only apply patches when we know the original HEAD

Hi, On Tue, Jun 24, 2014 at 3:24 AM, Masahiro Yamada wrote: > OK. It seems better to check. > > I added some patches which include whitespace errors > and ran Patman. > > It looks like nothing changes with/without -a option. > > > $ tools/patman/patman -a -c 3 > 1 warnings for 0002-arm-commit-2.p

Re: [U-Boot] [PATCH] patman: Don't request full names from get_maintainer

Simon, On Tue, May 13, 2014 at 11:17 AM, Simon Glass wrote: > Hi Doug, > > On 18 April 2014 15:32, Doug Anderson wrote: >> Simon, >> >> On Fri, Apr 18, 2014 at 1:43 PM, Simon Glass wrote: >>> Hi Doug, >>> >>> On 17 April 2014 12:47, Doug

Re: [U-Boot] [PATCH] patman: Don't request full names from get_maintainer

Simon, On Fri, Apr 18, 2014 at 1:43 PM, Simon Glass wrote: > Hi Doug, > > On 17 April 2014 12:47, Doug Anderson wrote: >> >> The Linux get_maintainer.pl can often produce a whole lot of results. >> As a result you'll sometimes blow your CC field over 1024

[U-Boot] [PATCH] patman: Don't request full names from get_maintainer

al names. This will dramatically reduce the number of characters. Signed-off-by: Doug Anderson --- tools/patman/get_maintainer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/patman/get_maintainer.py b/tools/patman/get_maintainer.py index 00b4939..a5160bc 10064

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

Tom, On Fri, May 17, 2013 at 9:52 AM, Tom Rini wrote: >> Saw your reply but don't completely understand it. I think we'd still >> like U-Boot to populate the memory property if possible and it sounds >> like your patch would prevent that. One reason is that we'd like to >> be able to handle dif

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

Tom, On Fri, May 17, 2013 at 9:40 AM, Tom Rini wrote: > I think my email must have been lost in the shuffle, see > http://patchwork.ozlabs.org/patch/240687/ > > So yes, I've got another fix in mind that should solve this and some > other problems. Saw your reply but don't completely understand i

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

Tom, On Wed, May 15, 2013 at 9:51 AM, Doug Anderson wrote: > Vadim, > > On Wed, May 15, 2013 at 8:58 AM, Vadim Bendebury wrote: >> This is not a big deal for u-boot (maybe very marginally inefficient >> when determining the actual memory size). Is this a big deal for &g

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

Vadim, On Wed, May 15, 2013 at 8:58 AM, Vadim Bendebury wrote: > This is not a big deal for u-boot (maybe very marginally inefficient > when determining the actual memory size). Is this a big deal for > kernel? I mean it is easy to squash these seven memory banks into one > when filling out the m

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

Tom, On Tue, Apr 30, 2013 at 1:35 PM, Tom Rini wrote: > And I guess having this knowledge correct for the kernel is useful in > other contexts like when we want to power down some banks of memory > but not others? I mean, there's "lots" of platforms that lie and say > 1 bank since we require con

[U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

It appears that there are some cases where we have more than 4 banks of memory. Use CONFIG_NR_DRAM_BANKS if it's defined to handle this. This will take up a little extra stack space (64 bytes extra if we go up to 8 banks), but that seems OK. Signed-off-by: Doug Anderson --- Note: nothi

Re: [U-Boot] [PATCH] patman: Ignore all Gerrit Commit-* tags

Simon, On Wed, Apr 3, 2013 at 2:01 PM, Simon Glass wrote: > These tags are used by Gerrit, so let's ignore all of them. > > Signed-off-by: Simon Glass > --- > tools/patman/patchstream.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Rev

Re: [U-Boot] [PATCH v2 4/7] patman: Provide option to ignore bad aliases

n v2: > - Add comment about meaning of raise_on_error=False > - Remove 'ignore_errors' and just use 'raise_on_error' everywhere > - Use keyword args for raise_on_error Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 6/7] patman: Add Series-process-log tag to sort/uniq change logs

ols/patman/patchstream.py | 2 +- > tools/patman/series.py | 9 +++-- > 3 files changed, 16 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/7] patman: Don't allow spaces in tags

patman/commit.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/7] patman: Fix up checkpatch parsing to deal with 'CHECK' lines

+- > tools/patman/test.py | 64 +- > 2 files changed, 112 insertions(+), 62 deletions(-) Thanks for fixing and for fixing up the tests as well. Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] PATMAN: set In-Reply-To header?

Wolfgang, On Sun, Mar 24, 2013 at 3:41 PM, Simon Glass wrote: >> is there a way in patman to set the In-Reply-To header, or other >> methods to make sure re-submitted patches are properly threaded? > > I think Doug sent a patch for this recently. I will check with him. Yup. It's here

Re: [U-Boot] [PATCH 8/8] patman: Add Series-process-log tag to sort/uniq change logs

Simon, On Wed, Mar 20, 2013 at 7:43 PM, Simon Glass wrote: > For some series with lots of changes it is annoying that duplicate change > log items are not caught. It is also helpful sometimes to sort the change > logs. > > Add a Series-process-log tag to enable this, which can be placed in a > co

Re: [U-Boot] [PATCH 6/8] patman: Add -a option to refrain from test-applying the patches

ng spaces. > Provide a -a option to skip this step, for those working with clean patches. > > Signed-off-by: Simon Glass > --- > tools/patman/patman.py | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Doug Anderson __

Re: [U-Boot] [PATCH 5/8] patman: Provide option to ignore bad aliases

Simon, Nothing critical and this could go in as-is, but a few nits below. On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass wrote: > -raw += LookupEmail(item, alias) > +raw += LookupEmail(item, alias, raise_on_error=not ignore_errors) optional: Change it so functions are consistent

Re: [U-Boot] [PATCH 4/8] patman: Fix the comment in CheckTags to mention multiple tags

tions(+), 2 deletions(-) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/8] patman: Minor help message/README fixes

es changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/8] patman: Don't look for tags inside quotes

Simon, On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass wrote: > # Separates a tag: at the beginning of the subject from the rest of it > -re_subject_tag = re.compile('([^:]*):\s*(.*)') > +re_subject_tag = re.compile('([^:"]*):\s*(.*)') I'd go further and prevent all spaces. re_subject_tag = re.c

Re: [U-Boot] [PATCH 1/8] patman: Fix up checkpatch parsing to deal with 'CHECK' lines

Simon, On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass wrote: > checkpatch has a new type of warning, a 'CHECK'. At present patman fails > with these, which makes it less than useful. > > Add support for checks, making it backwards compatible with the old > checkpatch. There are also a few other mi

Re: [U-Boot] [PATCH 7/8] patman: Add Cover-letter-cc tag to Cc cover letter to people

| 11 --- > 3 files changed, 27 insertions(+), 4 deletions(-) Identical to the already posted <http://patchwork.ozlabs.org/patch/222755/> so I'll repeat my existing review. ;) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boo

[U-Boot] [PATCH v2] patman: Allow specifying the message ID your series is in reply to

Some versions of git don't seem to prompt you for the message ID that your series is in reply to. Allow specifying this from the command line. Signed-off-by: Doug Anderson Acked-by: Simon Glass --- Changes in v2: - Adjusted docstring wording as per Otavio Salvador. tools/patman/gitut

[U-Boot] [PATCH] patman: Make "Reviewed-by" an important tag

Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag used by upstream. Stripping it is undesirable. In fact, we should treat it as important. Signed-off-by: Doug Anderson --- tools/patman/README | 4 ++-- tools/patman/patchstream.py | 4 ++-- 2 f

[U-Boot] [PATCH] patman: Allow specifying the message ID your series is in reply to

Some versions of git don't seem to prompt you for the message ID that your series is in reply to. Allow specifying this from the command line. Signed-off-by: Doug Anderson --- tools/patman/gitutil.py | 7 ++- tools/patman/patman.py | 4 +++- 2 files changed, 9 insertions(+), 2 dele

[U-Boot] [PATCH] patman: Don't barf if the word 'commit' starts a line

Patman's regular expression for detecting the start of a commit in a git log was a little simplistic and could be confused if the git log itself had the word "commit" as the start of a line (as this commit does). Make patman a little more robust. Signed-off-by: Doug Anderson --

Re: [U-Boot] [PATCH] patman: Add Cover-letter-cc tag to Cc cover letter to people

| 11 --- > 3 files changed, 27 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/7] Add cros_ec driver.

Hung-ying Tyan, On Fri, Feb 8, 2013 at 5:05 AM, Hung-ying Tyan wrote: > Signed-off-by: Bernie Thompson > Signed-off-by: Bill Richardson > Signed-off-by: Che-Liang Chiou > Signed-off-by: Doug Anderson > Signed-off-by: Gabe Black > Signed-off-by: Hung-ying Tyan > Sign

Re: [U-Boot] [PATCH 1/7] Add cros_ec driver.

Hung-ying Tyran, On Fri, Feb 8, 2013 at 3:54 PM, Doug Anderson wrote: > Hung-ying Tyan, > > On Fri, Feb 8, 2013 at 5:05 AM, Hung-ying Tyan wrote: >> Signed-off-by: Bernie Thompson >> Signed-off-by: Bill Richardson >> Signed-off-by: Che-Liang Chiou >> Signed

[U-Boot] patman changes?

Hi, I posted a bunch of patman changes a bit ago and they've all been acked by Simon. Any chance of them landing? They're all visible here < http://patchwork.ozlabs.org/bundle/dianders/patman/> ...I think some of the changes have lost their acks on patchwork (I forgot to include Simon's v1 ack

Re: [U-Boot] Googlers please reply: commiters in U-Boot

I work for Google and have as long as I have had a chromium.org account. Anything from diand...@google.com or diand...@chromium.org can be attributed to Google. On Sat, Jan 12, 2013 at 9:20 AM, Simon Glass wrote: > Hi, > > You are being copied because you have written U-Boot code which is now > i

Re: [U-Boot] [PATCH v4] patman: Allow use outside of u-boot tree

> email (with --no-check option) >. successfully used patman in the u-boot tree to generate a patch > email >. `patman --help' now shows command line options ordered > alphabetically > > Signed-off-by: Vadim Bendebury Acked-by: Doug Anderson

Re: [U-Boot] [PATCH v2] patman: Allow use outside of u-boot tree

Vadim, Looks great with one last nit... On Wed, Jan 9, 2013 at 4:23 PM, Vadim Bendebury wrote: > + > +print >> sys.stderr, ('Cannot find checkpatch.pl - please put it in your > ' + > +'~/bin directory or use --no_patch') > +sys.exit(1) s/no_patch/no-patch __

Re: [U-Boot] [PATCH] patman: Allow use outside of u-boot tree

Vadim, On Wed, Jan 9, 2013 at 2:07 PM, Vadim Bendebury wrote: >>> +parser.add_option('--no-check', action='store_true', dest='no_check', >>> + default=False, >>> + help="Don't check for patch compliance") >> >> IMHO It would be slightly better to use action='stor

Re: [U-Boot] [PATCH] Make patman usable outside of u-boot tree

Vadim, Thanks for the patch! Looks good in general, though please add the "patman" prefix to the first line of your commit message. On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury wrote: > To make it usable in git trees not providing a patch checker > implementation, add a command line option,

[U-Boot] [PATCH v2 2/2] patman: Add all CC addresses to the cover letter

If we're sending a cover letter make sure to CC everyone that we're CCing on each of the individual patches. Signed-off-by: Doug Anderson --- Changes in v2: - Added requested comment in the README to document this. tools/patman/README|3 +++ tools/patman/patman.py |2

[U-Boot] [PATCH v2 1/2] patman: Cache the CC list from MakeCcFile() for use in ShowActions()

Currently we go through and generate the CC list for patches twice. This gets slow when (in a future CL) we add a call to get_maintainer.pl on Linux. Instead of doing things twice, just cache the CC list when it is first generated. Signed-off-by: Doug Anderson --- Changes in v2: None tools

[U-Boot] [PATCH v2 1/4] patman: Add a call to get_maintainer.pl if it exists

For Linux the best way to figure out where to send a patch is with the "get_maintainer.pl" script. Add support for calling it from patman. Support is added unconditionally for "scripts/get_maintainer.pl" in case it is helpful for any other projects. Signed-off-by: Doug Ande

[U-Boot] [PATCH v2 2/4] patman: Add support for settings in .patman

s functionality is also used in a future change which adds support for per-project settings. Signed-off-by: Doug Anderson --- Changes in v2: None tools/patman/README | 16 tools/patman/gitutil.py |2 -- tools/patman/patman.py |

[U-Boot] [PATCH v2 4/4] patman: Add settings to the list of modules to doctest

The settings modules now has doctests, so run them. Signed-off-by: Doug Anderson --- Changes in v2: None tools/patman/patman.py |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/patman/patman.py b/tools/patman/patman.py index 2e9e5dc..e56dd01 100755 --- a/tools

[U-Boot] [PATCH v2 3/4] patman: Add the concept of multiple projects

). * Extend the new "settings" feature in .patman to specify per-project settings. Signed-off-by: Doug Anderson --- Changes in v2: - Added requested short option: '-p'. tools/patman/README | 13 tools/patman/patman.py |9 +++- tools/patma

Re: [U-Boot] [PATCH 3/4] patman: Add the concept of multiple projects

Simon, Thanks! On Mon, Dec 3, 2012 at 3:04 PM, Simon Glass wrote: > Hi Doug, > > On Fri, Nov 30, 2012 at 4:29 PM, Doug Anderson wrote: >> There are cases that we want to support different settings (or maybe >> even different aliases) for different projects. Add s

Re: [U-Boot] [PATCH 2/2] patman: Add all CC addresses to the cover letter

Simon, Thanks for the review! On Mon, Dec 3, 2012 at 3:00 PM, Simon Glass wrote: > On Fri, Nov 30, 2012 at 4:25 PM, Doug Anderson wrote: >> If we're sending a cover letter make sure to CC everyone that we're >> CCing on each of the individual patches. >>

Re: [U-Boot] [PATCH v2 04/10] arm: Add CONFIG_DELAY_ENVIRONMENT to delay environment loading

/config/delay-environment. > > Note: This patch depends on http://patchwork.ozlabs.org/patch/194342/ > > Signed-off-by: Doug Anderson > Signed-off-by: Simon Glass > --- > Changes in v2: > - Update commit message to provide more detail > > README |

[U-Boot] [PATCH 1/2] patman: Cache the CC list from MakeCcFile() for use in ShowActions()

Currently we go through and generate the CC list for patches twice. This gets slow when (in a future CL) we add a call to get_maintainer.pl on Linux. Instead of doing things twice, just cache the CC list when it is first generated. Signed-off-by: Doug Anderson --- tools/patman/patman.py |6

[U-Boot] [PATCH 4/4] patman: Add settings to the list of modules to doctest

The settings modules now has doctests, so run them. Signed-off-by: Doug Anderson --- tools/patman/patman.py |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/patman/patman.py b/tools/patman/patman.py index 54a252e..6825de4 100755 --- a/tools/patman/patman.py

[U-Boot] [PATCH 2/4] patman: Add support for settings in .patman

s functionality is also used in a future change which adds support for per-project settings. Signed-off-by: Doug Anderson --- tools/patman/README | 16 tools/patman/gitutil.py |2 -- tools/patman/patman.py |3 +++ tools/patman/settings.py | 39

[U-Boot] [PATCH 1/4] patman: Add a call to get_maintainer.pl if it exists

For Linux the best way to figure out where to send a patch is with the "get_maintainer.pl" script. Add support for calling it from patman. Support is added unconditionally for "scripts/get_maintainer.pl" in case it is helpful for any other projects. Signed-off-by: Doug

[U-Boot] [PATCH 2/2] patman: Add all CC addresses to the cover letter

If we're sending a cover letter make sure to CC everyone that we're CCing on each of the individual patches. Signed-off-by: Doug Anderson --- tools/patman/patman.py |2 +- tools/patman/series.py | 12 +++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --g

[U-Boot] [PATCH 3/4] patman: Add the concept of multiple projects

). * Extend the new "settings" feature in .patman to specify per-project settings. Signed-off-by: Doug Anderson --- tools/patman/README | 13 tools/patman/patman.py |9 +++- tools/patman/project.py | 43 + tools/patman/settings

[U-Boot] [PATCH 1/2] patman: Add spaces back into patman test

The patman test code was failing because some extra spaces got stripped when it was applied. These spaces are critical to the test code working. Signed-off-by: Doug Anderson --- tools/patman/test.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/patman

[U-Boot] [PATCH] patman: Look for checkpatch in the scripts directory

The Linux kernel stores checkpatch.pl in the scripts directory. Add that to the search path to make things more automatic for kernel development. Signed-off-by: Doug Anderson --- tools/patman/checkpatch.py |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools

[U-Boot] [PATCH 2/2] patman: Allow tests to run even if patman is in the path

Several of the patman doctests assume that patman was run with: ./patman Fix them so that they work even if patman is run with just "patman" (because patman is in the path). Signed-off-by: Doug Anderson --- tools/patman/gitutil.py | 11 +-- 1 files changed, 9 insert

Re: [U-Boot] [PATCH] tegra: Specify debugging serial port at boot.

Stephen, On Wed, Mar 21, 2012 at 9:49 AM, Stephen Warren wrote: > I was under the impression that earlyprintk was a boolean option, and > didn't take any arguments. But, a quick grep shows that some archs do > allow it to take an argument. The ARM code that handles the option > doesn't process t

Re: [U-Boot] [PATCH] env: Add the ability to merge the saved env with the default.

Mike, On Mon, Mar 5, 2012 at 8:27 PM, Mike Frysinger wrote: > this is kind of a crappy interface. > Agreed. > also, doesn't the existing `env import` > do this ? > * env import [-d] [-t | -b | -c] addr [size] > * -d: delete existing environment before importing; > * otherwise overwr

Re: [U-Boot] [PATCH] EXYNOS: SMDK5250: Support all 4 UARTs

Mike, On Mon, Feb 13, 2012 at 11:00 PM, Mike Frysinger wrote: > i don't know the exynos5 pinmux specifics, but speaking in general, you > shouldn't go configuring pins directly if the user hasn't asked for them. > config multi would be useful because then the pinmux logic would be in a > uart- >

[U-Boot] [PATCH] env: Add the ability to merge the saved env with the default.

://git.chromium.org/git/chromiumos/platform/factory-utils). Signed-off-by: Doug Anderson --- common/env_common.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/common/env_common.c b/common/env_common.c index 71811c4..5938732 100644 --- a/common

[U-Boot] [PATCH v2] EXYNOS: SMDK5250: Support all 4 UARTs

This properly configures the mux to enable all UARTs. This also fixes things so that we don't configure balls XUCTSN_1 and XURTSN_1 as UART1 configuration (RTS/CTS), since they aren't connected. Signed-off-by: Doug Anderson --- Changes in v2: - Removed #ifdefs and tested SERIAL_MULTI

Re: [U-Boot] [PATCH] EXYNOS: SMDK5250: Add support for DDR3 memory.

On Wed, Feb 8, 2012 at 3:44 AM, Hatim Ali wrote: > SMDK5250 development boards have different memory variants like > DDR3, LPDDR2 and LPDDR3. This patch adds supports for DDR3. > The DDR3 is configured for 667Mhz and is being enabled by default. One other note: the SDRAM doesn't appear to be stab

[U-Boot] [PATCH] EXYNOS: SMDK5250: Support all 4 UARTs

This properly configures the mux to enable the right UART depending on the setting of CONFIG_SERIALX. This also fixes things so that we don't configure balls XUCTSN_1 and XURTSN_1 as UART1 configuration (RTS/CTS), since they aren't connected. Signed-off-by: Doug Anderson --- boa

Re: [U-Boot] [PATCH] EXYNOS: SMDK5250: Add support for DDR3 memory.

Hatim, Overall comments: * Random delays are evil. Please explain each sdelay() call. Be sure to include information about why exactly 65,536 iterations through a delay loop is necessary in each case. * For functions that are nearly the same between dmc_init.c and dmc_init_ddr3.c should be un

Re: [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

On Thu, Feb 2, 2012 at 1:21 PM, Mike Frysinger wrote: > On Thursday 02 February 2012 04:11:27 Chander Kashyap wrote: > > +int main(int argc, char **argv) > > +{ > > ... > > + unsigned char buffer[BUFSIZE] = {0}; > > this is an implicit memset() and from what i can see in the code, useless. >

[U-Boot] [PATCH v4] bootm: Avoid 256-byte overflow in fixup_silent_linux()

ength. If you have a command line that is >256 bytes it's up to you to make sure that kernel can handle it. Signed-off-by: Doug Anderson --- Changes in v2: - Tried to trim down to just the minimum changes needed with no extra helper code. Changes in v3: - Took Mike Frysinger's sugg

Re: [U-Boot] [PATCH v3] bootm: Avoid 256-byte overflow in fixup_silent_linux()

Mike, On Tue, Jan 17, 2012 at 11:27 AM, Mike Frysinger wrote: > On Tuesday 17 January 2012 14:16:53 Doug Anderson wrote: >> --- a/common/cmd_bootm.c >> +++ b/common/cmd_bootm.c >> >> +     char *env_val; > > did marking this const not work out ? I coded the pat

[U-Boot] [PATCH v3] bootm: Avoid 256-byte overflow in fixup_silent_linux()

ength. If you have a command line that is >256 bytes it's up to you to make sure that kernel can handle it. Signed-off-by: Doug Anderson --- Changes in v2: - Tried to trim down to just the minimum changes needed with no extra helper code. Changes in v3: - Took Mike Frysinger's sugg

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

Dear Wolfgang, On Wed, Jan 11, 2012 at 12:11 AM, Wolfgang Denk wrote: > I have to admit that I have no clear opinion here yet. > > The existing code is from a time when all architectures had a pretty > low limit on the command line size - IIRC even PPC had only 256 bytes > by then, hard coded. >

[U-Boot] [PATCH v2] bootm: Avoid 256-byte overflow in fixup_silent_linux()

ength. If you have a command line that is >256 bytes it's up to you to make sure that kernel can handle it. Signed-off-by: Doug Anderson --- Changes in v2: - Tried to trim down to just the minimum changes needed with no extra helper code. common/cmd_b

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

On Tue, Jan 10, 2012 at 3:44 PM, Mike Frysinger wrote: > On Tuesday 10 January 2012 18:38:07 Doug Anderson wrote: > getenv returns a writable buffer, so i wonder if things couldn't be avoided > easily all around.  after all, you're just deleting bytes here, not adding ne

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

Mike, On Tue, Jan 10, 2012 at 3:27 PM, Mike Frysinger wrote: > not sure why you don't just squash it into 1/3 and never bother defining it ? I was attempting to keep changes isolated as much as possible, but everyone seems to like to do this differently and I'm still getting a feel for what you

Re: [U-Boot] [PATCH v2 0/2] Deprecate Linux bootargs munging with CONFIG_SILENT_CONSOLE.

Dear Wolfgang Denk, On Tue, Jan 10, 2012 at 2:48 PM, Wolfgang Denk wrote: > You should do so in the commit mesage (but judging from my current > state of mind you can save the efforts for a v4). Got it. If we end up with a v4, I'll add it. > I just replied to one of your earlier patches that

Re: [U-Boot] [PATCH v2] bootm: Avoid 256-byte overflow in fixup_silent_linux()

Dear Wolfgang Denk, On Tue, Jan 10, 2012 at 2:28 PM, Wolfgang Denk wrote: >> This makes fixup_silent_linux() use malloc() to allocate its >> working space, meaning that our maximum kernel command line >> should only be limited by malloc().  Previously it was silently >> overflowing the stack. > .

Re: [U-Boot] [PATCH v2 0/2] Deprecate Linux bootargs munging with CONFIG_SILENT_CONSOLE.

Dear Wolfgang Denk On Tue, Jan 10, 2012 at 2:30 PM, Wolfgang Denk wrote: >> As discussed previously on the U-Boot mailing list (see comments on >> "Fix fixup_silent_linux() buffer overrun" patchset), relying on > > Please provide a link. Sure! This is the message I'm referring to:

[U-Boot] [PATCH v3 2/3] bootm: Move silencing of linux console to deprecated config option.

CONFIG_SILENT_CONSOLE. Signed-off-by: Doug Anderson --- Changes in v2: - Better description of CONFIG_SILENT_CONSOLE in README - Example of how to use a script to silence Linux console in a non- deprecated way in doc/README.silent Changes in v3: - Use __deprecated #define instead of direct gcc attribute - Minor

[U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

As Mike Frysinger writes: We didn't enable silent=1 by default in any of the Blackfin boards Just made the functionality available to people if they wanted to test things out with it when prototyping on dev boards. Signed-off-by: Doug Anderson --- Changes in v3: - Added part 3 of the

[U-Boot] [PATCH v3 1/3] config: Add CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

I have set this config option based on the existing usage of CONFIG_SILENT_CONSOLE. This is to support a future change deprecating the silencing of the linux console in bootm by having bootm modify the linux command-line arguments. Signed-off-by: Doug Anderson --- Changes in v2: - Define

[U-Boot] [PATCH v3 0/3] Deprecate Linux bootargs munging with CONFIG_SILENT_CONSOLE.

ackfin, where it was confirmed that it's not needed. Doug Anderson (3): config: Add CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE bootm: Move silencing of linux console to deprecated config option. config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE README

Re: [U-Boot] [PATCH 0/2] Deprecate Linux bootargs munging with CONFIG_SILENT_CONSOLE.

Dear Wolfgang Denk, On Tue, Jan 10, 2012 at 2:16 PM, Wolfgang Denk wrote: > In which way would this approach avoid the problem (potential overflow > of cmdline max size) that you are trying to fix with your patch? The overflow will be avoided on any boards that don't define CONFIG_DEPRECATED_SIL

[U-Boot] [PATCH v2 2/2] bootm: Move silencing of linux console to deprecated config option.

CONFIG_SILENT_CONSOLE. Signed-off-by: Doug Anderson --- Changes in v2: - Better description of CONFIG_SILENT_CONSOLE in README - Example of how to use a script to silence Linux console in a non- deprecated way in doc/README.silent README | 10 ++ common/cmd_bootm.c | 10 +- doc

[U-Boot] [PATCH v2 1/2] config: Add CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

I have set this config option based on the existing usage of CONFIG_SILENT_CONSOLE. This is to support a future change deprecating the silencing of the linux console in bootm by having bootm modify the linux command-line arguments. Signed-off-by: Doug Anderson --- Changes in v2: - Define

[U-Boot] [PATCH v2 0/2] Deprecate Linux bootargs munging with CONFIG_SILENT_CONSOLE.

mple of how to use a script to silence Linux console in a non- deprecated way in doc/README.silent Doug Anderson (2): config: Add CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE bootm: Move silencing of linux console to deprecated config option. README | 10 ++

  1   2   >