Johannes, On Thu, Sep 5, 2019 at 12:48 PM Johannes Berg <johan...@sipsolutions.net> wrote: > > On Tue, 2019-09-03 at 13:15 -0700, Douglas Anderson wrote: > > > > Let's give that a try. > > > > In theory (if there is enough adoption) this could help a tool more > > reliably find various versions of a commit. > > It's not quite as good as this (yet), but a very simple version of it > for git-send-email could be this: > > --- save as .git/hooks/sendemail-validate --- > #!/bin/sh > > set -e > > changeid=$(sed 's/^Change-Id: \(I.*\)$/\1/;t;d' $1) > date=$(date +%s) > sed 's/^Change-Id: I.*$//;T;d' -i $1 > sed "s/^From: /Message-Id: <$date-$changeid@changeid>\nFrom: /" -i $1 > #--- end script --- > > > It won't do the RFC/which patch of a series etc. but I consider that > less interesting. > > Actually, the important part for me is to be to be able to have change- > ids locally (e.g. for working with gerrit), and not have that leak out > to the community (that doesn't like them). > > As a maintainer in the community, I'll also need to change the > .git/hooks/commit-msg script that comes with gerrit to not add a Change- > Id if the commit comes with a Link: tag already, but that should be > easy.
Do you have any idea how to encourage adoption of your git hook? Would it make sense to do something like check it in to the Linux kernel somewhere? -Doug _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
